Skip to content

Conversation

@kapi-no
Copy link
Contributor

@kapi-no kapi-no commented Nov 28, 2024

Depends on:

#19028

Issues:

  • Watchdog reset reason bit is always set for the nRF54H20 DK regardless whether the reset is caused by the reset pin (RESET_PIN: 0x00000011) or software reset (RESET_SOFTWARE: 0x00000012).

Out standing items:

  • Changelog and the documentation update for the Failsafe module.

@github-actions github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Nov 28, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 28, 2024

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 28, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 9

Inputs:

Sources:

sdk-nrf: PR head: 34329a6411761de6e8c0c48784deab72e666e4a3

more details

sdk-nrf:

PR head: 34329a6411761de6e8c0c48784deab72e666e4a3
merge base: df2d439280ad87b0da19bc87985f742600819c7b
target head (main): df2d439280ad87b0da19bc87985f742600819c7b
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (5)
applications
│  ├── nrf_desktop
│  │  ├── configuration
│  │  │  ├── nrf54h20dk_nrf54h20_cpuapp
│  │  │  │  │ prj_release.conf
│  │  ├── doc
│  │  │  │ failsafe.rst
│  │  ├── src
│  │  │  ├── modules
│  │  │  │  ├── Kconfig.failsafe
│  │  │  │  │ failsafe.c
doc
│  ├── nrf
│  │  ├── releases_and_maturity
│  │  │  ├── releases
│  │  │  │  │ release-notes-changelog.rst

Outputs:

Toolchain

Version: b77d8c1312
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:b77d8c1312_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 93
  • ✅ Integration tests
    • ✅ desktop52_verification
Disabled integration tests
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@kapi-no kapi-no force-pushed the nrf_desktop_failsafe_with_hwinfo branch from 2fc73a2 to a95b89e Compare November 29, 2024 11:49
@kapi-no kapi-no requested a review from MarekPieta November 29, 2024 11:50
@kapi-no
Copy link
Contributor Author

kapi-no commented Nov 29, 2024

@MarekPieta, addressed your comments

@kapi-no
Copy link
Contributor Author

kapi-no commented Nov 29, 2024

The Watchdog issue should be fixed after addressing the comments from the Zephyr upstream PR that adds reset reason support for nRF54H20 SoC in the Zephyr HWinfo driver:

zephyrproject-rtos/zephyr#81751

@kapi-no kapi-no force-pushed the nrf_desktop_failsafe_with_hwinfo branch from a95b89e to 0b9f1ec Compare November 29, 2024 13:09
@kapi-no kapi-no force-pushed the nrf_desktop_failsafe_with_hwinfo branch from 0b9f1ec to 8f9db24 Compare December 16, 2024 10:03
@github-actions github-actions bot removed the manifest label Dec 16, 2024
@kapi-no kapi-no marked this pull request as ready for review December 16, 2024 10:04
@kapi-no kapi-no requested review from a team as code owners December 16, 2024 10:04
@kapi-no
Copy link
Contributor Author

kapi-no commented Dec 16, 2024

The issue is resolved as the HW info driver fixes are merged as part of the following PR:

nrfconnect/sdk-zephyr#2385

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

@kapi-no kapi-no force-pushed the nrf_desktop_failsafe_with_hwinfo branch from 8f9db24 to 5bf18be Compare December 16, 2024 11:15
@kapi-no kapi-no requested review from a team as code owners December 16, 2024 11:15
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Dec 16, 2024
@kapi-no kapi-no requested a review from MarekPieta December 16, 2024 11:16
@kapi-no kapi-no force-pushed the nrf_desktop_failsafe_with_hwinfo branch from 5bf18be to fc6ea57 Compare December 17, 2024 10:40
@kapi-no kapi-no force-pushed the nrf_desktop_failsafe_with_hwinfo branch from fc6ea57 to 4b9e906 Compare December 17, 2024 11:06
@kapi-no kapi-no requested a review from divipillai December 17, 2024 11:06
@kapi-no kapi-no force-pushed the nrf_desktop_failsafe_with_hwinfo branch from 4b9e906 to 00a9f74 Compare December 17, 2024 12:08
@kapi-no
Copy link
Contributor Author

kapi-no commented Dec 17, 2024

Rebased due to the CI failures. No file diff has changed (pure rebase).

@kapi-no
Copy link
Contributor Author

kapi-no commented Dec 17, 2024

@nordicjm, could you review the build system part?

Updated the nRF Desktop Failsafe module to use the Zephyr HWinfo
driver as its dependency instead of relying on the nrfx reset reason
helper.

Ref: NCSDK-25090

Signed-off-by: Kamil Piszczek <[email protected]>
Enabled the nRF Desktop Failsafe module in the release configuration
of the nRF54H20 DK target.

Ref: NCSDK-25090

Signed-off-by: Kamil Piszczek <[email protected]>
@kapi-no kapi-no force-pushed the nrf_desktop_failsafe_with_hwinfo branch from 00a9f74 to 34329a6 Compare December 17, 2024 13:31
@kapi-no
Copy link
Contributor Author

kapi-no commented Dec 17, 2024

Rebased due to the CI failures. No file diff has changed (pure rebase).

@nordicjm nordicjm merged commit 2d39eb9 into nrfconnect:main Dec 18, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-required PR must not be merged without tech writer approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants