Skip to content

Conversation

@magp-nordic
Copy link
Contributor

@magp-nordic magp-nordic commented Mar 3, 2025

Improve setting pins DQ2 and DQ3 to high state. Now it is done only when they are defined.

I left setting them to high by default. It is done the same way for QSPI driver in pinctrl_nrf.c, at least for DQ3 pin (RESET).
Also, DTS does not support setting default/initial state of a pin.

Based on #20806 , please, review only two last commits.

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Mar 3, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Mar 3, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 12

Inputs:

Sources:

sdk-nrf: PR head: 263007e8cfd01fa0a657d4af48e814c244fa2992

more details

sdk-nrf:

PR head: 263007e8cfd01fa0a657d4af48e814c244fa2992
merge base: 9bf3a8765ad6c92ad56ff40a7b4ac116b1110fbf
target head (main): c35c15e1fdcef48c5c15efa3a388d40d8f694b9b
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (2)
applications
│  ├── sdp
│  │  ├── mspi
│  │  │  ├── src
│  │  │  │  │ main.c
drivers
│  ├── mspi
│  │  │ mspi_nrfe.c

Outputs:

Toolchain

Version: 4ffa2202d5
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:4ffa2202d5_8bf7ca4353

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 43
  • ✅ Integration tests
    • ✅ test-low-level
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@github-actions
Copy link

github-actions bot commented Mar 3, 2025

You can find the documentation preview for this PR here.

@masz-nordic masz-nordic added this to the 3.0.0 milestone Mar 6, 2025
@magp-nordic magp-nordic force-pushed the NRFX-7104-vio-initial-state branch 4 times, most recently from bfcd065 to 7a30d4a Compare March 17, 2025 16:24
@magp-nordic magp-nordic marked this pull request as ready for review March 17, 2025 16:24
@magp-nordic magp-nordic requested review from a team as code owners March 17, 2025 16:24
@magp-nordic magp-nordic force-pushed the NRFX-7104-vio-initial-state branch 2 times, most recently from 1d681c1 to 2f958a2 Compare March 17, 2025 16:35
@magp-nordic magp-nordic force-pushed the NRFX-7104-vio-initial-state branch from 2f958a2 to 6d5223b Compare March 21, 2025 09:54
@magp-nordic magp-nordic requested a review from jaz1-nordic March 21, 2025 09:55
@sonarqubecloud
Copy link

@magp-nordic magp-nordic force-pushed the NRFX-7104-vio-initial-state branch from 6d5223b to 1feff5c Compare March 25, 2025 12:39
@magp-nordic magp-nordic force-pushed the NRFX-7104-vio-initial-state branch from 1feff5c to c48d2ec Compare March 25, 2025 16:00
@magp-nordic magp-nordic requested a review from masz-nordic March 25, 2025 16:00
Improve setting initial state of DQ2 and DQ3 and clearing when
changing mode to QUAD.

Signed-off-by: Magdalena Pastula <[email protected]>
Add checking if one data line is not assigned to more than one
GPIO pin.

Signed-off-by: Magdalena Pastula <[email protected]>
@magp-nordic magp-nordic force-pushed the NRFX-7104-vio-initial-state branch from c48d2ec to 263007e Compare March 25, 2025 16:05
@masz-nordic masz-nordic merged commit f7e5433 into nrfconnect:main Mar 26, 2025
14 checks passed
@magp-nordic magp-nordic deleted the NRFX-7104-vio-initial-state branch March 26, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants