Skip to content

Conversation

@Vge0rge
Copy link
Contributor

@Vge0rge Vge0rge commented Mar 12, 2025

This PR is a subset of the following PR here:
#17200

The commits are identical apart from some formatting in the commit which adds PSA compatibility layer for SSF.

This mainly fixes an initialization issue with the nRF IEEE 802.15.4 and IPC, please check the commits messages.

@Vge0rge Vge0rge requested review from a team as code owners March 12, 2025 14:19
@github-actions github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Mar 12, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Mar 12, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Mar 12, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 11

Inputs:

Sources:

sdk-nrf: PR head: 9819aeec0deb0dd22ce7266fc215d8dadc78bd3b

more details

sdk-nrf:

PR head: 9819aeec0deb0dd22ce7266fc215d8dadc78bd3b
merge base: 2c892154762f75bd9b5fda366a5756748f1d3880
target head (main): 2c892154762f75bd9b5fda366a5756748f1d3880
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (4)
subsys
│  ├── nrf_security
│  │  ├── src
│  │  │  ├── ssf_secdom
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  │ ssf_psa_core_compatibility.c
│  ├── sdfw_services
│  │  ├── Kconfig
│  │  ├── os
│  │  │  │ ssf_client_zephyr.c

Outputs:

Toolchain

Version: 7dbe0e2658
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:7dbe0e2658_8bf7ca4353

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 1734
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-chip
    • ✅ test-fw-nrfconnect-nrf-iot_cloud
    • ✅ test-fw-nrfconnect-nrf_crypto
    • ✅ test-fw-nrfconnect-tfm
    • ✅ test-sdk-find-my
    • ✅ test-sdk-dfu
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-thread
    • test-low-level
    • test-sdk-audio
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@github-actions
Copy link

You can find the documentation preview for this PR here.

@Vge0rge Vge0rge force-pushed the 54h20_psa_rng_fixes branch from aa89b5b to c4e6382 Compare March 18, 2025 13:46
@sonarqubecloud
Copy link

Copy link
Contributor

@tomi-font tomi-font left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments.

@Vge0rge
Copy link
Contributor Author

Vge0rge commented Mar 25, 2025

ping @nrfconnect/ncs-si-muffin @nrfconnect/ncs-aurora @nrfconnect/ncs-protocols-serialization @nrfconnect/ncs-merge

@Vge0rge Vge0rge force-pushed the 54h20_psa_rng_fixes branch 2 times, most recently from 19eb219 to 46e6572 Compare March 25, 2025 13:29
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vge0rge Vge0rge force-pushed the 54h20_psa_rng_fixes branch 2 times, most recently from 956366c to 4ee343b Compare March 26, 2025 12:58
Copy link
Contributor

@Damian-Nordic Damian-Nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments to nrfxlib PR but this one alone lgtm

@Vge0rge Vge0rge force-pushed the 54h20_psa_rng_fixes branch from 4ee343b to 4e12e65 Compare April 1, 2025 13:45
@github-actions github-actions bot removed the manifest label Apr 1, 2025
@Vge0rge Vge0rge removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Apr 1, 2025
Vge0rge added 2 commits April 2, 2025 07:53
Initialize the ssf_client earlier during the boot
process during post kernel.

ssf_client needs to be initialized before the
CONFIG_NRF_802154_SER_RADIO_INIT_PRIO since it is
used by the "nRF IEEE 802.15.4" protocol.

It also needs to be initialied after the IPC
IPC_SERVICE_REG_BACKEND_PRIORITY since the
IPC expects the protocol to be initialized.
Failing to do that will also trigger an assertion
in Zephyr.

Signed-off-by: Georgios Vasilakis <[email protected]>
There are two functions which are defined in the psa_crypto_core.h
and are implemented in psa_crypto.c which are used by the TLS
library.
These functions are:
psa_can_do_hash
psa_can_do_cipher

These functions just check if the drivers are initialized
before the relevant PSA crypto functions can be used.
In the case of SSF there is no initialization needed because
the PSA initialization happens inside the secure domain firmware
before the application boots.

These functions are added in a separate file since they only
exist to maintain compatibility with the PSA core from Oberon/mbedTLS
and they don't need to forward any call to the secure domain.

Signed-off-by: Georgios Vasilakis <[email protected]>
@Vge0rge Vge0rge force-pushed the 54h20_psa_rng_fixes branch from 4e12e65 to 9819aee Compare April 2, 2025 05:53
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Apr 2, 2025
@Vge0rge Vge0rge removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Apr 2, 2025
@nordicjm nordicjm merged commit 50bf382 into nrfconnect:main Apr 2, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants