Skip to content

Comments

boards: nordic: nrf54l20pdk: Increase RAM, Flash on FLPR#20988

Closed
nordic-segl wants to merge 1 commit intonrfconnect:mainfrom
nordic-segl:NRFX-7216_Increase-RAM-Flash-on-nRF54L20-FLPR
Closed

boards: nordic: nrf54l20pdk: Increase RAM, Flash on FLPR#20988
nordic-segl wants to merge 1 commit intonrfconnect:mainfrom
nordic-segl:NRFX-7216_Increase-RAM-Flash-on-nRF54L20-FLPR

Conversation

@nordic-segl
Copy link
Contributor

@nordic-segl nordic-segl commented Mar 18, 2025

Include sdk-zephyr from PR:
nrfconnect/sdk-zephyr#2629

Align Partition Manager configuration.

@nordic-segl nordic-segl requested review from a team, nordicjm and tejlmand as code owners March 18, 2025 07:52
@github-actions github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Mar 18, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Mar 18, 2025 •
edited
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
zephyr nrfconnect/sdk-zephyr@7684f58 nrfconnect/sdk-zephyr#2629 nrfconnect/sdk-zephyr#2629/files

⛔ DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Mar 18, 2025 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 11

Inputs:

Sources:

sdk-nrf: PR head: bed60b258eb5a165fc667a2786f491b07e55fec2
zephyr: PR head: 514328ecf766e0ae2a6054c307e7b1ad78c96650

more details

sdk-nrf:

PR head: bed60b258eb5a165fc667a2786f491b07e55fec2
merge base: 692c84b40b1d21a9629b9700ca99a523778658d7
target head (main): 26355eeec126466e6aefa11b0f700267d84e233b
Diff

zephyr:

PR head: 514328ecf766e0ae2a6054c307e7b1ad78c96650
merge base: 7684f5879a4373cff03f8f3abf4378ec8643cadf
target head (main): fbc220f29bdeb98b68fa83426fa936ceb6e6ffd9
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (9) 
Kconfig.nrf
subsys
│  ├── partition_manager
│  │  ├── Kconfig
│  │  │ pm.yml.vpr_launcher
west.yml
zephyr
│  ├── boards
│  │  ├── nordic
│  │  │  ├── nrf54l20pdk
│  │  │  │  ├── nrf54l20pdk_nrf54l20_cpuapp.yaml
│  │  │  │  ├── nrf54l20pdk_nrf54l20_cpuflpr.dts
│  │  │  │  │ nrf54l20pdk_nrf54l20_cpuflpr.yaml
│  ├── dts
│  │  ├── common
│  │  │  ├── nordic
│  │  │  │  │ nrf54l20.dtsi
│  ├── snippets
│  │  ├── nordic-flpr
│  │  │  ├── soc
│  │  │  │  │ nrf54l20_cpuapp.overlay

Outputs:

Toolchain

Version: 4ffa2202d5
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:4ffa2202d5_e579f9fbe6

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ❌ Build twister
  • ❌ Integration tests
    • ❌ test-sdk-audio
    • ❌ desktop52_verification
    • ❌ test-fw-nrfconnect-boot
    • ❌ test-fw-nrfconnect-apps
    • ❌ test-fw-nrfconnect-ble_samples
    • ❌ test-fw-nrfconnect-chip
    • ❌ test-fw-nrfconnect-nfc
    • ❌ test-fw-nrfconnect-nrf-iot_cloud
    • ❌ test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • ❌ test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • ❌ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • ❌ test-fw-nrfconnect-nrf-iot_samples
    • ❌ doc-internal
    • ❌ test-fw-nrfconnect-nrf-iot_thingy91
    • ❌ test-fw-nrfconnect-nrf_crypto
    • ❌ test-fw-nrfconnect-proprietary_esb
    • ❌ test-fw-nrfconnect-rpc
    • ❌ test-fw-nrfconnect-rs
    • ❌ test-fw-nrfconnect-fem
    • ❌ test-fw-nrfconnect-tfm
    • ❌ test-fw-nrfconnect-thread
    • ❌ test-fw-nrfconnect-zigbee
    • ❌ test-sdk-find-my
    • ❌ test-fw-nrfconnect-nrf-iot_mosh
    • ❌ test-fw-nrfconnect-nrf-iot_positioning
    • ❌ test-sdk-wifi
    • ❌ test-low-level
    • ❌ test-sdk-pmic-samples
    • ❌ test-sdk-mcuboot
    • ❌ test-sdk-dfu
    • ❌ test-fw-nrfconnect-ps
    • ❌ test-secdom-samples-public
    • ⚠️ test-fw-nrfconnect-fw-update

Note: This message is automatically posted and updated by the CI

@nordic-segl
Copy link
Contributor Author

nordic-segl commented Mar 18, 2025

See comments in PR to sdk-zephyr for memory map partitioning.

nordicjm
nordicjm reviewed Mar 18, 2025
View reviewed changes
subsys/partition_manager/Kconfig
Comment on lines +166 to +167
help
Size of RAM available for the vpr_launcher application (usually run on cpuapp).
Must match the size of the cpuapp_sram node.
Copy link
Contributor

@nordicjm nordicjm Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nrf54l15 does not match, is 188KiB in https://github.com/nrfconnect/sdk-zephyr/blob/3f337ca1170cd7aa9c4a62c1a9cce992e5caed90/dts/common/nordic/nrf54l15.dtsi which is 0x2f000 not 0x28000

Copy link
Contributor Author

@nordic-segl nordic-segl Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is nordic-flprsnippet that adds building of vpr_launcher.
It changes SRAM partitioning.

Value of 160k / 0x28000 is set here:
https://github.com/nrfconnect/sdk-zephyr/blob/main/snippets/nordic-flpr/soc/nrf54l15_cpuapp.overlay#L32

Not sure why it's done this way.

@github-actions
Copy link

github-actions bot commented Mar 18, 2025

You can find the documentation preview for this PR here.

@nordic-segl nordic-segl force-pushed the NRFX-7216_Increase-RAM-Flash-on-nRF54L20-FLPR branch from b155a78 to a24f7d8 Compare March 18, 2025 08:14
@nordic-segl nordic-segl force-pushed the NRFX-7216_Increase-RAM-Flash-on-nRF54L20-FLPR branch 8 times, most recently from d252e61 to 9338744 Compare March 20, 2025 13:12
@nordic-segl
boards: nordic: nrf54l20pdk: Increase RAM, Flash on FLPR
bed60b2 
Include sdk-zephyr from PR:
nrfconnect/sdk-zephyr#2629

Align Partition Manager configuration.

Signed-off-by: Sebastian Głąb <sebastian.glab@nordicsemi.no>
@nordic-segl nordic-segl force-pushed the NRFX-7216_Increase-RAM-Flash-on-nRF54L20-FLPR branch from 9338744 to bed60b2 Compare March 21, 2025 07:44
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 21, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Apr 21, 2025

This pull request has been marked as stale because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 7 days. Note, that you can always re-open a closed pull request at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nordicjm nordicjm nordicjm left review comments

@nordic-piks nordic-piks nordic-piks approved these changes

@tejlmand tejlmand Awaiting requested review from tejlmand tejlmand is a code owner

@mstasiaknordic mstasiaknordic Awaiting requested review from mstasiaknordic

Assignees

No one assigned

Labels

changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. DNM manifest manifest-zephyr Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nordic-segl @NordicBuilder @nordicjm @nordic-piks