Skip to content

Conversation

@trantanen
Copy link
Contributor

Use of CONFIG_UART_x_NRF_HW_ASYNC has been mostly removed earlier from SLM app side with PR #19720. Removing last few references.
This causes some overlays to become empty so they are deleted.
Also, removing from SLM shell.

@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Mar 31, 2025
@trantanen trantanen requested a review from a team March 31, 2025 11:31
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Mar 31, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 3

Inputs:

Sources:

sdk-nrf: PR head: 34a77df2d1a57f4e4d0e74ba7b36147331f62f72

more details

sdk-nrf:

PR head: 34a77df2d1a57f4e4d0e74ba7b36147331f62f72
merge base: db6b981054e3a7acd40e2a883af52013fde89d97
target head (main): 3d408ef01e7b886608abf142cf8c6afc2ccf3041
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (8)
applications
│  ├── serial_lte_modem
│  │  ├── doc
│  │  │  ├── nRF91_as_Zephyr_modem.rst
│  │  │  │ slm_description.rst
│  │  ├── overlay-ppp-without-cmux.conf
│  │  ├── overlay-zephyr-modem-external-mcu.conf
│  │  │ overlay-zephyr-modem-nrf9160dk-nrf52840.conf
samples
│  ├── cellular
│  │  ├── slm_shell
│  │  │  ├── boards
│  │  │  │  ├── nrf52840dk_nrf52840.conf
│  │  │  │  ├── nrf5340dk_nrf5340_cpuapp.conf
│  │  │  │  │ nrf7002dk_nrf5340_cpuapp.conf

Outputs:

Toolchain

Version: 4ffa2202d5
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:4ffa2202d5_8bf7ca4353

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 227
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-nrf-iot_serial_lte_modem
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@github-actions
Copy link

@trantanen trantanen removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Mar 31, 2025
@trantanen trantanen marked this pull request as ready for review March 31, 2025 12:35
@trantanen trantanen requested review from a team as code owners March 31, 2025 12:35
@trantanen trantanen requested a review from MarkusLassila March 31, 2025 13:15
Use of CONFIG_UART_x_NRF_HW_ASYNC has been mostly removed earlier from
SLM app side with PR nrfconnect#19720. Removing last few references.
This causes some overlays to become empty so they are deleted.
overlay-zephyr-modem-external-mcu.conf would only have
CONFIG_SLM_POWER_PIN so it's also removed and documentation updated
so that apps should define it.

Signed-off-by: Tommi Rantanen <[email protected]>
Use of CONFIG_UART_x_NRF_HW_ASYNC has been removed earlier from
SLM app side with PR nrfconnect#19720.

Signed-off-by: Tommi Rantanen <[email protected]>
@trantanen trantanen force-pushed the slm_uart_hw_async_remove branch from 88fd318 to 34a77df Compare April 1, 2025 06:34
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Apr 1, 2025
@trantanen trantanen removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Apr 1, 2025
@nordicjm nordicjm merged commit d47f869 into nrfconnect:main Apr 1, 2025
15 checks passed
@trantanen trantanen deleted the slm_uart_hw_async_remove branch May 13, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-required PR must not be merged without tech writer approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants