-
Notifications
You must be signed in to change notification settings - Fork 1.4k
enabled ed25519/KMU for b0 on nrf54l and Cut down configuration for B0 #21310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: bc57393e16452f23f89c55edc0b0a3790698ecff more detailssdk-nrf:
Github labels
List of changed files detected by CI (8)Outputs:ToolchainVersion: 7cbc0036f4 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
|
You can find the documentation preview for this PR here. |
nvlsianpu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved pluto's commits
38e5b4a to
ee93a8a
Compare
subsys/bootloader/Kconfig
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for my own shake, why do we set a different size depending on the FPROTECT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you disable FPROTECT you can fit more into b0, because fprotect can only protect 31k.
So, for example, if you want to enable a lot of stuff to debug, you may not fit in the FPROTECT area and need to disable it, then it automatically also brings the size of allowed code up.
Vge0rge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR basically includes PR 20812. I reviewed the last commits which set the configuration of the PSA_CORE_LITE and they seem OK to me.
Yes. That PR is required for the change to work. |
5072008 to
edb8b76
Compare
f9d2fd5 to
8c6640e
Compare
samples/bootloader/prj.conf
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should not be applying this for everything, add a boards/<board> Kconfig fragment, and it should have a file suffix because people expect the default one to all act the same way which is with logging
The commit defaults to usage of ed25519 signature with KMU, when building b0 for nrf54l. Signed-off-by: Dominik Ermel <[email protected]>
Configuration options that enable PSA lite with B0 NSIB. Signed-off-by: Dominik Ermel <[email protected]>
Cuts NCS banner and events/notifications to further reduce size. Signed-off-by: Dominik Ermel <[email protected]>
temporarily diabled Signed-off-by: Mateusz Michalek <[email protected]>
Testing requires upload of KMU keys, which is currently not available. Signed-off-by: Dominik Ermel <[email protected]>
frkv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
WARNING: The PR has changed with addition of defaulting ed25519/KMU in b0. That commit was not there previously as the base PR used for this has been enabling such configurations.
The original purpose of the cut down was to fit the PSA hardware crypto, so it would not make sense to keep the PR unless we now enable the ed25519 here.
This configuration allows B0 to use PSA crypto while still being able to fit into FPROTECT area.
Only three top commits.
Depends on #20812For CI to test from branch:
test_boot: testing_21310_b0_on_nrf54l