clang: Fix multiple warnings #21616
Merged
clang: Fix multiple warnings #21616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
manifest
changelog-entry-required
Contributor
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
Contributor
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: da9bdcd8aa5c810be13b137c74ea6780a3aa5f84 more detailssdk-nrf:
nrfxlib:
Github labels
List of changed files detected by CI (7)Outputs:ToolchainVersion: 7cbc0036f4 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
rlubos
approved these changes
Apr 10, 2025
tomi-font
approved these changes
Apr 10, 2025
tejlmand
force-pushed
the
clang_warning_fixes
branch
from
bb579bf to
c0d4c00
Compare
|
You can find the documentation preview for this PR here. |
nordic-piks
approved these changes
Apr 10, 2025
Contributor
|
Note: will need manual backporting to |
tejlmand
force-pushed
the
clang_warning_fixes
branch
3 times, most recently
from
922deee to
4f6974d
Compare
maciejbaczmanski
approved these changes
Apr 10, 2025
carlescufi
changed the title
tejlmand
force-pushed
the
clang_warning_fixes
branch
from
4f6974d to
be69e46
Compare
tejlmand
force-pushed
the
clang_warning_fixes
branch
from
be69e46 to
a7f45a2
Compare
Damian-Nordic
approved these changes
Apr 10, 2025
Contributor
Damian-Nordic
left a comment
Damian-Nordic
left a comment
There was a problem hiding this comment.
approving RPC server bits
Declaration of variables after a label inside a switch statement is a c23 extension, not c99. This results in the following warning when compiling with clang: > ..subsys/nrf_security/src/drivers/cracen/cracenpsa/src/ecdsa.c:407:3: > warning: label followed by a declaration is a C23 extension > 407 | size_t copylen = MIN(digestsz, opsz - hmac_op->tlen); > | ^ > 1 warning generated. There is no practical reason why the variable should be declared inside the switch statement, therefore move the declaration and place it together with declaration of other variables. Signed-off-by: Torsten Rasmussen <[email protected]>
Update Zephyr, mcuboot, and nrfxlib repositories to fix compilation warnings discovered by clang. Signed-off-by: Torsten Rasmussen <[email protected]>
Safeguard `cracen_signature_set_hashalgo_from_digestsz()` and `cracen_signature_set_hashalgo()` inside `PSA_MAX_RSA_KEY_BITS > 0`. Safeguard `can_sign()` inside > CONFIG_PSA_WANT_ALG_PURE_EDDSA || `CONFIG_PSA_WANT_ALG_ED25519PH || > CONFIG_PSA_WANT_ALG_ECDSA || CONFIG_PSA_WANT_ALG_HMAC All calls to `cracen_signature_set_hashalgo()` and `cracen_signature_set_hashalgo_from_digestsz()` are safeguarded in `PSA_MAX_RSA_KEY_BITS > 0` resulting in unused function warning because those static functions will never be used when the condition is not met. Similar for calls to `can_sign()`. Fixes: > ...subsys/nrf_security/src/drivers/cracen/cracenpsa/src/sign.c:41:12: > warning: unused function > 'cracen_signature_set_hashalgo' [-Wunused-function] > 41 | static int cracen_signature_set_hashalgo(... > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 1 warning generated. > ...subsys/nrf_security/src/drivers/cracen/cracenpsa/src/sign.c:46:12: > warning: unused function > 'cracen_signature_set_hashalgo_from_digestsz' [-Wunused-function] > 46 | static int cracen_signature_set_hashalgo_from_digestsz(... > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 1 warning generated. > ...subsys/nrf_security/src/drivers/cracen/cracenpsa/src/kmu.c:297:13: > warning: unused function 'can_sign' [-Wunused-function] > 297 | static bool can_sign(const psa_key_attributes_t *key_attr) > | ^~~~~~~~ > 1 warning generated. Signed-off-by: Torsten Rasmussen <[email protected]>
Verify return values for otPlatRadio* functions and log the error accordingly. For otPlatRadioTransmit() case, just log the error and let the entire TX procedure proceed on the next timeout. Signed-off-by: Robert Lubos <[email protected]>
Declaration of variables after a label inside a switch statement is a c23 extension, not c99. This results in the following warning when compiling with clang: > .../subsys/net/openthread/rpc/server/ot_rpc_netdiag.c:86:3: warning: > label followed by a declaration is a C23 extension [-Wc23-extensions] > 86 | uint8_t mode = 0; > | ^ > 1 warning generated. There are no practical reasons why the variable should be declared inside the switch statement, therefore move the declaration to top of function. Signed-off-by: Torsten Rasmussen <[email protected]>
carlescufi
force-pushed
the
clang_warning_fixes
branch
from
a7f45a2 to
da9bdcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages.