Skip to content

Conversation

ankuns
Copy link
Contributor

@ankuns ankuns commented Apr 11, 2025

This PR brings Zephyr with updated default tx-en-settle-time-us for the nrf21540 FEM to fix the spurious emission issue.

@ankuns ankuns requested review from a team as code owners April 11, 2025 10:07
@github-actions github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Apr 11, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Apr 11, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
zephyr nrfconnect/sdk-zephyr@59a8d2d nrfconnect/sdk-zephyr@4575fc8 (v4.0.99-ncs1-branch) nrfconnect/[email protected]

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Apr 11, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 6

Inputs:

Sources:

sdk-nrf: PR head: 61bd2af2997a3f0b507c848c2173d924861ac5b2
zephyr: PR head: 4575fc863ae46dc0f65593cb741660ddab1ba344

more details

sdk-nrf:

PR head: 61bd2af2997a3f0b507c848c2173d924861ac5b2
merge base: cda3c634611a6243a392b20c10077b52b77b59a3
target head (v3.0-branch): cda3c634611a6243a392b20c10077b52b77b59a3
Diff

zephyr:

PR head: 4575fc863ae46dc0f65593cb741660ddab1ba344
merge base: 59a8d2d1692d43086c0343e9ba87a800a2e93bc4
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (3)
doc
│  ├── nrf
│  │  ├── app_dev
│  │  │  ├── device_guides
│  │  │  │  ├── fem
│  │  │  │  │  │ fem_nrf21540_gpio.rst
west.yml
zephyr
│  ├── dts
│  │  ├── bindings
│  │  │  ├── net
│  │  │  │  ├── wireless
│  │  │  │  │  │ nordic,nrf21540-fem.yaml

Outputs:

Toolchain

Version: 7cbc0036f4
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:7cbc0036f4_8bf7ca4353

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 31
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-rs
    • ✅ test-fw-nrfconnect-fem
    • ✅ test-low-level
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

Copy link

github-actions bot commented Apr 11, 2025

You can find the documentation preview for this PR here.

Preview links for modified nRF Connect SDK documents:

https://ncsdoc.z6.web.core.windows.net/PR-21701/nrf/app_dev/device_guides/fem/fem_nrf21540_gpio.html

@ankuns ankuns requested review from e-rk and piotrkoziar April 11, 2025 10:51
@ankuns ankuns requested a review from a team as a code owner April 11, 2025 10:53
@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label Apr 11, 2025
@ankuns ankuns added this to the 3.0.0 milestone Apr 11, 2025
@ankuns ankuns force-pushed the nrf21540_fem_tx_en_timing_fix branch from c5cb07e to 842899b Compare April 11, 2025 13:29
@ankuns ankuns force-pushed the nrf21540_fem_tx_en_timing_fix branch from 842899b to 234701f Compare April 14, 2025 08:50
@NordicBuilder NordicBuilder removed the DNM label Apr 14, 2025
ankuns added 2 commits April 14, 2025 10:54
This PR brings Zephyr with updated default `tx-en-settle-time-us`
for the nrf21540 FEM to fix the spurious emission issue.

Signed-off-by: Andrzej Kuros <[email protected]>
The default timing value for the `tx-en-settle-time-us` property
is changed to 26. For the nrf54L the time is 1us bigger.
This commit adjusts fem doc recommendation for the nRF54L.

Signed-off-by: Andrzej Kuros <[email protected]>
@ankuns ankuns force-pushed the nrf21540_fem_tx_en_timing_fix branch from 234701f to 61bd2af Compare April 14, 2025 08:54
@ankuns ankuns removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Apr 14, 2025
@rlubos rlubos merged commit 44e5e47 into nrfconnect:v3.0-branch Apr 14, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-required PR must not be merged without tech writer approval. manifest manifest-zephyr

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants