Skip to content

docs: Add changelog for bt_mesh_adv_unref fix #22306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

docs: Add changelog for bt_mesh_adv_unref fix #22306

wants to merge 1 commit into from

Conversation

PavelVPV
Copy link
Contributor

Adds a change log for bt_mesh_adv_unref fix.

PR with the fix: #22221

@PavelVPV PavelVPV requested a review from a team as a code owner May 14, 2025 11:17
@PavelVPV PavelVPV added this to the 2.9.2 milestone May 14, 2025
@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label May 14, 2025
@PavelVPV PavelVPV mentioned this pull request May 14, 2025
Merged
@github-actions GitHub Actions
Copy link

After documentation is built, you will find the preview for this PR here.

Preview links for modified nRF Connect SDK documents:

https://ncsdoc.z6.web.core.windows.net/PR-22306/nrf/releases_and_maturity/releases/release-notes-changelog.html

@NordicBuilder
Copy link
Contributor

NordicBuilder commented May 14, 2025 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 2

Inputs:

Sources:

sdk-nrf: PR head: 1c2eee68c4416a58787a9da55fb0eca59bd47f62

more details

sdk-nrf:

PR head: 1c2eee68c4416a58787a9da55fb0eca59bd47f62
merge base: 938fdd739c99ef5cefac6a479940d97112be668d
target head (v2.9-branch): c64c882946ced3b3e2600a8821a0ac26d03b6897
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (1) 
doc
│  ├── nrf
│  │  ├── releases_and_maturity
│  │  │  ├── releases
│  │  │  │  │ release-notes-changelog.rst

Outputs:

Toolchain

Version:
Build docker image:

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain
  • ◻️ Build twister
  • ◻️ Integration tests
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@PavelVPV
Copy link
Contributor Author

@nrfconnect/ncs-doc-release please review asap 🙏

peknis
peknis requested changes May 14, 2025
View reviewed changes
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst Outdated
Copy link
Contributor

@peknis peknis May 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Fixed an issue where ``bt_mesh_adv_unref()`` function could assert when messaging to a proxy node.
* Fixed an issue where the :c:func:`bt_mesh_adv_unref` function could assert when messaging to a proxy node.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't work as this is not a public API.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But customers figured out that assertion happens in this function (dev zone case for the reference: https://devzone.nordicsemi.com/f/nordic-q-a/117593/assertion-fail-west_topdir-zephyr-subsys-bluetooth-mesh-adv-c). That is why I think it is important to write function name here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, then leave it with double backticks, but add the.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added!

@PavelVPV
docs: Add changelog for bt_mesh_adv_unref fix
1c2eee6 
Adds a change log for bt_mesh_adv_unref fix.

Signed-off-by: Pavel Vasilyev <[email protected]>
@PavelVPV PavelVPV force-pushed the backport_bt_mesh_adv_unref_assert_fix_to_2.9.2_changelog branch from 061f6d4 to 1c2eee6 Compare May 14, 2025 11:40
@github-actions GitHub Actions
Copy link

After documentation is built, you will find the preview for this PR here.

Preview links for modified nRF Connect SDK documents:

https://ncsdoc.z6.web.core.windows.net/PR-22306/nrf/releases_and_maturity/releases/release-notes-changelog.html

@PavelVPV PavelVPV requested a review from peknis May 14, 2025 11:41
@Balaklaka
Copy link
Contributor

This should be added to update docs for 2.9.2 PR: #22215

@divipillai
Copy link
Contributor

divipillai commented May 14, 2025 •
edited
Loading

This should be added to update docs for 2.9.2 PR: #22215

Thought of adding this to the 2.9.2 release notes after this PR is merged. But, it would be better to add it now, and close this PR.
Added the entry here: https://github.com/nrfconnect/sdk-nrf/pull/22215/files#diff-1eafd60ac3cd99890a8bc27774117cae2f8372f2eaa58b0afb26bc3f7b3f3570R132. We could close this PR. Thanks!

@PavelVPV
Copy link
Contributor Author

This should be added to update docs for 2.9.2 PR: #22215

Thought of adding this to the 2.9.2 release notes after this PR is merged. But, it would be better to add it now, and close this PR. Added the entry here: https://github.com/nrfconnect/sdk-nrf/pull/22215/files#diff-1eafd60ac3cd99890a8bc27774117cae2f8372f2eaa58b0afb26bc3f7b3f3570R132. We could close this PR. Thanks!

Then I close this PR and will post a comment in the mentioned PR instead.

@PavelVPV PavelVPV closed this May 14, 2025
@divipillai
Copy link
Contributor

This should be added to update docs for 2.9.2 PR: #22215

Thought of adding this to the 2.9.2 release notes after this PR is merged. But, it would be better to add it now, and close this PR. Added the entry here: https://github.com/nrfconnect/sdk-nrf/pull/22215/files#diff-1eafd60ac3cd99890a8bc27774117cae2f8372f2eaa58b0afb26bc3f7b3f3570R132. We could close this PR. Thanks!

Then I close this PR and will post a comment in the mentioned PR instead.

I have already added the entry here: https://github.com/nrfconnect/sdk-nrf/pull/22215/files#diff-1eafd60ac3cd99890a8bc27774117cae2f8372f2eaa58b0afb26bc3f7b3f3570R132. Please check.

@PavelVPV
Copy link
Contributor Author

This should be added to update docs for 2.9.2 PR: #22215

Thought of adding this to the 2.9.2 release notes after this PR is merged. But, it would be better to add it now, and close this PR. Added the entry here: https://github.com/nrfconnect/sdk-nrf/pull/22215/files#diff-1eafd60ac3cd99890a8bc27774117cae2f8372f2eaa58b0afb26bc3f7b3f3570R132. We could close this PR. Thanks!

Then I close this PR and will post a comment in the mentioned PR instead.

I have already added the entry here: https://github.com/nrfconnect/sdk-nrf/pull/22215/files#diff-1eafd60ac3cd99890a8bc27774117cae2f8372f2eaa58b0afb26bc3f7b3f3570R132. Please check.

I see, thanks! Everything is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peknis peknis peknis approved these changes

@divipillai divipillai divipillai approved these changes

Assignees

No one assigned

Labels

doc-required PR must not be merged without tech writer approval.

Projects

None yet

Milestone

2.9.2

Development

Successfully merging this pull request may close these issues.

5 participants

@PavelVPV @NordicBuilder @Balaklaka @divipillai @peknis