Skip to content

Conversation

adigie
Copy link
Member

@adigie adigie commented May 19, 2025

No description provided.

@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels May 19, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented May 19, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
matter nrfconnect/sdk-connectedhomeip@ab711a4 nrfconnect/sdk-connectedhomeip#616 nrfconnect/sdk-connectedhomeip#616/files
zephyr nrfconnect/sdk-zephyr@6131774 nrfconnect/sdk-zephyr#2792 nrfconnect/sdk-zephyr#2792/files

DNM label due to: 2 projects with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented May 19, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 23

Inputs:

Sources:

sdk-nrf: PR head: d9b522dd4cd2918d325ce231d28124514fb180d8
matter: PR head: 926f4cdfb01147fae0fdb3bae1a3a43f12617fb6
zephyr: PR head: 0087a083d76101e611c0c156c212f7bb6b0e9f55

more details

sdk-nrf:

PR head: d9b522dd4cd2918d325ce231d28124514fb180d8
merge base: d0189a6959cded3ca35737a37359d2fde26b0fef
target head (main): cffb09ccf70792b3c32b4bd38c1e341aec2630c7
Diff

matter:

PR head: 926f4cdfb01147fae0fdb3bae1a3a43f12617fb6
merge base: ab711a4c10ce17f498c9f804444e12546855cb37
target head (master): 0ce6fb09501d62c93d00263db1b1b1f087afd8ec
Diff

zephyr:

PR head: 0087a083d76101e611c0c156c212f7bb6b0e9f55
merge base: 6131774ed5598fde0d09eb266fec686c95e2f24b
target head (main): 9761288d1c61d676cf5e7501563c199db9007ae0
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (83)
doc
│  ├── nrf
│  │  ├── protocols
│  │  │  ├── thread
│  │  │  │  │ configuring.rst
modules
│  ├── lib
│  │  ├── matter
│  │  │  ├── config
│  │  │  │  ├── nrfconnect
│  │  │  │  │  ├── chip-module
│  │  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  │  ├── Kconfig
│  │  │  │  │  │  ├── Kconfig.defaults
│  │  │  │  │  │  │ Kconfig.features
│  │  │  │  ├── zephyr
│  │  │  │  │  │ Kconfig
│  │  │  ├── src
│  │  │  │  ├── include
│  │  │  │  │  ├── platform
│  │  │  │  │  │  ├── internal
│  │  │  │  │  │  │  ├── GenericPlatformManagerImpl_ZephyrNoSelect.h
│  │  │  │  │  │  │  │ GenericPlatformManagerImpl_ZephyrNoSelect.ipp
│  │  │  │  ├── inet
│  │  │  │  │  ├── BUILD.gn
│  │  │  │  │  ├── InetInterface.cpp
│  │  │  │  │  │ InetInterface.h
│  │  │  │  ├── platform
│  │  │  │  │  ├── BUILD.gn
│  │  │  │  │  ├── Zephyr
│  │  │  │  │  │  ├── DiagnosticDataProviderImpl.cpp
│  │  │  │  │  │  ├── PlatformManagerImpl.cpp
│  │  │  │  │  │  ├── PlatformManagerImpl.h
│  │  │  │  │  │  ├── ThreadStackManagerImpl.cpp
│  │  │  │  │  │  │ ThreadStackManagerImpl.h
│  │  │  │  │  ├── nrfconnect
│  │  │  │  │  │  ├── ConnectivityManagerImpl.cpp
│  │  │  │  │  │  ├── SystemPlatformConfig.h
│  │  │  │  │  │  ├── wifi
│  │  │  │  │  │  │  │ ConnectivityManagerImplWiFi.cpp
│  │  │  │  ├── system
│  │  │  │  │  ├── BUILD.gn
│  │  │  │  │  ├── SystemLayerImplZephyrNoSelect.cpp
│  │  │  │  │  ├── SystemLayerImplZephyrNoSelect.h
│  │  │  │  │  │ system.gni
│  │  │  │  ├── test_driver
│  │  │  │  │  ├── nrfconnect
│  │  │  │  │  │  │ prj.conf
│  ├── openthread
│  │  ├── CMakeLists.txt
│  │  ├── Kconfig
│  │  ├── Kconfig.nrf5
│  │  ├── include
│  │  │  │ openthread.h
│  │  ├── openthread.c
│  │  ├── platform
│  │  │  ├── CMakeLists.txt
│  │  │  ├── alarm.c
│  │  │  ├── ble.c
│  │  │  ├── diag.c
│  │  │  ├── entropy.c
│  │  │  ├── platform-zephyr.h
│  │  │  ├── radio.c
│  │  │  ├── radio_nrf5.c
│  │  │  │ settings.c
│  │  │ shell.c
samples
│  ├── matter
│  │  ├── common
│  │  │  ├── src
│  │  │  │  ├── app
│  │  │  │  │  │ matter_init.cpp
│  │  ├── lock
│  │  │  ├── Kconfig
│  │  │  ├── prj_thread_wifi_switched.conf
│  │  │  ├── src
│  │  │  │  ├── access
│  │  │  │  │  │ access_data_types.h
│  │  ├── thermostat
│  │  │  ├── src
│  │  │  │  ├── temp_sensor_manager.cpp
│  │  │  │  │ zcl_callbacks.cpp
│  ├── openthread
│  │  ├── cli
│  │  │  ├── prj.conf
│  │  │  ├── snippets
│  │  │  │  ├── ci
│  │  │  │  │  │ ci.conf
│  │  │  │  ├── logging
│  │  │  │  │  │ logging.conf
│  │  │  ├── src
│  │  │  │  │ low_power.c
│  │  ├── coap_client
│  │  │  ├── src
│  │  │  │  │ coap_client_utils.c
│  │  ├── coap_server
│  │  │  ├── prj.conf
│  │  │  ├── snippets
│  │  │  │  ├── logging
│  │  │  │  │  │ logging.conf
│  │  │  ├── src
│  │  │  │  │ coap_server.c
│  │  ├── coprocessor
│  │  │  ├── prj.conf
│  │  │  ├── src
│  │  │  │  │ nrf_802154_radio_wrapper.c
│  ├── wifi
│  │  ├── thread_coex
│  │  │  ├── src
│  │  │  │  │ ot_utils.c
subsys
│  ├── caf
│  │  ├── modules
│  │  │  │ net_state_ot.c
│  ├── net
│  │  ├── openthread
│  │  │  ├── rpc
│  │  │  │  ├── common
│  │  │  │  │  │ ot_rpc_lock_net_l2.c
tests
│  ├── subsys
│  │  ├── net
│  │  │  ├── openthread
│  │  │  │  ├── rpc
│  │  │  │  │  ├── server
│  │  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  │  ├── src
│  │  │  │  │  │  │  ├── instance_suite.c
│  │  │  │  │  │  │  │ mocks.c
west.yml
zephyr
│  ├── doc
│  │  │ zephyr.doxyfile.in
│  ├── include
│  │  ├── zephyr
│  │  │  ├── net
│  │  │  │  ├── net_if.h
│  │  │  │  │ openthread.h
│  ├── modules
│  │  ├── openthread
│  │  │  ├── CMakeLists.txt
│  │  │  ├── Kconfig
│  │  │  ├── include
│  │  │  │  │ openthread.h
│  │  │  ├── openthread.c
│  │  │  ├── platform
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── alarm.c
│  │  │  │  ├── ble.c
│  │  │  │  ├── diag.c
│  │  │  │  ├── entropy.c
│  │  │  │  ├── platform-zephyr.h
│  │  │  │  ├── radio.c
│  │  │  │  ├── radio_spinel.cpp
│  │  │  │  │ settings.c
│  │  │  │ shell.c
│  ├── subsys
│  │  ├── net
│  │  │  ├── l2
│  │  │  │  ├── openthread
│  │  │  │  │  ├── openthread.c
│  │  │  │  │  │ openthread_utils.c
│  ├── tests
│  │  ├── subsys
│  │  │  ├── openthread
│  │  │  │  │ radio_stub.c

Outputs:

Toolchain

Version: 4aa3467a6d
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:4aa3467a6d_e85602c25f

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 847
    • sdk-zephyr test count: 1457
  • ❌ Integration tests
    • ✅ desktop52_verification
    • ✅ test-fw-nrfconnect-apps
    • ✅ test-fw-nrfconnect-chip
    • ✅ test-fw-nrfconnect-nfc
    • ❌ test-fw-nrfconnect-nrf-iot_cloud
    • ✅ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • ✅ test-fw-nrfconnect-nrf-iot_thingy91
    • ❌ test-fw-nrfconnect-rs
    • ❌ test-fw-nrfconnect-fem
    • ❌ test-fw-nrfconnect-thread-main
    • ✅ test-sdk-find-my
    • ✅ test-fw-nrfconnect-nrf-iot_mosh
    • ✅ test-fw-nrfconnect-nrf-iot_positioning
    • ❌ test-sdk-wifi
    • ✅ test-low-level
    • ✅ test-fw-nrfconnect-ps-main
    • ⚠️ test-sdk-dfu
Disabled integration tests
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-tfm
    • test-sdk-audio
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@adigie adigie force-pushed the ot-radio-matter branch 5 times, most recently from b3edd53 to 4edfc09 Compare May 26, 2025 14:42
@adigie adigie changed the title Use radio_nrf in Matter [DNM] Use radio_nrf in Matter May 27, 2025
@adigie adigie marked this pull request as ready for review May 27, 2025 11:01
@adigie adigie requested review from a team as code owners May 27, 2025 11:01
@adigie adigie force-pushed the ot-radio-matter branch from 4edfc09 to 3670902 Compare May 27, 2025 12:27
Copy link

You can find the documentation preview for this PR here.

Preview links for modified nRF Connect SDK documents:

https://ncsdoc.z6.web.core.windows.net/PR-22410/nrf/protocols/thread/configuring.html

@adigie adigie force-pushed the ot-radio-matter branch from 3670902 to dbb15c0 Compare May 27, 2025 13:02
@adigie adigie requested review from a team as code owners May 27, 2025 13:02
@adigie adigie force-pushed the ot-radio-matter branch 2 times, most recently from 02c2951 to 427633e Compare May 28, 2025 11:18
Copy link

Since quarantine was modified, please make sure you are following the process described in Quarantine Process.

@adigie adigie force-pushed the ot-radio-matter branch from 824a158 to 3515945 Compare May 29, 2025 19:51
ArekBalysNordic and others added 4 commits May 30, 2025 10:42
Updated modules/openthread/platform after latest changes in
Zephyr.

Aligned openthread implementation to the new approach.

Signed-off-by: Arkadiusz Balys <[email protected]>
Stop using L2 log level in platform files.

Signed-off-by: Arkadiusz Balys <[email protected]>
The new CONFIG_OPENTHREAD_SYS_INIT Kconfig option allows OpenThread
to be automatically initialised during the Zephyr POST_KERNEL
initialisation stage.

If Zephyr's L2 layer OpenThread implementation is enabled, the
IEEE802.15.4 shim layer initialises OpenThread in the POST_KERNEL
phase. However, since Openthread may work without Zephyr's L2
layer, in this case, no object can initialise it automatically.
This new Kconfig option may help start OpenThread automatically
if the L2 Layer is disabled.

Signed-off-by: Arkadiusz Balys <[email protected]>
Signed-off-by: Adrian Gielniewski <[email protected]>
* Add header with public API of OpenThread module.
* Add module include directory to Zephyr include directories.
* Use new header in platform implementation.

Signed-off-by: Adrian Gielniewski <[email protected]>
@adigie adigie force-pushed the ot-radio-matter branch from 3515945 to ad788ec Compare May 30, 2025 09:41
adigie and others added 12 commits May 30, 2025 12:31
Use new API from OpenThread module header.

Signed-off-by: Adrian Gielniewski <[email protected]>
Add new Kconfig options to enable platform-specific features in
OpenThread:

- CONFIG_OPENTHREAD_PLATFORM_PKT_TXTIME enables support for packet TX
time when CONFIG_NET_PKT_TXTIME is selected.
- CONFIG_OPENTHREAD_PLATFORM_CARRIER_FUNCTIONS enables modulated and
continuous carrier functions when CONFIG_OPENTHREAD_DIAG and
CONFIG_IEEE802154_CARRIER_FUNCTIONS are enabled.

Update preprocessor conditionals to use the new options instead of
relying directly on CONFIG_NET_PKT_TXTIME and
CONFIG_IEEE802154_CARRIER_FUNCTIONS.

This change improves configurability and allows to reuse the platform
implementation when not using Zephyr networking.

Upstream PR #: 90737

Signed-off-by: Adrian Gielniewski <[email protected]>
Update sdk-zephyr.

Signed-off-by: Adrian Gielniewski <[email protected]>
Signed-off-by: Adrian Gielniewski <[email protected]>
To start working with a new implementation of the OpenThread radio
platform, we need to have the dedicated radio_nrf5.c file and
kconfig to switch between legacy Zephyr's IEEE802.15.4 shim layer
and direct nrf5 radio driver implementations.

Signed-off-by: Arkadiusz Balys <[email protected]>
Prepared build environment to support building OpenThread
without Zephyr's L2 and IEEE802.15.4 shim layers.
To do it, some of Kconfigs must be cloned into the new
Kconfig file (dedicated to nRF5-driver-based approach)
to meet all OpenThread requirements while NET_L2_OPENTHREAD
is disabled.

Signed-off-by: Arkadiusz Balys <[email protected]>
Stop using L2 log level in platform files.

Signed-off-by: Arkadiusz Balys <[email protected]>
Align Kconfigs

Signed-off-by: Adrian Gielniewski <[email protected]>
Add alternative radio implementation that does not use Zephyr L2.

Signed-off-by: Adrian Gielniewski <[email protected]>
Add nrf5 radio implementation.

Signed-off-by: Adrian Gielniewski <[email protected]>
Update docs.

Signed-off-by: Adrian Gielniewski <[email protected]>
@adigie adigie force-pushed the ot-radio-matter branch from ad788ec to f698a33 Compare May 30, 2025 10:37
adigie added 5 commits May 30, 2025 16:02
Move ACK handling out of radio callback.

Signed-off-by: Adrian Gielniewski <[email protected]>
Update Matter SDK revision.

Signed-off-by: Adrian Gielniewski <[email protected]>
Configure OpenThread endpoints during Matter init.

Signed-off-by: Adrian Gielniewski <[email protected]>
Add missing includes.

Signed-off-by: Adrian Gielniewski <[email protected]>
Signed-off-by: Adrian Gielniewski <[email protected]>
@adigie adigie force-pushed the ot-radio-matter branch from f698a33 to d9b522d Compare May 30, 2025 14:03
@NordicBuilder
Copy link
Contributor

This pull request has been marked as stale because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 7 days. Note, that you can always re-open a closed pull request at any time.

@adigie adigie deleted the ot-radio-matter branch July 16, 2025 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. DNM doc-required PR must not be merged without tech writer approval. manifest manifest-matter manifest-zephyr Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants