Nrfx 7013 add i2s additional tests #22444

nordic-segl · 2025-05-21T12:52:27Z

No description provided.

NordicBuilder · 2025-05-21T12:53:51Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

NordicBuilder · 2025-05-21T12:55:27Z

CI Information

^{To view the history of this post, clich the 'edited' button above}
Build number: 20

Inputs:

Sources:

sdk-nrf: PR head: c2f4b16f541958a9c3106c51540130e017a8ef87

more details

sdk-nrf:

PR head: c2f4b16f541958a9c3106c51540130e017a8ef87
merge base: 6795b9803292afcda1ec62fdbbcd2d6718ecd131
target head (main): 734014a82b5f373e6a5b1ef5c96699069b0f8826
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (14)

tests
│  ├── drivers
│  │  ├── i2s
│  │  │  ├── i2s_additional
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── Kconfig
│  │  │  │  ├── boards
│  │  │  │  │  ├── nrf52840dk_nrf52840.conf
│  │  │  │  │  ├── nrf52840dk_nrf52840.overlay
│  │  │  │  │  ├── nrf5340dk_nrf5340_cpuapp.overlay
│  │  │  │  │  ├── nrf5340dk_nrf5340_cpuapp_aclk.overlay
│  │  │  │  │  ├── nrf54h20dk_nrf54h20_cpuapp.overlay
│  │  │  │  │  ├── nrf54l15dk_nrf54l15_cpuapp.overlay
│  │  │  │  │  ├── nrf54lm20pdk_nrf54lm20a_cpuapp.overlay
│  │  │  │  │  ├── nrf54lm20pdk_nrf54lm20a_cpuapp_0_0_0.overlay
│  │  │  │  │  │ nrf54lm20pdk_nrf54lm20a_cpuapp_0_2_0_csp.overlay
│  │  │  │  ├── prj.conf
│  │  │  │  ├── src
│  │  │  │  │  │ main.c
│  │  │  │  │ testcase.yaml

Outputs:

Toolchain

Version: 4aa3467a6d
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:4aa3467a6d_776d264d2e

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

◻️ Toolchain - Skipped: existing toolchain is used
❌ Build twister
- sdk-nrf test count: 6
❌ Integration tests

Disabled integration tests

- test-fw-nrfconnect-nrf-lrcs_mosh
- test-fw-nrfconnect-nrf-lrcs_positioning
- desktop52_verification
- doc-internal
- test_ble_nrf_config
- test-fw-nrfconnect-apps
- test-fw-nrfconnect-ble_mesh
- test-fw-nrfconnect-ble_samples
- test-fw-nrfconnect-boot
- test-fw-nrfconnect-chip
- test-fw-nrfconnect-fem
- test-fw-nrfconnect-nfc
- test-fw-nrfconnect-nrf-iot_cloud
- test-fw-nrfconnect-nrf-iot_lwm2m
- test-fw-nrfconnect-nrf-iot_samples
- test-fw-nrfconnect-nrf-iot_serial_lte_modem
- test-fw-nrfconnect-nrf-iot_thingy91
- test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
- test-fw-nrfconnect-nrf_crypto
- test-fw-nrfconnect-ps-main
- test-fw-nrfconnect-rpc
- test-fw-nrfconnect-rs
- test-fw-nrfconnect-tfm
- test-fw-nrfconnect-thread-main
- test-low-level
- test-sdk-audio
- test-sdk-find-my
- test-sdk-mcuboot
- test-sdk-wifi
- test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

github-actions · 2025-05-21T13:29:45Z

You can find the documentation preview for this PR here.

tests/drivers/i2s/i2s_additional/testcase.yaml

nordic-piks · 2025-05-22T05:09:33Z

tests/drivers/i2s/i2s_additional/src/main.c

I copy some code from existing test. This is the copyright owner of the source.

nordic-segl · 2025-05-22T11:06:51Z

Works in CI:

12:53:22  INFO    - 1/4 nrf54l15dk/nrf54l15/cpuapp drivers.i2s.additional.gpio_loopback               PASSED (device: 1057735411, 3.745s <zephyr>)
12:53:22  INFO    - 2/4 nrf5340dk/nrf5340/cpuapp  drivers.i2s.additional.gpio_loopback               PASSED (device: 1050076668, 3.604s <zephyr>)
12:53:22  INFO    - 3/4 nrf5340dk/nrf5340/cpuapp  drivers.i2s.additional.gpio_loopback.aclk          PASSED (device: 1050068404, 3.653s <zephyr>)
12:53:23  INFO    - 4/4 nrf52840dk/nrf52840       drivers.i2s.additional.gpio_loopback               PASSED (device: 1050272802, 4.439s <zephyr>)

12:56:08  INFO    - 1/1 [email protected]/nrf54h20/cpuapp drivers.i2s.additional.gpio_loopback.54h           PASSED (device: 1051112728, 5.689s <zephyr>)

12:52:49  INFO    - 1/1 [email protected]/nrf54lm20a/cpuapp drivers.i2s.additional.gpio_loopback               PASSED (device: 175104789, 2.704s <zephyr>)

13:06:17  INFO    - 1/2 [email protected]/nrf54lm20a/cpuapp drivers.i2s.additional.gpio_loopback               PASSED (device: 1051885387, 5.654s <zephyr>)
13:06:17  INFO    - 2/2 [email protected]/nrf54lm20a/cpuapp drivers.i2s.additional.gpio_loopback               PASSED (device: 1051500724, 5.572s <zephyr>)

bjarki-andreasen

While the tests look good, why add it upstream?

nordic-segl · 2025-05-28T09:46:32Z

While the tests look good, why add it upstream?

I took existing test that assumes 16 bit word_size and I used it in tests with 8/24/32 bit word_size. The way I aligned code to work at 8/24/32 bit is incorrect from technical point of view. F.e. code defines array of 16 bit sinus samples. When transmission is 8 bit, instead of casting 16 bit value into 8 bit, I split every sinus sample into two samples. Then, I send MSB in even sample and LSB in odd sample. When transmission is 32 bit, I "glue" two 16 bit samples into one 32 bit sample.
Test is passing because it only verifies that received data is same as transmitted. If there was audio codec, it would generate corrupted sound.
TDM driver is not merged in upstream. While it can be tested in NCS.
Idea was to confirm TDM operation on nRF54LM20 while this target is defined in NCS only.

Extend I2S testing with additional test cases that verify I2S/TDM driver operation at various configurations. Check: - word sizes of 8, 16, 24, 32 and 48 bits; - one, two, four and eight audio channels configuration; - data format I2S, Left Justified, Right Justified, PCM Long, PCM Short; - data order MSB and LSB first; - bit clock and frame clock inversion; - block size of 6 bytes; - bit clock continuous and gated; - internal loopback; - pingpong option. Signed-off-by: Sebastian Głąb <[email protected]>

nordic-segl · 2025-06-18T09:04:43Z

Merged in the Zephyr upstream
zephyrproject-rtos/zephyr#90732
nrfconnect/sdk-zephyr#2967

nordic-segl requested review from a team as code owners May 21, 2025 12:52

github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels May 21, 2025

NordicBuilder added manifest-zephyr DNM labels May 21, 2025

nordic-segl force-pushed the NRFX-7013_Add-i2s_additional-tests branch 2 times, most recently from 56ac38d to f80290e Compare May 21, 2025 13:26

nordic-segl force-pushed the NRFX-7013_Add-i2s_additional-tests branch 2 times, most recently from 10af6d9 to 97d9997 Compare May 21, 2025 14:02

nordic-piks reviewed May 22, 2025

View reviewed changes

tests/drivers/i2s/i2s_additional/testcase.yaml Outdated Show resolved Hide resolved

nordic-piks reviewed May 22, 2025

View reviewed changes

nordic-piks approved these changes May 22, 2025

View reviewed changes

nordic-segl force-pushed the NRFX-7013_Add-i2s_additional-tests branch 4 times, most recently from d2d16aa to d7f6d4b Compare May 22, 2025 11:03

nordic-segl force-pushed the NRFX-7013_Add-i2s_additional-tests branch 3 times, most recently from 99c79eb to 88bac2d Compare May 27, 2025 10:38

github-actions bot removed the manifest label May 27, 2025

NordicBuilder removed manifest-zephyr DNM labels May 27, 2025

bjarki-andreasen requested changes May 28, 2025

View reviewed changes

nordic-segl force-pushed the NRFX-7013_Add-i2s_additional-tests branch 7 times, most recently from 223567b to 018e83d Compare June 3, 2025 07:58

nordic-segl force-pushed the NRFX-7013_Add-i2s_additional-tests branch from 018e83d to 518e313 Compare June 6, 2025 06:00

nordic-segl force-pushed the NRFX-7013_Add-i2s_additional-tests branch from 518e313 to c2f4b16 Compare June 16, 2025 11:21

nordicjm approved these changes Jun 17, 2025

View reviewed changes

nordic-segl closed this Jun 18, 2025

nordic-segl deleted the NRFX-7013_Add-i2s_additional-tests branch June 18, 2025 13:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Nrfx 7013 add i2s additional tests #22444

Nrfx 7013 add i2s additional tests #22444

Uh oh!

nordic-segl commented May 21, 2025

Uh oh!

NordicBuilder commented May 21, 2025 •

edited

Loading

Uh oh!

NordicBuilder commented May 21, 2025 •

edited

Loading

Uh oh!

github-actions bot commented May 21, 2025

Uh oh!

Uh oh!

nordic-piks May 22, 2025

Uh oh!

nordic-segl May 22, 2025

Uh oh!

nordic-segl commented May 22, 2025

Uh oh!

bjarki-andreasen left a comment

Uh oh!

nordic-segl commented May 28, 2025

Uh oh!

nordic-segl commented Jun 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Nrfx 7013 add i2s additional tests #22444

Nrfx 7013 add i2s additional tests #22444

Uh oh!

Conversation

nordic-segl commented May 21, 2025

Uh oh!

NordicBuilder commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NordicBuilder commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

Uh oh!

github-actions bot commented May 21, 2025

Uh oh!

Uh oh!

nordic-piks May 22, 2025

Choose a reason for hiding this comment

Uh oh!

nordic-segl May 22, 2025

Choose a reason for hiding this comment

Uh oh!

nordic-segl commented May 22, 2025

Uh oh!

bjarki-andreasen left a comment

Choose a reason for hiding this comment

Uh oh!

nordic-segl commented May 28, 2025

Uh oh!

nordic-segl commented Jun 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

NordicBuilder commented May 21, 2025 •

edited

Loading

NordicBuilder commented May 21, 2025 •

edited

Loading