Skip to content

Conversation

@57300
Copy link
Contributor

@57300 57300 commented May 22, 2025

The sysbuild_dt_* CMake API came from upstream Zephyr PR #: 73903. This had been in review for almost a year, and in the end, the proposed API ended up being replaced.

This merits an entry in the migration guide. Note that since the API was cherry-picked from PR, there's no deprecation process.

@57300 57300 requested review from a team as code owners May 22, 2025 11:52
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels May 22, 2025
@57300 57300 force-pushed the sysbuild-dt-migrate branch from d545ad2 to 6dbc604 Compare May 22, 2025 11:53
@NordicBuilder
Copy link
Contributor

NordicBuilder commented May 22, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
matter nrfconnect/sdk-connectedhomeip@4ec4f3b nrfconnect/sdk-connectedhomeip@ab711a4 (master) nrfconnect/[email protected]
zephyr nrfconnect/sdk-zephyr@ad267ac nrfconnect/sdk-zephyr@f1626fa (main) nrfconnect/[email protected]

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented May 22, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 8

Inputs:

Sources:

sdk-nrf: PR head: 284e7a52c8ed275910109e3b0912301529bd1d83
matter: PR head: ab711a4c10ce17f498c9f804444e12546855cb37
zephyr: PR head: f1626faca7b6ff5a2a7f45ee2b085599999c08ed

more details

sdk-nrf:

PR head: 284e7a52c8ed275910109e3b0912301529bd1d83
merge base: 328d8bd10e9cd212701c518066d85fb380f607f9
target head (main): f4e7c5d689dc94a03f0f92cf1884e4cf59f7eca8
Diff

matter:

PR head: ab711a4c10ce17f498c9f804444e12546855cb37
merge base: 4ec4f3bcbcabd69969a628f9bb328501566a8cd7
Diff

zephyr:

PR head: f1626faca7b6ff5a2a7f45ee2b085599999c08ed
merge base: ad267ac6302f390e3387d5e7d79974f36214c6a5
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (26)
cmake
│  ├── sysbuild
│  │  ├── fast_pair
│  │  │  │ hex.cmake
│  │  ├── image_signing_nrf700x.cmake
│  │  ├── nrf700x.cmake
│  │  │ suit_provisioning.cmake
doc
│  ├── nrf
│  │  ├── releases_and_maturity
│  │  │  ├── migration
│  │  │  │  │ migration_guide_3.1.rst
modules
│  ├── lib
│  │  ├── matter
│  │  │  ├── config
│  │  │  │  ├── nrfconnect
│  │  │  │  │  ├── chip-module
│  │  │  │  │  │  │ generate_factory_data_sysbuild.cmake
west.yml
zephyr
│  ├── boards
│  │  ├── nordic
│  │  │  ├── nrf21540dk
│  │  │  │  │ nrf21540dk_nrf52840.dts
│  │  │  ├── nrf52833dk
│  │  │  │  │ nrf52833dk_nrf52833.dts
│  │  │  ├── nrf52840dk
│  │  │  │  │ nrf52840dk_nrf52840.dts
│  │  │  ├── nrf52dk
│  │  │  │  │ nrf52dk_nrf52832.dts
│  │  │  ├── nrf5340_audio_dk
│  │  │  │  │ nrf5340_audio_dk_nrf5340_cpuapp_common.dtsi
│  │  │  ├── nrf5340dk
│  │  │  │  │ nrf5340_cpuapp_common.dtsi
│  │  │  ├── nrf54h20dk
│  │  │  │  │ nrf54h20dk_nrf54h20_cpuapp.dts
│  │  │  ├── nrf54l15dk
│  │  │  │  │ nrf54l_05_10_15_cpuapp_common.dtsi
│  │  │  ├── nrf54l20pdk
│  │  │  │  │ nrf54l20_cpuapp_common.dtsi
│  │  │  ├── nrf7002dk
│  │  │  │  │ nrf5340_cpuapp_common.dtsi
│  │  │  ├── thingy52
│  │  │  │  │ thingy52_nrf52832.dts
│  │  │  ├── thingy53
│  │  │  │  │ thingy53_nrf5340_common.dtsi
│  ├── cmake
│  │  ├── modules
│  │  │  ├── dts.cmake
│  │  │  │ extensions.cmake
│  ├── drivers
│  │  ├── modem
│  │  │  ├── Kconfig.cellular
│  │  │  │ modem_cellular.c
│  ├── scripts
│  │  ├── dts
│  │  │  │ gen_dts_cmake.py
│  ├── share
│  │  ├── sysbuild
│  │  │  ├── cmake
│  │  │  │  ├── modules
│  │  │  │  │  │ sysbuild_extensions.cmake
│  ├── subsys
│  │  ├── net
│  │  │  ├── l2
│  │  │  │  ├── ppp
│  │  │  │  │  │ ppp_l2.c

Outputs:

Toolchain

Version:
Build docker image:

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain
  • ◻️ Build twister
  • ◻️ Integration tests
    • ◻️ test-sdk-audio
    • ◻️ desktop52_verification
    • ◻️ test-fw-nrfconnect-boot
    • ◻️ test-fw-nrfconnect-apps
    • ◻️ test_ble_nrf_config
    • ◻️ test-fw-nrfconnect-ble_mesh
    • ◻️ test-fw-nrfconnect-ble_samples
    • ◻️ test-fw-nrfconnect-chip
    • ◻️ test-fw-nrfconnect-nfc
    • ◻️ test-fw-nrfconnect-nrf-iot_cloud
    • ◻️ test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • ◻️ test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • ◻️ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • ◻️ test-fw-nrfconnect-nrf-iot_samples
    • ◻️ test-fw-nrfconnect-nrf-iot_lwm2m
    • ◻️ doc-internal
    • ◻️ test-fw-nrfconnect-nrf-iot_thingy91
    • ◻️ test-fw-nrfconnect-nrf_crypto
    • ◻️ test-fw-nrfconnect-proprietary_esb
    • ◻️ test-fw-nrfconnect-rpc
    • ◻️ test-fw-nrfconnect-rs
    • ◻️ test-fw-nrfconnect-fem
    • ◻️ test-fw-nrfconnect-tfm
    • ◻️ test-fw-nrfconnect-thread-main
    • ◻️ test-sdk-find-my
    • ◻️ test-fw-nrfconnect-nrf-iot_mosh
    • ◻️ test-fw-nrfconnect-nrf-iot_positioning
    • ◻️ test-sdk-wifi
    • ◻️ test-low-level
    • ◻️ test-sdk-pmic-samples
    • ◻️ test-sdk-mcuboot
    • ◻️ test-fw-nrfconnect-ps-main
    • ◻️ test-secdom-samples-public
    • ⚠️ test-sdk-dfu

Note: This message is automatically posted and updated by the CI

@57300 57300 force-pushed the sysbuild-dt-migrate branch from 6dbc604 to e827b90 Compare May 23, 2025 15:03
@57300 57300 requested a review from FrancescoSer May 23, 2025 15:03
@57300
Copy link
Contributor Author

57300 commented May 23, 2025

@FrancescoSer I followed your suggestions but changed more words. Please take another look.

@github-actions
Copy link

You can find the documentation preview for this PR here.

Preview links for modified nRF Connect SDK documents:

https://ncsdoc.z6.web.core.windows.net/PR-22462/nrf/releases_and_maturity/migration/migration_guide_3.1.html

@57300 57300 force-pushed the sysbuild-dt-migrate branch from e827b90 to ec44490 Compare May 26, 2025 15:47
@NordicBuilder
Copy link
Contributor

Memory footprint analysis revealed the following potential issues

applications.hpf.gpio.icmsg[nrf54l15dk/nrf54l15/cpuflpr]: High RAM usage: 9090[B] - link (cc: @nrfconnect/ncs-ll-ursus)
applications.hpf.gpio.icmsg[nrf54l15dk/nrf54l15/cpuflpr]: High ROM usage: 5846[B] - link (cc: @nrfconnect/ncs-ll-ursus)
applications.hpf.gpio.icbmsg[nrf54l15dk/nrf54l15/cpuflpr]: High RAM usage: 12430[B] - link (cc: @nrfconnect/ncs-ll-ursus)
applications.hpf.gpio.icbmsg[nrf54l15dk/nrf54l15/cpuflpr]: High ROM usage: 9178[B] - link (cc: @nrfconnect/ncs-ll-ursus)

Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-22462/6)

The `sysbuild_dt_*` CMake API came from upstream Zephyr PR #: 73903.
This had been in review for almost a year, and in the end, the proposed
API ended up being replaced.

This merits an entry in the migration guide. Note that since the API was
cherry-picked from PR, there's no deprecation process.

Signed-off-by: Grzegorz Swiderski <[email protected]>
@57300 57300 force-pushed the sysbuild-dt-migrate branch from ec44490 to 284e7a5 Compare May 27, 2025 06:31
@NordicBuilder NordicBuilder removed the DNM label May 27, 2025
@nordicjm nordicjm merged commit 4b58475 into nrfconnect:main May 27, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. doc-required PR must not be merged without tech writer approval. manifest manifest-matter manifest-zephyr

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants