Skip to content

Conversation

de-nordic
Copy link
Contributor

@de-nordic de-nordic commented May 23, 2025

Two commits:

  • support for FIXED_PARTITION macro that allows to obtain direct pointer to flash_area object representing partition, instead of using flash_area_open with id;
  • Zephyr manifest update with sdk-zephyr changes to flash_map tests, that conditionally disable parts of tests that are not possible to run on Partition Manager enabled build.

You can build the Zephyr flash map test using:

west build --sysbuild -d builds/pm-flash -b nrf52840dk/nrf52840 zephyr/tests/subsys/storage/flash_map/ -DSB_CONFIG_PARTITION_MANAGER=y -DSB_CONFIG_BOOTLOADER_MCUBOOT=y

to get free PM definitions that allow you to run the test on nrf52840.

Depends on:
#22473

@de-nordic de-nordic requested review from a team, nordicjm and tejlmand as code owners May 23, 2025 15:50
@github-actions github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels May 23, 2025
@de-nordic de-nordic force-pushed the pm-flash-map-fixes branch from 7dfef9d to d86be92 Compare May 23, 2025 15:51
@NordicBuilder
Copy link
Contributor

NordicBuilder commented May 23, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented May 23, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 16

Inputs:

Sources:

sdk-nrf: PR head: 0e45d400f4efccc926a2996ae2daed24f84310b6

more details

sdk-nrf:

PR head: 0e45d400f4efccc926a2996ae2daed24f84310b6
merge base: 063432abbc2478f6ab4a7b8908d14453f737fe5e
target head (main): 063432abbc2478f6ab4a7b8908d14453f737fe5e
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (2)
include
│  │ flash_map_pm.h
subsys
│  ├── partition_manager
│  │  │ flash_map_partition_manager.c

Outputs:

Toolchain

Version: 3ae5dc3c63
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:3ae5dc3c63_776d264d2e

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
  • ✅ Integration tests
    • ✅ test-sdk-audio
    • ✅ desktop52_verification
    • ✅ test-fw-nrfconnect-boot
    • ✅ test-fw-nrfconnect-apps
    • ✅ test_ble_nrf_config
    • ✅ test-fw-nrfconnect-ble_mesh
    • ✅ test-fw-nrfconnect-ble_samples
    • ✅ test-fw-nrfconnect-chip
    • ✅ test-fw-nrfconnect-nfc
    • ✅ test-fw-nrfconnect-nrf-iot_cloud
    • ✅ test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • ✅ test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • ✅ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • ✅ test-fw-nrfconnect-nrf-iot_samples
    • ✅ test-fw-nrfconnect-nrf-iot_lwm2m
    • ✅ doc-internal
    • ✅ test-fw-nrfconnect-nrf-iot_thingy91
    • ✅ test-fw-nrfconnect-nrf_crypto
    • ✅ test-fw-nrfconnect-rpc
    • ✅ test-fw-nrfconnect-rs
    • ✅ test-fw-nrfconnect-fem
    • ✅ test-fw-nrfconnect-tfm
    • ✅ test-fw-nrfconnect-thread-main
    • ✅ test-sdk-find-my
    • ✅ test-fw-nrfconnect-nrf_lrcs_mosh
    • ✅ test-fw-nrfconnect-nrf_lrcs_positioning
    • ✅ test-sdk-wifi
    • ✅ test-low-level
    • ✅ test-sdk-pmic-samples
    • ✅ test-sdk-mcuboot
    • ✅ test-fw-nrfconnect-ps-main
    • ✅ test-secdom-samples-public
    • ⚠️ test-fw-nrfconnect-fw-update

Note: This message is automatically posted and updated by the CI

@de-nordic de-nordic force-pushed the pm-flash-map-fixes branch from d86be92 to 5390326 Compare May 23, 2025 15:56
@de-nordic de-nordic requested a review from katgiadla May 23, 2025 16:01
Copy link

You can find the documentation preview for this PR here.

@de-nordic de-nordic force-pushed the pm-flash-map-fixes branch 3 times, most recently from 89d5b33 to 9ea6857 Compare May 27, 2025 14:08
@NordicBuilder
Copy link
Contributor

NordicBuilder commented May 27, 2025

Memory footprint analysis revealed the following potential issues

applications.hpf.gpio.icmsg[nrf54l15dk/nrf54l15/cpuflpr]: High RAM usage: 9090[B] - link (cc: @nrfconnect/ncs-ll-ursus)
applications.hpf.gpio.icmsg[nrf54l15dk/nrf54l15/cpuflpr]: High ROM usage: 5846[B] - link (cc: @nrfconnect/ncs-ll-ursus)
applications.hpf.gpio.icbmsg[nrf54l15dk/nrf54l15/cpuflpr]: High RAM usage: 12430[B] - link (cc: @nrfconnect/ncs-ll-ursus)
applications.hpf.gpio.icbmsg[nrf54l15dk/nrf54l15/cpuflpr]: High ROM usage: 9178[B] - link (cc: @nrfconnect/ncs-ll-ursus)

Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-22496/16)

@de-nordic de-nordic force-pushed the pm-flash-map-fixes branch from 9ea6857 to 3ee99e4 Compare May 28, 2025 08:26
@de-nordic de-nordic changed the title Partition Managre: support for FIXED_PARTITION macros and update of sdk-zephyr with fixed flash-map tests Partition Manager: support for FIXED_PARTITION macros and update of sdk-zephyr with fixed flash-map tests May 28, 2025
@de-nordic de-nordic requested a review from rghaddab May 28, 2025 11:53
@de-nordic de-nordic force-pushed the pm-flash-map-fixes branch from 3ee99e4 to a3151de Compare May 28, 2025 13:06
@de-nordic de-nordic force-pushed the pm-flash-map-fixes branch 3 times, most recently from 8c1d249 to 4efc09b Compare June 6, 2025 12:15
@de-nordic de-nordic force-pushed the pm-flash-map-fixes branch from 4efc09b to bdc1c6f Compare June 17, 2025 19:03
@github-actions github-actions bot removed the manifest label Jun 17, 2025
Upstream Flash Map defines FIXED_PARTITION macro that allows to
obtain direct pointer to flash_area object representing the
partition, and bypass the flash_area_open call.
This PR adds the macro to Partition Manager.

Signed-off-by: Dominik Ermel <[email protected]>
@de-nordic de-nordic force-pushed the pm-flash-map-fixes branch from bdc1c6f to 0e45d40 Compare June 25, 2025 14:33
@de-nordic de-nordic merged commit 5774c60 into nrfconnect:main Jun 26, 2025
14 checks passed
@de-nordic de-nordic deleted the pm-flash-map-fixes branch June 26, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants