Skip to content

Conversation

kapi-no
Copy link
Contributor

@kapi-no kapi-no commented Jun 6, 2025

TODO

@kapi-no kapi-no requested review from a team as code owners June 6, 2025 17:18
@github-actions github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Jun 6, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jun 6, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
nrfxlib nrfconnect/sdk-nrfxlib@9924a5f nrfconnect/sdk-nrfxlib@89a6654 (main) nrfconnect/[email protected]

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jun 6, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 5

Inputs:

Sources:

sdk-nrf: PR head: 553d86e5157667ba06bd498c7a660557b84d0162
nrfxlib: PR head: 89a665471355b21cb2f3577025ee531a470a631f

more details

sdk-nrf:

PR head: 553d86e5157667ba06bd498c7a660557b84d0162
merge base: 93deb64667888db9503788722a98449798411cd3
target head (main): 80cc45b08ab544e5fcbb6047fd296d27580a3f8e
Diff

nrfxlib:

PR head: 89a665471355b21cb2f3577025ee531a470a631f
merge base: 9924a5f82206f0cd31905fd659d7a3621249db79
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (5)
boards
│  ├── nordic
│  │  ├── nrf54lm20pdk
│  │  │  │ nrf54lm20a_cpuapp_common.dtsi
nrfxlib
│  ├── nfc
│  │  │ Kconfig
samples
│  ├── bluetooth
│  │  ├── peripheral_hids_keyboard
│  │  │  ├── app.overlay
│  │  │  ├── boards
│  │  │  │  │ nrf54lv10dk_nrf54lv10a_cpuapp.overlay
west.yml

Outputs:

Toolchain

Version:
Build docker image:

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain
  • ◻️ Build twister
  • ◻️ Integration tests
    • ◻️ test-fw-nrfconnect-ble_samples
    • ◻️ test-fw-nrfconnect-nfc
    • ◻️ test-sdk-find-my
    • ◻️ test-low-level
Disabled integration tests
    • test-fw-nrfconnect-nrf_lrcs_mosh
    • test-fw-nrfconnect-nrf_lrcs_positioning
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread-main
    • test-sdk-audio
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@kapi-no kapi-no force-pushed the bluetooth_peripheral_hids_keyboard_nfct_node_enabled_at_board_level branch from 6b97787 to e53dea4 Compare June 6, 2025 17:24
@github-actions
Copy link

github-actions bot commented Jun 6, 2025

You can find the documentation preview for this PR here.

@kapi-no kapi-no force-pushed the bluetooth_peripheral_hids_keyboard_nfct_node_enabled_at_board_level branch from e53dea4 to 40ad16f Compare June 9, 2025 07:27
@kapi-no kapi-no requested review from a team and kl-cruz as code owners June 9, 2025 07:27
@kapi-no kapi-no requested a review from nordic-piks June 9, 2025 07:27
Copy link
Contributor

@grochu grochu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good update, thanks!

kapi-no added 3 commits June 17, 2025 15:34
Removed the application-level configuration that enables the NFCT node.
The NFCT node is now enabled at the board level for all targets that
support the NFCT peripheral. The previous workaround is not needed
anymore.

Ref: NCSDK-31691

This reverts commit d993161.

Signed-off-by: Kamil Piszczek <[email protected]>
Removed the unnecessary DTS overlay that removes the NFCT node from the
nRF54LV10 DK target.

Signed-off-by: Kamil Piszczek <[email protected]>
Aligned the DTS configuration for the nfct node in the nRF54LM20 PDK
board definition. The configuration is now aligned with its Zephyr
upstream variant.

Signed-off-by: Kamil Piszczek <[email protected]>
@kapi-no kapi-no force-pushed the bluetooth_peripheral_hids_keyboard_nfct_node_enabled_at_board_level branch from 40ad16f to 1b62aff Compare June 17, 2025 13:35
@kapi-no
Copy link
Contributor Author

kapi-no commented Jun 17, 2025

Pure rebase after upmerge. The PR file diff has not changed

@kapi-no kapi-no removed the DNM label Jun 17, 2025
Updated the nrfxlib revision to include the Kconfig improvements for
the NFC T2T and T4T libraries.

Signed-off-by: Kamil Piszczek <[email protected]>
@kapi-no kapi-no force-pushed the bluetooth_peripheral_hids_keyboard_nfct_node_enabled_at_board_level branch from 1b62aff to 553d86e Compare June 17, 2025 18:04
@kapi-no kapi-no merged commit 70c0f66 into nrfconnect:main Jun 17, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. manifest manifest-nrfxlib

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants