-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Nrfx 7821 run samples subsys ipc ipc service icmsg on more targets #23019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Nrfx 7821 run samples subsys ipc ipc service icmsg on more targets #23019
Conversation
|
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: ca2500d690ba6a5b2c46ac9a5d010116cb0bba05 more detailssdk-nrf:
zephyr:
Github labels
List of changed files detected by CI (12)Outputs:ToolchainVersion: 2b2cd9579a Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
8b37fa2 to
0d51959
Compare
4540abc to
1972095
Compare
|
You can find the documentation preview for this PR here. |
|
There are some failures But generally works in CI: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
error if not using sysbuild?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't SysBuild enabled by default for these targets?
Is CONFIG_BOARD_STM32H747I_DISCO also using SysBuild?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
someone can do west build --no-sysbuild and would get a broken image, we don't care about stm32 builds not working
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As stated above, I don't think there is need to improve this sample because this is a temporary solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added check at line 15.
However, I feel this breaks idea of copying samples/tests from upstream to sdk-nrf so it can be executed on target existing only in downstream (54LV10).
With this check, sample is no longer identical with the upstream version.
f8382a7 to
7687978
Compare
7687978 to
271a774
Compare
541e761 to
0a578c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
0a578c8 to
6442615
Compare
Include samples: subsys: ipc: ipc_service: icmsg: Enable sample on nRF54H20 sdk-zephyr: pull/2998/head zephyrproject-rtos: pull/92287/head Signed-off-by: Sebastian Głąb <[email protected]>
6442615 to
ca2500d
Compare
No description provided.