Skip to content

Conversation

nordic-segl
Copy link
Contributor

Fix size of RAM avaiable to vpr_launcher (cpuapp). Hardcoded value of 0x28000 is correct for nRF54L15 only.

Hardcode values for:

  • nRF54L09,
  • nRF54LV10A,
  • nRF54L20,
  • nRF54LM20A,
  • nRF7120.

@nordic-segl nordic-segl requested review from a team, nordicjm and tejlmand as code owners June 27, 2025 12:42
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jun 27, 2025
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jun 27, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 4

Inputs:

Sources:

sdk-nrf: PR head: ceb7c0b3b59fba6056070ec79750c978142be9ee

more details

sdk-nrf:

PR head: ceb7c0b3b59fba6056070ec79750c978142be9ee
merge base: e914cbfc928d2869fd652f8d8a406e6df393e6ad
target head (main): e914cbfc928d2869fd652f8d8a406e6df393e6ad
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (2)
subsys
│  ├── partition_manager
│  │  ├── Kconfig
│  │  │ pm.yml.vpr_launcher

Outputs:

Toolchain

Version: 3ae5dc3c63
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:3ae5dc3c63_776d264d2e

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
  • ✅ Integration tests
    • ✅ test-sdk-audio
    • ✅ desktop52_verification
    • ✅ test-fw-nrfconnect-boot
    • ✅ test-fw-nrfconnect-apps
    • ✅ test_ble_nrf_config
    • ✅ test-fw-nrfconnect-ble_mesh
    • ✅ test-fw-nrfconnect-ble_samples
    • ✅ test-fw-nrfconnect-chip
    • ✅ test-fw-nrfconnect-nfc
    • ✅ test-fw-nrfconnect-nrf-iot_cloud
    • ✅ test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • ✅ test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • ✅ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • ✅ test-fw-nrfconnect-nrf-iot_samples
    • ✅ test-fw-nrfconnect-nrf-iot_lwm2m
    • ✅ doc-internal
    • ✅ test-fw-nrfconnect-nrf-iot_thingy91
    • ✅ test-fw-nrfconnect-nrf_crypto
    • ✅ test-fw-nrfconnect-rpc
    • ✅ test-fw-nrfconnect-rs
    • ✅ test-fw-nrfconnect-fem
    • ✅ test-fw-nrfconnect-tfm
    • ✅ test-fw-nrfconnect-thread-main
    • ✅ test-sdk-find-my
    • ✅ test-fw-nrfconnect-nrf_lrcs_mosh
    • ✅ test-fw-nrfconnect-nrf_lrcs_positioning
    • ✅ test-sdk-wifi
    • ✅ test-low-level
    • ✅ test-sdk-pmic-samples
    • ✅ test-sdk-mcuboot
    • ✅ test-fw-nrfconnect-ps-main
    • ✅ test-secdom-samples-public
    • ⚠️ test-fw-nrfconnect-fw-update

Note: This message is automatically posted and updated by the CI

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0x28000 for L15 is set here https://github.com/nrfconnect/sdk-zephyr/blob/main/snippets/nordic-flpr/soc/nrf54l15_cpuapp.overlay#L17

I don't know what is the correct value for nRF7120.

Fix size of RAM avaiable to vpr_launcher (cpuapp).
Hardcoded value of 0x28000 is correct for nRF54L15 only.

Hardcode values for:
- nRF54L09,
- nRF54LV10A,
- nRF54L20,
- nRF54LM20A,
- nRF7120.

Signed-off-by: Sebastian Głąb <[email protected]>
@nordic-segl nordic-segl force-pushed the NRFX-NONE_Fix-vpr_launcher-RAM-size-for-cpuapp branch from 9a8f943 to ceb7c0b Compare June 27, 2025 12:47
@nordic-segl nordic-segl requested review from a team as code owners June 27, 2025 13:05
@nordic-piks
Copy link
Contributor

Helps at CI (at least one test)

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jun 27, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@nordic-segl
Copy link
Contributor Author

I applied changes to counter_basic_api as described in NRFX-7902 (see commit DNM just for testing).
I'm unable to reproduce the mcause 2 issue.

15:15:20  INFO    - 1/1 [email protected]/nrf54lv10a/cpuflpr nrf.extended.drivers.counter.basic_api  PASSED (device: 1051628602, 22.972s <zephyr>)

@nordic-segl nordic-segl force-pushed the NRFX-NONE_Fix-vpr_launcher-RAM-size-for-cpuapp branch from d33a75d to ceb7c0b Compare June 27, 2025 13:22
@github-actions github-actions bot removed the manifest label Jun 27, 2025
Copy link

You can find the documentation preview for this PR here.

config PM_RAM_SIZE_VPR_LAUNCHER
hex
depends on SOC_NRF54L15_CPUFLPR || SOC_NRF54L09_ENGA_CPUFLPR || SOC_NRF54LV10A_ENGA_CPUFLPR || SOC_NRF54L20_ENGA_CPUFLPR || SOC_NRF54LM20A_ENGA_CPUFLPR || SOC_NRF7120_ENGA_CPUFLPR
default 0x28000 if SOC_NRF54L15_CPUFLPR || SOC_NRF7120_ENGA_CPUFLPR
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those values are redundant, already in DT. I was wondering if you could use something like:

default $(int2hex,$(sub,$(dt_nodelabel_reg_addr_int,cpuflpr_sram),536870912/*0x20000000*/))

We are in flpr Kconfig so cpuapp_sram cannot be used. Note that currently there is no int2hex function available but i've tried to add it and it is quite easy.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's already in upstream: zephyrproject-rtos/zephyr#91552

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, I get build error.

Traceback (most recent call last):
  File "/home/segl/workspace/ncs/zephyr/scripts/kconfig/kconfiglib.py", line 2786, in _expand_macro
    res += args[int(new_args[0])]
                ^^^^^^^^^^^^^^^^
ValueError: invalid literal for int() with base 10: 'sub'

Let's use hardcoded values for now and improve it later.

@NordicBuilder
Copy link
Contributor

Memory footprint analysis revealed the following potential issues

applications.hpf.gpio.icbmsg[nrf54l15dk/nrf54l15/cpuflpr]: High RAM usage: 12430[B] - link (cc: @nrfconnect/ncs-ll-ursus)
applications.hpf.gpio.icbmsg[nrf54l15dk/nrf54l15/cpuflpr]: High ROM usage: 9178[B] - link (cc: @nrfconnect/ncs-ll-ursus)
applications.hpf.gpio.icmsg[nrf54l15dk/nrf54l15/cpuflpr]: High RAM usage: 9090[B] - link (cc: @nrfconnect/ncs-ll-ursus)
applications.hpf.gpio.icmsg[nrf54l15dk/nrf54l15/cpuflpr]: High ROM usage: 5846[B] - link (cc: @nrfconnect/ncs-ll-ursus)

Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-23026/4)

@nordic-piks nordic-piks merged commit a96ee0f into nrfconnect:main Jun 30, 2025
22 of 25 checks passed
@nordic-segl nordic-segl deleted the NRFX-NONE_Fix-vpr_launcher-RAM-size-for-cpuapp branch June 30, 2025 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants