-
Notifications
You must be signed in to change notification settings - Fork 1.4k
subsys: partition_manager: Fix RAM size for vpr_launcher #23026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
subsys: partition_manager: Fix RAM size for vpr_launcher #23026
Conversation
subsys/partition_manager/Kconfig
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
subsys/partition_manager/Kconfig
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
subsys/partition_manager/Kconfig
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
subsys/partition_manager/Kconfig
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: ceb7c0b3b59fba6056070ec79750c978142be9ee more detailssdk-nrf:
Github labels
List of changed files detected by CI (2)
Outputs:ToolchainVersion: 3ae5dc3c63 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
subsys/partition_manager/Kconfig
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0x28000 for L15 is set here https://github.com/nrfconnect/sdk-zephyr/blob/main/snippets/nordic-flpr/soc/nrf54l15_cpuapp.overlay#L17
I don't know what is the correct value for nRF7120.
Fix size of RAM avaiable to vpr_launcher (cpuapp). Hardcoded value of 0x28000 is correct for nRF54L15 only. Hardcode values for: - nRF54L09, - nRF54LV10A, - nRF54L20, - nRF54LM20A, - nRF7120. Signed-off-by: Sebastian Głąb <[email protected]>
9a8f943
to
ceb7c0b
Compare
Helps at CI (at least one test) |
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
I applied changes to
|
d33a75d
to
ceb7c0b
Compare
You can find the documentation preview for this PR here. |
config PM_RAM_SIZE_VPR_LAUNCHER | ||
hex | ||
depends on SOC_NRF54L15_CPUFLPR || SOC_NRF54L09_ENGA_CPUFLPR || SOC_NRF54LV10A_ENGA_CPUFLPR || SOC_NRF54L20_ENGA_CPUFLPR || SOC_NRF54LM20A_ENGA_CPUFLPR || SOC_NRF7120_ENGA_CPUFLPR | ||
default 0x28000 if SOC_NRF54L15_CPUFLPR || SOC_NRF7120_ENGA_CPUFLPR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those values are redundant, already in DT. I was wondering if you could use something like:
default $(int2hex,$(sub,$(dt_nodelabel_reg_addr_int,cpuflpr_sram),536870912/*0x20000000*/))
We are in flpr Kconfig so cpuapp_sram
cannot be used. Note that currently there is no int2hex
function available but i've tried to add it and it is quite easy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's already in upstream: zephyrproject-rtos/zephyr#91552
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, I get build error.
Traceback (most recent call last):
File "/home/segl/workspace/ncs/zephyr/scripts/kconfig/kconfiglib.py", line 2786, in _expand_macro
res += args[int(new_args[0])]
^^^^^^^^^^^^^^^^
ValueError: invalid literal for int() with base 10: 'sub'
Let's use hardcoded values for now and improve it later.
Memory footprint analysis revealed the following potential issuesapplications.hpf.gpio.icbmsg[nrf54l15dk/nrf54l15/cpuflpr]: High RAM usage: 12430[B] - link (cc: @nrfconnect/ncs-ll-ursus) Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-23026/4) |
Fix size of RAM avaiable to vpr_launcher (cpuapp). Hardcoded value of 0x28000 is correct for nRF54L15 only.
Hardcode values for: