- 
                Notifications
    
You must be signed in to change notification settings  - Fork 1.4k
 
applications: nrf_desktop: add support for the nRF54LM20 DK #23265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
applications: nrf_desktop: add support for the nRF54LM20 DK #23265
Conversation
          CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 762e74e894f6257f99e4bb766f01cb14f4f3a202 more detailssdk-nrf: 
 Github labels
 List of changed files detected by CI (25)Outputs:ToolchainVersion: Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; 
 | 
    
5ffcd69    to
    83a60c4      
    Compare
  
    | 
           You can find the documentation preview for this PR here.  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why locating DTS overlays in the boards subdirectory? We no longer need separate DTS overlays per board revision, so we can already move the DTS overlays one directory up (for consistency with other supported boards). It's also no longer needed to repeat board name in file names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
	 * The configuration needs to match the used board revision. -> no longer needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This statement is also present in the nrf54l05/10/15 targets. I can delete it, as DTS definitions typically need to match the board revision, and this sentence seems to state the obvious.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed
83a60c4    to
    8e9524d      
    Compare
  
    
          Memory footprint analysis revealed the following potential issuesapplications.nrf_desktop.zdebug.usb_next[nrf52840dk/nrf52840]: ROM size  increased by 1880[B] in comparison to the main[db745e9] branch. - link (cc: @nrfconnect/ncs-si-bluebagel) Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-23265/3)  | 
    
Added initial support for the nRF54LM20 DK in the nRF Desktop application. The new target has been tested with nRF54LM20 DK v0.3.0. The DK target will eventually supersede the PDK target. For now, both targets are maintained in the nRF Desktop application. Ref: NCSDK-33956 Signed-off-by: Kamil Piszczek <[email protected]>
8e9524d    to
    762e74e      
    Compare
  
    | 
           The last force push is a pure rebase operation to include the fix for the MCUboot bootloader for the nRF54LM20 DK.  | 
    
Issues to resolve:
The fix depends on the following PR: manifest: sdk-zephyr: [nrf noup] boards: nordic: nrf54lm20 adjust ROM_START_OFFSET #23285