Skip to content

Conversation

@kapi-no
Copy link
Contributor

@kapi-no kapi-no commented Jul 11, 2025

Issues to resolve:

@kapi-no kapi-no requested a review from a team as a code owner July 11, 2025 10:19
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jul 11, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jul 11, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 4

Inputs:

Sources:

sdk-nrf: PR head: 762e74e894f6257f99e4bb766f01cb14f4f3a202

more details

sdk-nrf:

PR head: 762e74e894f6257f99e4bb766f01cb14f4f3a202
merge base: 2ad751afa927550a5c93c10110fc427b7ffe442d
target head (main): 2ad751afa927550a5c93c10110fc427b7ffe442d
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (25)
applications
│  ├── nrf_desktop
│  │  ├── configuration
│  │  │  ├── nrf54lm20dk_nrf54lm20a_cpuapp
│  │  │  │  ├── app.overlay
│  │  │  │  ├── app_common.dtsi
│  │  │  │  ├── app_llvm.overlay
│  │  │  │  ├── app_release.overlay
│  │  │  │  ├── buttons_def.h
│  │  │  │  ├── click_detector_def.h
│  │  │  │  ├── hid_keyboard_leds_def.h
│  │  │  │  ├── hid_keymap_def.h
│  │  │  │  ├── images
│  │  │  │  │  ├── mcuboot
│  │  │  │  │  │  ├── app.overlay
│  │  │  │  │  │  ├── mcuboot_private.pem
│  │  │  │  │  │  ├── prj.conf
│  │  │  │  │  │  ├── prj_llvm.conf
│  │  │  │  │  │  │ prj_release.conf
│  │  │  │  ├── led_state_def.h
│  │  │  │  ├── pm_static.yml
│  │  │  │  ├── pm_static_llvm.yml
│  │  │  │  ├── pm_static_release.yml
│  │  │  │  ├── port_state_def.h
│  │  │  │  ├── prj.conf
│  │  │  │  ├── prj_llvm.conf
│  │  │  │  ├── prj_release.conf
│  │  │  │  ├── sysbuild.conf
│  │  │  │  ├── sysbuild_llvm.conf
│  │  │  │  │ sysbuild_release.conf
│  │  │ sample.yaml

Outputs:

Toolchain

Version:
Build docker image:

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain
  • ◻️ Build twister
  • ◻️ Integration tests
    • ◻️ desktop52_verification
Disabled integration tests
    • test-fw-nrfconnect-nrf_lrcs_mosh
    • test-fw-nrfconnect-nrf_lrcs_positioning
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread-main
    • test-low-level
    • test-sdk-audio
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@kapi-no kapi-no force-pushed the nrf_desktop_nrf54lm20dk_transition branch from 5ffcd69 to 83a60c4 Compare July 11, 2025 10:32
@github-actions
Copy link

You can find the documentation preview for this PR here.

@kapi-no kapi-no added the DNM label Jul 11, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why locating DTS overlays in the boards subdirectory? We no longer need separate DTS overlays per board revision, so we can already move the DTS overlays one directory up (for consistency with other supported boards). It's also no longer needed to repeat board name in file names.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

* The configuration needs to match the used board revision. -> no longer needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This statement is also present in the nrf54l05/10/15 targets. I can delete it, as DTS definitions typically need to match the board revision, and this sentence seems to state the obvious.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed

@kapi-no kapi-no force-pushed the nrf_desktop_nrf54lm20dk_transition branch from 83a60c4 to 8e9524d Compare July 14, 2025 08:41
@NordicBuilder
Copy link
Contributor

Memory footprint analysis revealed the following potential issues

applications.nrf_desktop.zdebug.usb_next[nrf52840dk/nrf52840]: ROM size increased by 1880[B] in comparison to the main[db745e9] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug.usb_next[nrf52840dongle/nrf52840]: ROM size increased by 1840[B] in comparison to the main[db745e9] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug.usb_next[nrf52840gmouse/nrf52840]: ROM size increased by 1880[B] in comparison to the main[db745e9] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug[nrf52833dk/nrf52833]: ROM size increased by 1840[B] in comparison to the main[db745e9] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug[nrf52833dongle/nrf52833]: ROM size increased by 1840[B] in comparison to the main[db745e9] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug[nrf52840dk/nrf52840]: ROM size increased by 1880[B] in comparison to the main[db745e9] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug[nrf52840dongle/nrf52840]: ROM size increased by 1840[B] in comparison to the main[db745e9] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug[nrf52840gmouse/nrf52840]: ROM size increased by 1872[B] in comparison to the main[db745e9] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug[nrf52dmouse/nrf52832]: ROM size increased by 1396[B] in comparison to the main[db745e9] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug[nrf52kbd/nrf52832]: ROM size increased by 1888[B] in comparison to the main[db745e9] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug[nrf54l15dk/nrf54l05/cpuapp]: ROM size increased by 516[B] in comparison to the main[db745e9] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug_4llpmconn[nrf52840dongle/nrf52840]: ROM size increased by 1840[B] in comparison to the main[db745e9] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug_dongle.usb_next[nrf52840dk/nrf52840]: ROM size increased by 1840[B] in comparison to the main[db745e9] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug_dongle[nrf52840dk/nrf52840]: ROM size increased by 1840[B] in comparison to the main[db745e9] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug_fast_pair.gmouse[nrf52840gmouse/nrf52840]: ROM size increased by 1888[B] in comparison to the main[db745e9] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug_keyboard.usb_next[nrf52840dk/nrf52840]: ROM size increased by 1880[B] in comparison to the main[db745e9] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug_keyboard[nrf52840dk/nrf52840]: ROM size increased by 1872[B] in comparison to the main[db745e9] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug_mcuboot_qspi[nrf52840dk/nrf52840]: ROM size increased by 1880[B] in comparison to the main[db745e9] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug_mcuboot_smp[nrf52840dk/nrf52840]: ROM size increased by 1872[B] in comparison to the main[db745e9] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug_nrf21540ek[nrf52840dk/nrf52840]: ROM size increased by 1872[B] in comparison to the main[db745e9] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug_wwcb[nrf52840dk/nrf52840]: ROM size increased by 1880[B] in comparison to the main[db745e9] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebugwithshell[nrf52840dk/nrf52840]: ROM size increased by 1880[B] in comparison to the main[db745e9] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zrelease.usb_next[nrf52840dk/nrf52840]: ROM size increased by 1872[B] in comparison to the main[db745e9] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zrelease[nrf52840dongle/nrf52840]: ROM size increased by 1840[B] in comparison to the main[db745e9] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zrelease[nrf52840gmouse/nrf52840]: ROM size increased by 1872[B] in comparison to the main[db745e9] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zrelease[nrf52kbd/nrf52832]: ROM size increased by 1880[B] in comparison to the main[db745e9] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zrelease_fast_pair.keyboard[nrf52kbd/nrf52832]: ROM size increased by 1872[B] in comparison to the main[db745e9] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zrelease_keyboard[nrf54l15dk/nrf54l05/cpuapp]: ROM size increased by 512[B] in comparison to the main[db745e9] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)

Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-23265/3)

Added initial support for the nRF54LM20 DK in the nRF Desktop
application. The new target has been tested with nRF54LM20 DK v0.3.0.

The DK target will eventually supersede the PDK target. For now, both
targets are maintained in the nRF Desktop application.

Ref: NCSDK-33956

Signed-off-by: Kamil Piszczek <[email protected]>
@kapi-no kapi-no force-pushed the nrf_desktop_nrf54lm20dk_transition branch from 8e9524d to 762e74e Compare July 14, 2025 12:08
@kapi-no
Copy link
Contributor Author

kapi-no commented Jul 14, 2025

The last force push is a pure rebase operation to include the fix for the MCUboot bootloader for the nRF54LM20 DK.

@kapi-no kapi-no removed the DNM label Jul 14, 2025
@kapi-no kapi-no merged commit e6286fd into nrfconnect:main Jul 14, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants