Skip to content

nRF Desktop: NVM layout fix for the nRF54L10 board target #23490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 30, 2025
Merged

nRF Desktop: NVM layout fix for the nRF54L10 board target #23490

merged 2 commits into from
Jul 30, 2025

Conversation

@kapi-no
Copy link
Contributor

@kapi-no kapi-no commented Jul 28, 2025

No description provided.

@kapi-no kapi-no requested review from a team as code owners July 28, 2025 13:14
@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label Jul 28, 2025
@kapi-no
Copy link
Contributor Author

kapi-no commented Jul 28, 2025

Requires the following PR to be merged:

#23473

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jul 28, 2025 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 3

Inputs:

Sources:

sdk-nrf: PR head: f1610cb1f0ed30f2c9f25773592397b3b27cb4eb

more details

sdk-nrf:

PR head: f1610cb1f0ed30f2c9f25773592397b3b27cb4eb
merge base: 465de1b4a646fda5ed151d52fa71a9a4fc088efe
target head (main): 465de1b4a646fda5ed151d52fa71a9a4fc088efe
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (7) 
applications
│  ├── nrf_desktop
│  │  ├── configuration
│  │  │  ├── nrf54l15dk_nrf54l10_cpuapp
│  │  │  │  ├── app_common.dtsi
│  │  │  │  ├── images
│  │  │  │  │  ├── mcuboot
│  │  │  │  │  │  │ app.overlay
│  │  │  │  ├── pm_static.yml
│  │  │  │  ├── pm_static_fast_pair.yml
│  │  │  │  ├── pm_static_keyboard.yml
│  │  │  │  │ pm_static_release.yml
doc
│  ├── nrf
│  │  ├── releases_and_maturity
│  │  │  ├── releases
│  │  │  │  │ release-notes-changelog.rst

Outputs:

Toolchain

Version: 8ea1732c3a
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:8ea1732c3a_bba2ea5f2e

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 47
  • ✅ Integration tests
    • ✅ desktop52_verification
Disabled integration tests
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread-main
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

zycz
zycz reviewed Jul 28, 2025
View reviewed changes
applications/nrf_desktop/configuration/nrf54l15dk_nrf54l10_cpuapp/app_common.dtsi Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In commit message:

The NVM size
in the nRF54L15 SoC is equal to 1012 KB.

Shouldn't it be The NVM size
in the nRF54L10 SoC is equal to 1012 KB.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also for changelog entry

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also write known issue here for our applications or will it be in other PRs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will create known issues once the fix PRs are merged (for other projects as well).

@github-actions
Copy link

You can find the documentation preview for this PR here.

Preview links for modified nRF Connect SDK documents:

https://ncsdoc.z6.web.core.windows.net/PR-23490/nrf/releases_and_maturity/releases/release-notes-changelog.html

@kapi-no kapi-no force-pushed the nrf_desktop_nrf54l10_memory_map_align branch from 4776039 to c91e59c Compare July 29, 2025 12:42
@kapi-no kapi-no requested a review from zycz July 29, 2025 12:43
@kapi-no
Copy link
Contributor Author

kapi-no commented Jul 29, 2025

Rebase required to include the fix for MPSL build error:

#23517

kapi-no added 2 commits July 29, 2025 17:03
@kapi-no
applications: nrf_desktop: fix memory map for nRF54L10
7e027e6 
Fixed the memory layout for the nrf54l15dk/nrf54l10/cpuapp target
in the nRF Desktop application. Previously, it was assumed that
the memory size was 10 KB larger than the actual one. The NVM size
in the nRF54L10 SoC is equal to 1012 KB.

This change in the nRF54L10 partition map is a breaking change and
cannot be performed using DFU. As a result, the DFU procedure will
fail if you attempt to upgrade the sample firmware based on one of
the nRF Connect SDK v3.0 releases.

Ref: NCSDK-34584

Signed-off-by: Kamil Piszczek <[email protected]>
@kapi-no
doc: changelog: nrf_desktop: mention memory map update for nRF54L10
f1610cb 
Added a changelog entry for the nRF Desktop application that describes
the update of the memory map for the nrf54l15dk/nrf54l10/cpuapp
board target.

Ref: NCSDK-34584

Signed-off-by: Kamil Piszczek <[email protected]>
@kapi-no kapi-no force-pushed the nrf_desktop_nrf54l10_memory_map_align branch from c91e59c to f1610cb Compare July 29, 2025 15:03
@kapi-no kapi-no merged commit 193b87a into nrfconnect:main Jul 30, 2025
14 checks passed
@kapi-no kapi-no mentioned this pull request Jul 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zycz zycz zycz approved these changes

@divipillai divipillai divipillai approved these changes

Assignees

No one assigned

Labels

doc-required PR must not be merged without tech writer approval.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kapi-no @NordicBuilder @zycz @divipillai