Skip to content

Conversation

@rado17
Copy link
Contributor

@rado17 rado17 commented Jul 30, 2025

Add support to configure enterprise mode security and upload corresponding certificates.

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jul 30, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jul 30, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 26

Inputs:

Sources:

sdk-nrf: PR head: 2de5ed99c0d509458feed412bc2509f660733300

more details

sdk-nrf:

PR head: 2de5ed99c0d509458feed412bc2509f660733300
merge base: 4f748a65eba2b160f6a96d26ef3f5503dc145345
target head (main): 37951f482066ab6a2640453851030a589d55fea0
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (41)
CODEOWNERS
doc
│  ├── _utils
│  │  │ redirects.py
│  ├── nrf
│  │  ├── libraries
│  │  │  ├── bluetooth
│  │  │  │  ├── services
│  │  │  │  │  │ wifi_prov_ble.rst
│  │  │  ├── networking
│  │  │  │  ├── wifi_prov_core.rst
│  │  │  │  │ wifi_prov_tools.rst
include
│  ├── bluetooth
│  │  ├── services
│  │  │  │ wifi_provisioning.h
│  ├── net
│  │  ├── wifi_prov_core
│  │  │  │ wifi_prov_core.h
samples
│  ├── wifi
│  │  ├── provisioning
│  │  │  ├── ble
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── README.rst
│  │  │  │  ├── prj.conf
│  │  │  │  ├── src
│  │  │  │  │  │ main.c
│  │  │  ├── internal
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── Kconfig
│  │  │  │  ├── README.rst
│  │  │  │  ├── prj.conf
│  │  │  │  ├── sample.yaml
│  │  │  │  ├── src
│  │  │  │  │  ├── main.c
│  │  │  │  │  ├── prov.c
│  │  │  │  │  │ wifi_prov_transport_stub.c
│  │  │  │  │ sysbuild.conf
subsys
│  ├── bluetooth
│  │  ├── services
│  │  │  ├── wifi_prov
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── proto
│  │  │  │  │  │ request.options
│  │  │  │  ├── wifi_prov_ble.c
│  │  │  │  │ wifi_prov_internal.h
│  ├── net
│  │  ├── lib
│  │  │  ├── CMakeLists.txt
│  │  │  ├── Kconfig
│  │  │  ├── wifi_prov_core
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── Kconfig
│  │  │  │  ├── proto
│  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  ├── common.options
│  │  │  │  │  ├── common.proto
│  │  │  │  │  ├── generate_wifi_prov_config.py
│  │  │  │  │  ├── request.options
│  │  │  │  │  ├── request.proto
│  │  │  │  │  ├── response.options
│  │  │  │  │  ├── response.proto
│  │  │  │  │  ├── result.proto
│  │  │  │  │  ├── test_auth_modes.py
│  │  │  │  │  ├── version.options
│  │  │  │  │  │ version.proto
│  │  │  │  │ wifi_prov_handler.c

Outputs:

Toolchain

Version: c5be9c56c7
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:c5be9c56c7_bba2ea5f2e

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister - Skipped: Skipping Build & Test as it succeeded in a previous run: 25
  • ✅ Integration tests
    • ✅ desktop52_verification - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test_ble_nrf_config - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-ble_samples - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-find-my
    • ✅ test-sdk-wifi - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-mcuboot - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-dfu - Skipped: Job was skipped as it succeeded in a previous run
Disabled integration tests
    • test-fw-nrfconnect-nrf_lrcs_mosh
    • test-fw-nrfconnect-nrf_lrcs_positioning
    • doc-internal
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread-main
    • test-low-level
    • test-sdk-audio
    • test-sdk-pmic-samples
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@sachinthegreen sachinthegreen added this to the 3.1.0 milestone Jul 30, 2025
@rado17 rado17 force-pushed the ble_prov_ent branch 2 times, most recently from c5f4f4d to 8a46f1a Compare July 30, 2025 17:55
@rado17 rado17 requested review from a team as code owners July 31, 2025 18:49
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Jul 31, 2025
@krish2718 krish2718 force-pushed the ble_prov_ent branch 2 times, most recently from ae91c9a to 1167c22 Compare July 31, 2025 21:25
@krish2718
Copy link
Contributor

FYI, SonarQube fail can be ignored as it complains about a passphrase in a test code.

Copy link
Contributor

@richabp richabp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Managed to review only one sample. More to follow. Please follow the syntax to resolve the doc build errors.

Copy link
Contributor

@divipillai divipillai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed wifi_prov_ble lib. Will review other docs in some time.

Copy link
Contributor

@wentong-li wentong-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krish2718 krish2718 force-pushed the ble_prov_ent branch 2 times, most recently from ef7c237 to 488fd4c Compare August 4, 2025 07:17
@krish2718
Copy link
Contributor

Ping.

@nrfconnect/ncs-co-build-system
@nrfconnect/ncs-co-networking
@nrfconnect/ncs-dragoon
@nrfconnect/ncs-code-owners

Copy link
Contributor

@tejlmand tejlmand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please re-write makefiles into something else, or integrate it into the existing CMake build system if the makes more sense.

We cannot expect users to have make installed.

Also, tools / pip packages required should be ensured to be part of the requirements.txt files / ncs toolchains so that they are automatically installed when users follows the normal getting started guide.

rado17 and others added 3 commits August 5, 2025 18:26
Add support to configure enterprise mode security and upload
corresponding certificates.

Signed-off-by: Ravi Dondaputi <[email protected]>
It's easier to use same enumerations across, but we aalso use the
existing ones to not break compatibility.

Signed-off-by: Chaitanya Tata <[email protected]>
To make it easier to send the encoded string for testing add tools:

* Makefile - to generate proto definitions in python
* Python script - to generate JSON and binary string
* Doc - to explain the usage

Signed-off-by: Chaitanya Tata <[email protected]>
Copy link
Contributor

@tejlmand tejlmand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still a 2024 copyright, but no blockers.

We now have a new application for this library which will be used with
no transport, so, move the the core provisioning stuff to a new library
that can be used by BLE or no transport.

Signed-off-by: Chaitanya Tata <[email protected]>
This is handy to test the core part of provisioning without worrying
about BLE or SAP, this doesn't need any external dependencies, but still
uses protbuf as the configuration mechanism, relies on Wi-Fi
provisioning core library.

Signed-off-by: Chaitanya Tata <[email protected]>
@rlubos
Copy link
Contributor

rlubos commented Aug 5, 2025

Find-my passed on rerun: https://jenkins-ncs.nordicsemi.no/job/latest/job/sub/job/test-sdk-find-my/job/master/18642/

@rlubos rlubos merged commit d2bf23e into nrfconnect:main Aug 5, 2025
14 of 15 checks passed
@krish2718 krish2718 deleted the ble_prov_ent branch August 5, 2025 17:34
@richabp richabp mentioned this pull request Aug 11, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport v3.1-branch doc-required PR must not be merged without tech writer approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.