-
Notifications
You must be signed in to change notification settings - Fork 1.4k
samples: wifi: provisioning: Add enterprise security support #23552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 2de5ed99c0d509458feed412bc2509f660733300 more detailssdk-nrf:
Github labels
List of changed files detected by CI (41)Outputs:ToolchainVersion: c5be9c56c7 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
c5f4f4d to
8a46f1a
Compare
ae91c9a to
1167c22
Compare
|
FYI, SonarQube fail can be ignored as it complains about a passphrase in a test code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Managed to review only one sample. More to follow. Please follow the syntax to resolve the doc build errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed wifi_prov_ble lib. Will review other docs in some time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ef7c237 to
488fd4c
Compare
|
Ping. @nrfconnect/ncs-co-build-system |
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please re-write makefiles into something else, or integrate it into the existing CMake build system if the makes more sense.
We cannot expect users to have make installed.
Also, tools / pip packages required should be ensured to be part of the requirements.txt files / ncs toolchains so that they are automatically installed when users follows the normal getting started guide.
subsys/bluetooth/services/wifi_prov/proto/generate_wifi_prov_config.py
Outdated
Show resolved
Hide resolved
Add support to configure enterprise mode security and upload corresponding certificates. Signed-off-by: Ravi Dondaputi <[email protected]>
It's easier to use same enumerations across, but we aalso use the existing ones to not break compatibility. Signed-off-by: Chaitanya Tata <[email protected]>
To make it easier to send the encoded string for testing add tools: * Makefile - to generate proto definitions in python * Python script - to generate JSON and binary string * Doc - to explain the usage Signed-off-by: Chaitanya Tata <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still a 2024 copyright, but no blockers.
We now have a new application for this library which will be used with no transport, so, move the the core provisioning stuff to a new library that can be used by BLE or no transport. Signed-off-by: Chaitanya Tata <[email protected]>
This is handy to test the core part of provisioning without worrying about BLE or SAP, this doesn't need any external dependencies, but still uses protbuf as the configuration mechanism, relies on Wi-Fi provisioning core library. Signed-off-by: Chaitanya Tata <[email protected]>
|
Find-my passed on rerun: https://jenkins-ncs.nordicsemi.no/job/latest/job/sub/job/test-sdk-find-my/job/master/18642/ |
Add support to configure enterprise mode security and upload corresponding certificates.