-
Notifications
You must be signed in to change notification settings - Fork 1.4k
emds: next emds version #23602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
emds: next emds version #23602
Conversation
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 37244c2788f90b02e121ae6b1ee65b8a7d0036d6 more detailssdk-nrf:
Github labels
List of changed files detected by CI (14)Outputs:ToolchainVersion: 11ad62c2a5 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
738510e to
610b95f
Compare
|
You can find the documentation preview for this PR here. Preview links for modified nRF Connect SDK documents: https://ncsdoc.z6.web.core.windows.net/PR-23602/nrf/libraries/others/emds.html |
94f9251 to
2f6b762
Compare
2f6b762 to
70744ab
Compare
253244f to
b690f8d
Compare
b690f8d to
d150947
Compare
|
I removed support |
Memory footprint analysis revealed the following potential issuesapplications.hpf.gpio.icmsg[nrf54l15dk/nrf54l15/cpuflpr]: High RAM usage: 9090[B] - link (cc: @nrfconnect/ncs-ll-ursus) Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-23602/11) |
|
@nordicjm, please review it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a gcc extension and should not be used, use a memset instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is recommendation (p17 - advisory): https://docs.zephyrproject.org/latest/contribute/coding_guidelines/index.html#coding-guidelines
In general this is not prohibited and used in many places.
in Zephyr public API for example:
https://github.com/zephyrproject-rtos/zephyr/blob/main/include/zephyr/net/net_if.h#L3454
https://github.com/zephyrproject-rtos/zephyr/blob/main/include/zephyr/net/net_if.h#L3480
and here
https://github.com/zephyrproject-rtos/zephyr/blob/main/include/zephyr/net/socket_service.h#L102
and in just implementation
https://github.com/zephyrproject-rtos/zephyr/blob/main/subsys/bluetooth/mesh/adv_ext.c#L105
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as seems to be usable from clang
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this change is for the 3.1.0 release, please remove these changelog entries from this PR and add a comment on PR #23631 after this PR is merged.
Also, add the backport label.
|
Hi @Balaklaka and @PaalKastnes, seems this PR wasn't merged before RC 3.1.0 has been created. FYI @shanthanordic |
d150947 to
00740fd
Compare
00740fd to
59dbc5b
Compare
Commit: - adds next emds implementation - adapts emds api test to the new emds - adapts emds flash test to the new emds - adapts ble mesh light_ctrl sample to the new emds Signed-off-by: Aleksandr Khromykh <[email protected]> Signed-off-by: Stine Åkredalen <[email protected]>
Commit removes experimental tag. Signed-off-by: Aleksandr Khromykh <[email protected]>
Commit adapts emds documentation to the new emds. Signed-off-by: Aleksandr Khromykh <[email protected]>
59dbc5b to
37244c2
Compare
This PR replaces the legacy, single-partition EMDS with a production-ready, dual-partition snapshot scheme.
Robustness fixes:
Other updates: