-
Notifications
You must be signed in to change notification settings - Fork 1.4k
manifest: sdk-zephyr: Cherry pick remove pm device runtime auto #23607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
manifest: sdk-zephyr: Cherry pick remove pm device runtime auto #23607
Conversation
|
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 7b5eee4c659cd276ddef0d7a1647803f426312c7 more detailssdk-nrf:
zephyr:
Github labels
List of changed files detected by CI (71)Outputs:ToolchainVersion: 8ea1732c3a Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
|
You can find the documentation preview for this PR here. Preview links for modified nRF Connect SDK documents: https://ncsdoc.z6.web.core.windows.net/PR-23607/nrf/drivers/mspi_sqspi.html |
Automatically created by Github Action Signed-off-by: Nordic Builder <[email protected]>
All devices now automatically have PM_DEVICE_RUNTIME enabled if CONFIG_PM_DEVICE_RUNTIME is enabled. Signed-off-by: Bjarki Arge Andreasen <[email protected]>
Devices now unconditionally have PM_DEVICE_RUNTIME enabled if CONFIG_PM_DEVICE_RUNTIME is enabled, thus the previously widely applied prop zephyr,pm-device-runtime-auto devicetree property is now redundant. Signed-off-by: Bjarki Arge Andreasen <[email protected]>
Refactor benchmarks.current_consumption.twim_suspend to use pm device runtime for power management. Signed-off-by: Bjarki Arge Andreasen <[email protected]>
Refactor applications.connectivity_bridge to use pm device runtime. Signed-off-by: Bjarki Arge Andreasen <[email protected]>
Refactor nrf_desktop to use pm device runtime. Signed-off-by: Bjarki Arge Andreasen <[email protected]>
Refactor serial_lte_modem to use pm_device_runtime. Signed-off-by: Bjarki Arge Andreasen <[email protected]>
8d5b0ab to
7b5eee4
Compare
| }; | ||
| }; | ||
|
|
||
| &uart20 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whole &uart20 to be removed? similar for other where empty definition statys
| if (src == MODEM_FD_IDX) { | ||
| pm_device_state_get(ppp_uart_dev, &state); | ||
| if (state != PM_DEVICE_STATE_ACTIVE) { | ||
| if (!slm_uart_dev_is_active()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is a different UART in some use cases, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. In this case we should be checking ppp_uart_dev, which is either ncs_slm_uart or ncs_slm_ppp_uart.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That said, we are missing putting the second UART to sleep, for which there is a Jira ticket. I think that it might be reasonable to remove the changes in this file and we could implement those later.
| if (src == MODEM_FD_IDX) { | ||
| pm_device_state_get(ppp_uart_dev, &state); | ||
| if (state != PM_DEVICE_STATE_ACTIVE) { | ||
| if (!slm_uart_dev_is_active()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That said, we are missing putting the second UART to sleep, for which there is a Jira ticket. I think that it might be reasonable to remove the changes in this file and we could implement those later.
| if (active) { | ||
| err = pm_device_runtime_get(slm_uart_dev); | ||
| } else { | ||
| err = pm_device_runtime_put(slm_uart_dev); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: Test power consumption with AT#XSLEEP=2 after this change.
|
rebase needed |
| if (state != STATE_DISABLED) { | ||
| err = pm_device_action_run(qdec_dev, PM_DEVICE_ACTION_RESUME); | ||
| /* QDEC device driver starts in PM_DEVICE_STATE_SUSPENDED state. */ | ||
| if (state == STATE_DISABLED) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the check here should be removed. Now we should always call pm_device_runtime_get here (also after we return from the suspended state), right?
Automatically created by action-manifest-pr GH action from PR: nrfconnect/sdk-zephyr#3121