-
Notifications
You must be signed in to change notification settings - Fork 1.4k
samples: cellular: slm_shell: Add nRF54L15 support #24010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Move power and indicate pins from Kconfig to devicetree. Jira: LRCS-114 Signed-off-by: Tommi Rantanen <[email protected]>
Move power and indicate pins from Kconfig to devicetree. Jira: LRCS-114 Signed-off-by: Tommi Rantanen <[email protected]>
Move power and indicate pins from Kconfig to devicetree. Jira: LRCS-114 Signed-off-by: Tommi Rantanen <[email protected]>
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:more detailsGithub labels
List of changed files detected by CI (0)
Outputs:ToolchainVersion: Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
You can find the documentation preview for this PR here. |
ncs,slm-gpio = &gpio0; | ||
zephyr,console = &uart30; | ||
zephyr,shell-uart = &uart30; | ||
zephyr,uart-mcumgr = &uart30; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the point of all of these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make the shell work. Default is uart20 which I'm using for slm-uart. See #24010 (comment) although I haven't been able to make it work yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems, I only need these to make it work:
zephyr,console = &uart30;
zephyr,shell-uart = &uart30;
I guess the rest of the items are not used so can be left out and moved to non-slm UART if used:
zephyr,uart-mcumgr
, zephyr,bt-mon-uart
, zephyr,bt-c2h-uart
samples/cellular/slm_shell/boards/nrf54l15dk_nrf54l15_cpuapp.overlay
Outdated
Show resolved
Hide resolved
Add overlay files to support compiling of nrf54l15dk/nrf54l15/cpuapp target. Jira: SLM-51 Signed-off-by: Tommi Rantanen <[email protected]>
8ef028d
to
4959b07
Compare
zephyr,console = &uart30; | ||
zephyr,shell-uart = &uart30; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand, why do you reroute these?
By default, uart20 is used for shell https://github.com/zephyrproject-rtos/zephyr/blob/2241a25a0c4590dc1210be14e8f9c3553b1c09dd/boards/nordic/nrf54l15dk/nrf54l_05_10_15_cpuapp_common.dtsi#L13-L17
so why don't you use some other UART for connecting to SLM?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just haven't been able to get uart30 working as slm-uart when re-routed to the pins I've currently selected. See also #24010 (comment)
Add overlay files to support compiling of nrf54l15dk/nrf54l15/cpuapp target.
PIN configurations for nRF54L15 is here: https://docs.nordicsemi.com/bundle/ug_nrf54l15_dk/page/UG/nRF54L15_DK/hw_desription/connector_if.html
By default uart20 in devicetree is UART1 from the mapping table and uart30 is UART0.
Jira: SLM-51
Note: This requires PR #23625 first so just look at the nRF54 commit.