Skip to content

Conversation

doublemis1
Copy link
Contributor

Configure power optimized snippet for nrf54lm20.

@doublemis1 doublemis1 requested a review from a team as a code owner August 18, 2025 09:59
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Aug 18, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Aug 18, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 2

Inputs:

Sources:

sdk-nrf: PR head: d88794d2007646417c0f6679c0af94b760f34b3f

more details

sdk-nrf:

PR head: d88794d2007646417c0f6679c0af94b760f34b3f
merge base: 57bb508a3cb441ed905426c77d04abfa942ba42e
target head (main): d7b0f5b8d864db09d76256fecad80df206940392
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (3)
snippets
│  ├── matter-power-consumption-tests
│  │  ├── boards
│  │  │  ├── nrf54l15dk.conf
│  │  │  │ nrf54lm20dk.conf
│  │  │ snippet.yml

Outputs:

Toolchain

Version: c5be9c56c7
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:c5be9c56c7_bba2ea5f2e

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
  • ✅ Integration tests
Disabled integration tests
    • test-fw-nrfconnect-nrf_lrcs_mosh
    • test-fw-nrfconnect-nrf_lrcs_positioning
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@doublemis1 doublemis1 requested a review from a team August 18, 2025 10:05
CONFIG_NCS_SAMPLE_MATTER_WATCHDOG=n

# Increase MPSL calibration period to prevent too often CPU wake-ups.
CONFIG_MPSL_CALIBRATION_PERIOD=60000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this may not be required anymore, as the default value for this Kconfig was changed: 67750a2#diff-d0cf324367dd2a74520f81b88e725733ba50734bafaea06bb52b4ecb60753781R104

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will remove from both boards configurations

Configure power optimized snippet for nrf54lm20.

Signed-off-by: Michał Szablowski <[email protected]>
@doublemis1 doublemis1 force-pushed the enable_power_consumption_nrf54lm20 branch from 9a786cd to d88794d Compare August 18, 2025 11:32
@doublemis1
Copy link
Contributor Author

@nrfconnect/ncs-co-build-system please review

@doublemis1
Copy link
Contributor Author

@nrfconnect/ncs-co-build-system Please review

Copy link
Contributor

@tejlmand tejlmand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we have a snippet with just two Kconfig settings ?

This means users not only need to understand Kconfig but also start to understand the difference between 100's of snippets just doing a single or two config changes.

Snippets should really more be for the cases where you need to apply both Kconfig and dt overlays, or a large set of configs.

I also notice tests in the folder name, if this is intended for tests, then it should set in the samples testcase.yaml / sample.yaml.

@kkasperczyk-no
Copy link
Contributor

kkasperczyk-no commented Aug 26, 2025

why do we have a snippet with just two Kconfig settings ?

This means users not only need to understand Kconfig but also start to understand the difference between 100's of snippets just doing a single or two config changes.

Snippets should really more be for the cases where you need to apply both Kconfig and dt overlays, or a large set of configs.

I also notice tests in the folder name, if this is intended for tests, then it should set in the samples testcase.yaml / sample.yaml.

Yes, this is in fact used for tests only. I cannot recall what was the cause of putting it to snippet, but probably we tried to find a common place to keep configuration useful for all samples, and initially we assumed it's going to modify dts .overlay files as well, but then something changed. I agree this is not a good fit here. I will try to re-work this one.

@ArekBalysNordic
Copy link
Contributor

why do we have a snippet with just two Kconfig settings ?

This means users not only need to understand Kconfig but also start to understand the difference between 100's of snippets just doing a single or two config changes.

Snippets should really more be for the cases where you need to apply both Kconfig and dt overlays, or a large set of configs.

I also notice tests in the folder name, if this is intended for tests, then it should set in the samples testcase.yaml / sample.yaml.

Hmm, that's right, it is wrong. I will remove this snippet. But, @tejlmand, I need your recommendation on what we should do instead. We need to have a single test case: sample.matter.lock.release.power_consumption in the sample.yaml file. It integrates nrf52840, nrf5340, nrf54l15 and nrf54lm20. Only for nRF54l devices, we need to additionally apply those three kconfigs that are currently in the snippet, but they should not be applied to nRF52840 and nRF5340. What can we do in this case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants