-
Notifications
You must be signed in to change notification settings - Fork 1.4k
snippets: matter: add nrf54lm20 to power snippet #24027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
snippets: matter: add nrf54lm20 to power snippet #24027
Conversation
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: d88794d2007646417c0f6679c0af94b760f34b3f more detailssdk-nrf:
Github labels
List of changed files detected by CI (3)
Outputs:ToolchainVersion: c5be9c56c7 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
CONFIG_NCS_SAMPLE_MATTER_WATCHDOG=n | ||
|
||
# Increase MPSL calibration period to prevent too often CPU wake-ups. | ||
CONFIG_MPSL_CALIBRATION_PERIOD=60000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this may not be required anymore, as the default value for this Kconfig was changed: 67750a2#diff-d0cf324367dd2a74520f81b88e725733ba50734bafaea06bb52b4ecb60753781R104
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will remove from both boards configurations
Configure power optimized snippet for nrf54lm20. Signed-off-by: Michał Szablowski <[email protected]>
9a786cd
to
d88794d
Compare
@nrfconnect/ncs-co-build-system please review |
@nrfconnect/ncs-co-build-system Please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we have a snippet with just two Kconfig settings ?
This means users not only need to understand Kconfig but also start to understand the difference between 100's of snippets just doing a single or two config changes.
Snippets should really more be for the cases where you need to apply both Kconfig and dt overlays, or a large set of configs.
I also notice tests
in the folder name, if this is intended for tests, then it should set in the samples testcase.yaml / sample.yaml.
Yes, this is in fact used for tests only. I cannot recall what was the cause of putting it to snippet, but probably we tried to find a common place to keep configuration useful for all samples, and initially we assumed it's going to modify dts .overlay files as well, but then something changed. I agree this is not a good fit here. I will try to re-work this one. |
Hmm, that's right, it is wrong. I will remove this snippet. But, @tejlmand, I need your recommendation on what we should do instead. We need to have a single test case: |
Configure power optimized snippet for nrf54lm20.