kconfig: Change CMake-style variable usage to Kconfig-style #24067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog-entry-required
nordicjm
force-pushed
the
fixkconfigbracketspart1
branch
from
4cb46cc to
1717f2e
Compare
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: e710ef7c71aa67cdba70a1dec506f3e131dace78 more detailssdk-nrf:
zephyr:
Github labels
List of changed files detected by CI (312)Outputs:ToolchainVersion: 2b2cd9579a Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
nordicjm
force-pushed
the
fixkconfigbracketspart1
branch
from
1717f2e to
f92dd35
Compare
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
|
You can find the documentation preview for this PR here. Preview links for modified nRF Connect SDK documents: https://ncsdoc.z6.web.core.windows.net/PR-24067/nrf/app_dev/config_and_build/sysbuild/sysbuild_images.html |
nordicjm
force-pushed
the
fixkconfigbracketspart1
branch
from
f92dd35 to
0827a18
Compare
github-actions
bot
added
doc-required
annwoj
approved these changes
Aug 20, 2025
umapraseeda
approved these changes
Aug 20, 2025
|
This PR modifies files from the Matter samples and applications scope, but review from the @nrfconnect/ncs-matter was not triggered. @carlescufi I think this is due to this commit: 9aba998, but was it intended? I can understand that @nrfconnect/ncs-co-build-system requires their review of Kconfigs and cmakes, but can't it be appended to parent directory code owners as a second reviewer instead of overriding? With the current approach it is possible to modify the Matter samples and applications configuration without knowledge and approval of the Matter team that is responsible for these applications. |
kkasperczyk-no
approved these changes
Aug 21, 2025
It is a limitation of how codeowner files work, it stops upon finding a match and does not do multiple matches |
Ok, but following the rst files example, would doing something similar to this work? And the same to other directories |
nordicjm
force-pushed
the
fixkconfigbracketspart1
branch
3 times, most recently
from
feb069e to
d3e02a6
Compare
nordicjm
force-pushed
the
fixkconfigbracketspart1
branch
2 times, most recently
from
7711c3c to
8f3a185
Compare
nordicjm
force-pushed
the
fixkconfigbracketspart1
branch
2 times, most recently
from
5317582 to
ece0184
Compare
nordicjm
force-pushed
the
fixkconfigbracketspart1
branch
8 times, most recently
from
e39bc8f to
5400ce1
Compare
|
Since quarantine was modified, please make sure you are following the process described in Quarantine Process. |
nordicjm
force-pushed
the
fixkconfigbracketspart1
branch
from
2c63f15 to
51c78ed
Compare
Memory footprint analysis revealed the following potential issuesapplications.hpf.gpio.icmsg[nrf54l15dk/nrf54l15/cpuflpr]: High RAM usage: 9090[B] - link (cc: @nrfconnect/ncs-ll-ursus) Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-24067/50) |
greg-fer
approved these changes
Sep 11, 2025
Includes a zephyr module fix for variables Signed-off-by: Jamie McCrae <[email protected]>
Replaces ${...} with $(...) style brackets as the former is for
CMake and latter is for Kconfig
Signed-off-by: Jamie McCrae <[email protected]>
Updates this to generate and use a Kconfig envrionmental file Signed-off-by: Jamie McCrae <[email protected]>
This brings in changes needed by the update to the zephyr module script Signed-off-by: Jamie McCrae <[email protected]>
Quarantines a test that requires a python package not in the NCS toolchain, and a test that has started failing that needs investigating Signed-off-by: Jamie McCrae <[email protected]>
nordicjm
force-pushed
the
fixkconfigbracketspart1
branch
from
51c78ed to
e710ef7
Compare
tejlmand
approved these changes
Sep 11, 2025
jangalda-nsc
approved these changes
Sep 11, 2025
|
WiFi failures are analyzed by @krga2022 . I say we can merge this PR with RED CI on WiFI. |
shanthanordic
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces${...} with $ (...) style brackets as the former is for CMake and latter is for Kconfig