Skip to content

Conversation

degjorva
Copy link
Contributor

@degjorva degjorva commented Sep 9, 2025

See commits
test_crypto: PR-860

@degjorva degjorva requested review from a team, nordicjm and tejlmand as code owners September 9, 2025 14:27
@NordicBuilder NordicBuilder added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Sep 9, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Sep 9, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
trusted-firmware-m nrfconnect/sdk-trusted-firmware-m@2c9f9c6 (main) nrfconnect/sdk-trusted-firmware-m#208 nrfconnect/sdk-trusted-firmware-m#208/files
zephyr nrfconnect/sdk-zephyr@5696f6b nrfconnect/sdk-zephyr#3260 nrfconnect/sdk-zephyr#3260/files

DNM label due to: 2 projects with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Sep 9, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 41

Inputs:

Sources:

trusted-firmware-m: PR head: 2fa149138e11262bf2cd627831629e1fd3a84ccf
sdk-nrf: PR head: aafe446ce1987e1c63644977de4472fd1b67d470
zephyr: PR head: fa9881bec19db2e50abffbb33708017b1ecfe9e2

more details

trusted-firmware-m:

PR head: 2fa149138e11262bf2cd627831629e1fd3a84ccf
merge base: 97e79ea61a6572ed56cdd33396ad7546ef9dfb5d
target head (main): 2c9f9c6e20468ef9dcd433986adea2d3fc036b9d
Diff

sdk-nrf:

PR head: aafe446ce1987e1c63644977de4472fd1b67d470
merge base: 2cc973169f347c57f36df932972cc3d2c48b8f07
target head (main): 2cc973169f347c57f36df932972cc3d2c48b8f07
Diff

zephyr:

PR head: fa9881bec19db2e50abffbb33708017b1ecfe9e2
merge base: 5696f6b423a54390721955d6e0e63c363e02cfff
target head (main): 53fe3820644a1a1198408dc327c2b44dbaf56541
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (91)
cmake
│  ├── sysbuild
│  │  │ partition_manager.cmake
doc
│  ├── nrf
│  │  ├── includes
│  │  │  │ sample_board_rows.txt
│  │  ├── releases_and_maturity
│  │  │  ├── releases
│  │  │  │  │ release-notes-changelog.rst
modules
│  ├── tee
│  │  ├── tf-m
│  │  │  ├── trusted-firmware-m
│  │  │  │  ├── platform
│  │  │  │  │  ├── ext
│  │  │  │  │  │  ├── target
│  │  │  │  │  │  │  ├── nordic_nrf
│  │  │  │  │  │  │  │  ├── common
│  │  │  │  │  │  │  │  │  ├── core
│  │  │  │  │  │  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  │  │  │  │  │  ├── config_nordic_nrf_spe.cmake.in
│  │  │  │  │  │  │  │  │  │  ├── ns
│  │  │  │  │  │  │  │  │  │  │  │ CMakeLists.txt
│  │  │  │  │  │  │  │  │  │  ├── startup.h
│  │  │  │  │  │  │  │  │  │  ├── startup_nrf54l.c
│  │  │  │  │  │  │  │  │  │  ├── startup_nrf54l_common.c
│  │  │  │  │  │  │  │  │  │  ├── startup_nrf54l_common.h
│  │  │  │  │  │  │  │  │  │  ├── startup_nrf54lm.c
│  │  │  │  │  │  │  │  │  │  ├── startup_nrf54lv.c
│  │  │  │  │  │  │  │  │  │  ├── startup_nrf54lx.c
│  │  │  │  │  │  │  │  │  │  │ target_cfg_54l.c
│  │  │  │  │  │  │  │  │  ├── nrf54lm20a
│  │  │  │  │  │  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  │  │  │  │  │  ├── config.cmake
│  │  │  │  │  │  │  │  │  │  ├── cpuarch.cmake
│  │  │  │  │  │  │  │  │  │  ├── ns
│  │  │  │  │  │  │  │  │  │  │  │ CMakeLists.txt
│  │  │  │  │  │  │  │  │  │  ├── partition
│  │  │  │  │  │  │  │  │  │  │  ├── flash_layout.h
│  │  │  │  │  │  │  │  │  │  │  │ region_defs.h
│  │  │  │  │  │  │  │  │  │  ├── tests
│  │  │  │  │  │  │  │  │  │  │  │ psa_arch_tests_config.cmake
│  │  │  │  │  │  │  │  ├── nrf54lm20dk_nrf54lm20a_cpuapp
│  │  │  │  │  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  │  │  │  │  ├── RTE_Device.h
│  │  │  │  │  │  │  │  │  ├── config.cmake
│  │  │  │  │  │  │  │  │  ├── cpuarch.cmake
│  │  │  │  │  │  │  │  │  ├── device_cfg.h
│  │  │  │  │  │  │  │  │  ├── ns
│  │  │  │  │  │  │  │  │  │  │ cpuarch_ns.cmake
│  │  │  │  │  │  │  │  │  ├── services
│  │  │  │  │  │  │  │  │  │  ├── include
│  │  │  │  │  │  │  │  │  │  │  │ tfm_platform_user_memory_ranges.h
│  │  │  │  │  │  │  │  │  │  ├── src
│  │  │  │  │  │  │  │  │  │  │  │ tfm_platform_system.c
│  │  │  │  │  │  │  │  │  ├── tests
│  │  │  │  │  │  │  │  │  │  ├── psa_arch_tests_config.cmake
│  │  │  │  │  │  │  │  │  │  │ tfm_tests_config.cmake
│  │  │  │  │  │  │  │  │  ├── tfm_hal_platform.c
│  │  │  │  │  │  │  │  │  │ tfm_peripherals_config.h
│  ├── trusted-firmware-m
│  │  ├── Kconfig
│  │  ├── Kconfig.tfm.defconfig
│  │  ├── Kconfig.tfm.pm
│  │  ├── tfm_boards
│  │  │  ├── CMakeLists.txt
│  │  │  ├── board
│  │  │  │  │ device_cfg.h
│  │  │  ├── nrf54lm20a_cpuapp
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── config.cmake
│  │  │  │  ├── cpuarch.cmake
│  │  │  │  ├── ns
│  │  │  │  │  │ cpuarch_ns.cmake
samples
│  ├── crypto
│  │  ├── aes_ccm
│  │  │  │ sample.yaml
│  │  ├── aes_gcm
│  │  │  │ sample.yaml
│  │  ├── chachapoly
│  │  │  │ sample.yaml
│  │  ├── ecdh
│  │  │  │ sample.yaml
│  │  ├── ecdsa
│  │  │  │ sample.yaml
│  │  ├── ecjpake
│  │  │  │ sample.yaml
│  │  ├── eddsa
│  │  │  │ sample.yaml
│  │  ├── hkdf
│  │  │  │ sample.yaml
│  │  ├── hmac
│  │  │  │ sample.yaml
│  │  ├── pbkdf2
│  │  │  │ sample.yaml
│  │  ├── persistent_key_usage
│  │  │  ├── boards
│  │  │  │  │ nrf54lm20dk_nrf54lm20_cpuapp_ns.conf
│  │  │  │ sample.yaml
│  │  ├── psa_tls
│  │  │  │ sample.yaml
│  │  ├── rng
│  │  │  │ sample.yaml
│  │  ├── rsa
│  │  │  │ sample.yaml
│  │  ├── sha256
│  │  │  │ sample.yaml
│  │  ├── spake2p
│  │  │  │ sample.yaml
│  ├── tfm
│  │  ├── tfm_hello_world
│  │  │  │ sample.yaml
│  │  ├── tfm_secure_peripheral
│  │  │  ├── boards
│  │  │  │  ├── nrf54lm20dk_nrf54lm20a_cpuapp_ns.conf
│  │  │  │  │ nrf54lv10dk_nrf54lv10a_cpuapp_ns.conf
scripts
│  │ quarantine_zephyr.yaml
subsys
│  ├── bootloader
│  │  │ Kconfig
│  ├── partition_manager
│  │  ├── CMakeLists.txt
│  │  ├── pm.yml.nvs
│  │  ├── pm.yml.settings
│  │  ├── pm.yml.tfm
│  │  │ pm.yml.zms
west.yml
zephyr
│  ├── boards
│  │  ├── nordic
│  │  │  ├── nrf54lm20dk
│  │  │  │  ├── Kconfig
│  │  │  │  ├── Kconfig.defconfig
│  │  │  │  ├── Kconfig.nrf54lm20dk
│  │  │  │  ├── board.cmake
│  │  │  │  ├── board.yml
│  │  │  │  ├── nrf54lm20a_cpuapp_common.dtsi
│  │  │  │  ├── nrf54lm20dk_nrf54lm20a_cpuapp.dts
│  │  │  │  ├── nrf54lm20dk_nrf54lm20a_cpuapp_ns.dts
│  │  │  │  ├── nrf54lm20dk_nrf54lm20a_cpuapp_ns.yaml
│  │  │  │  │ nrf54lm20dk_nrf54lm20a_cpuapp_ns_defconfig
│  ├── dts
│  │  ├── arm
│  │  │  ├── nordic
│  │  │  │  │ nrf54lm20a_enga_cpuapp.dtsi
│  │  ├── vendor
│  │  │  ├── nordic
│  │  │  │  ├── nrf54lm20a.dtsi
│  │  │  │  ├── nrf54lm20a_ns_partition.dtsi
│  │  │  │  │ nrf54lm20a_partition.dtsi
│  ├── modules
│  │  ├── trusted-firmware-m
│  │  │  ├── Kconfig.tfm
│  │  │  ├── nordic
│  │  │  │  ├── nrf54lm20a_cpuapp
│  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  ├── config.cmake
│  │  │  │  │  ├── cpuarch.cmake
│  │  │  │  │  ├── ns
│  │  │  │  │  │  │ cpuarch_ns.cmake
│  ├── soc
│  │  ├── nordic
│  │  │  ├── common
│  │  │  │  ├── uicr
│  │  │  │  │  │ sysbuild.cmake
│  │  │  ├── ironside
│  │  │  │  ├── include
│  │  │  │  │  ├── nrf_ironside
│  │  │  │  │  │  │ boot_report.h

Outputs:

Toolchain

Version: 46667c6630
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:46667c6630_bba2ea5f2e

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
  • ❌ Integration tests
    • ✅ test-sdk-audio
    • ✅ desktop52_verification
    • ✅ test-fw-nrfconnect-apps
    • ✅ test_ble_nrf_config
    • ✅ test-fw-nrfconnect-ble_mesh
    • ✅ test-fw-nrfconnect-ble_samples
    • ✅ test-fw-nrfconnect-chip
    • ✅ test-fw-nrfconnect-nfc
    • ✅ test-fw-nrfconnect-nrf-iot_cloud
    • ✅ test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • ✅ test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • ✅ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • ✅ test-fw-nrfconnect-nrf-iot_samples
    • ✅ test-fw-nrfconnect-nrf-iot_lwm2m
    • ✅ test-fw-nrfconnect-nrf-iot_thingy91
    • ❌ test-fw-nrfconnect-nrf_crypto
    • ✅ test-fw-nrfconnect-proprietary_esb
    • ✅ test-fw-nrfconnect-rpc
    • ✅ test-fw-nrfconnect-rs
    • ✅ test-fw-nrfconnect-fem
    • ✅ test-fw-nrfconnect-tfm
    • ✅ test-fw-nrfconnect-thread-main
    • ✅ test-sdk-find-my
    • ✅ test-fw-nrfconnect-nrf_lrcs_mosh
    • ✅ test-fw-nrfconnect-nrf_lrcs_positioning
    • ✅ test-sdk-wifi
    • ✅ test-low-level
    • ✅ test-sdk-pmic-samples
    • ✅ test-sdk-mcuboot
    • ✅ test-sdk-dfu
    • ✅ test-fw-nrfconnect-ps-main
    • ✅ test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@degjorva degjorva requested review from a team as code owners September 9, 2025 14:50
@NordicBuilder NordicBuilder added doc-required PR must not be merged without tech writer approval. and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Sep 9, 2025
@degjorva degjorva requested a review from greg-fer September 9, 2025 14:50
Copy link
Contributor

@tejlmand tejlmand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of very long lines, both in Kconfig and CMake.

Please line wrap.

default 0x280 if SOC_SERIES_NRF91X || SOC_NRF5340_CPUAPP # Stored in OTP region
# Monotonic counter slot takes 4 bytes on nRF54L Series
default 0x460 if SOC_NRF54L15_CPUAPP || SOC_NRF54L05_CPUAPP || SOC_NRF54L10_CPUAPP || SOC_NRF54LV10A_ENGA_CPUAPP
default 0x460 if SOC_NRF54L15_CPUAPP || SOC_NRF54L05_CPUAPP || SOC_NRF54L10_CPUAPP || SOC_NRF54LV10A_ENGA_CPUAPP || SOC_NRF54LM20A_ENGA_CPUAPP
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please line wrap.

default 0x280 if SOC_NRF5340_CPUNET # Second instance stored in internal flash of NET
default FPROTECT_BLOCK_SIZE
prompt "Flash space reserved for PROVISION" if !(SOC_NRF9160 || SOC_NRF5340_CPUAPP || SOC_NRF54L15_CPUAPP || SOC_NRF54L05_CPUAPP || SOC_NRF54L10_CPUAPP || SOC_NRF54LV10A_ENGA_CPUAPP)
prompt "Flash space reserved for PROVISION" if !(SOC_NRF9160 || SOC_NRF5340_CPUAPP || SOC_NRF54L15_CPUAPP || SOC_NRF54L05_CPUAPP || SOC_NRF54L10_CPUAPP || SOC_NRF54LV10A_ENGA_CPUAPP || SOC_NRF54LM20A_ENGA_CPUAPP)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please line wrap.


.. nrf54lm20dk_nrf54lm20a_cpuapp_ns

| nRF54LM20 DK | | nrf54lm20dk | ``nrf54lm20dk/nrf54lm20a/cpuapp/ns`` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| nRF54LM20 DK | | nrf54lm20dk | ``nrf54lm20dk/nrf54lm20a/cpuapp/ns`` |
| nRF54LM20 DK | PCA10184 | nrf54lm20dk | ``nrf54lm20dk/nrf54lm20a/cpuapp/ns`` |

Comment on lines 4 to 5
# LM20 does not support multipart AES operations so can't use
# encrypted ITS until a workaround is implemented
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# LM20 does not support multipart AES operations so can't use
# encrypted ITS until a workaround is implemented
# LM20 does not support multipart AES operations so it cannot use
# encrypted ITS until a workaround is implemented

@degjorva degjorva force-pushed the lm20-tfm-final branch 2 times, most recently from cd365af to e1edff1 Compare September 10, 2025 12:06
@degjorva degjorva force-pushed the lm20-tfm-final branch 3 times, most recently from 3151467 to d397801 Compare September 11, 2025 08:12
Copy link
Contributor

@greg-fer greg-fer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologize for adding yet another request for edits.
Please also update:

@degjorva degjorva requested a review from Vge0rge October 10, 2025 12:21
@degjorva
Copy link
Contributor Author

Rebase

@NordicBuilder NordicBuilder requested review from a team October 13, 2025 07:08
@degjorva
Copy link
Contributor Author

Rebase

@degjorva
Copy link
Contributor Author

Rebase

@degjorva
Copy link
Contributor Author

Rebase

@NordicBuilder NordicBuilder requested a review from a team October 15, 2025 08:54
@degjorva
Copy link
Contributor Author

Rebase

@NordicBuilder NordicBuilder requested review from a team October 15, 2025 12:15
@degjorva
Copy link
Contributor Author

Rebase

@NordicBuilder NordicBuilder requested review from a team October 17, 2025 08:18
Update configurations to support /ns targets for LM20

Signed-off-by: Dag Erik Gjørvad <[email protected]>
Add support for nRF54LM20A/ns tfm_hello_world and
tfm_secure_peripheral.
Also update incorrect pin masks on 54L devices.

Signed-off-by: Dag Erik Gjørvad <[email protected]>
Add support for nRF54LM20A/ns to all samples that support lm20

Signed-off-by: Dag Erik Gjørvad <[email protected]>
This test is not supported for CRACEN devices.

NCSDK-34723

Signed-off-by: Dag Erik Gjørvad <[email protected]>
@degjorva
Copy link
Contributor Author

Rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.