-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add support for nRF54LM20A/ns #24449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
CI InformationTo view the history of this post, click the 'edited' button above Inputs:Sources:trusted-firmware-m: PR head: dd98f7be60001a4f27e99a5aacba76eab5c5b6b9 more detailstrusted-firmware-m:
sdk-nrf:
zephyr:
Github labels
List of changed files detected by CI (95)Outputs:ToolchainVersion: cfa6b06338 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
a32cc5b to
47f8bab
Compare
tejlmand
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of very long lines, both in Kconfig and CMake.
Please line wrap.
subsys/bootloader/Kconfig
Outdated
| @@ -59,10 +59,10 @@ config PM_PARTITION_SIZE_PROVISION | |||
| hex | |||
| default 0x280 if SOC_SERIES_NRF91X || SOC_NRF5340_CPUAPP # Stored in OTP region | |||
| # Monotonic counter slot takes 4 bytes on nRF54L Series | |||
| default 0x460 if SOC_NRF54L15_CPUAPP || SOC_NRF54L05_CPUAPP || SOC_NRF54L10_CPUAPP || SOC_NRF54LV10A_ENGA_CPUAPP | |||
| default 0x460 if SOC_NRF54L15_CPUAPP || SOC_NRF54L05_CPUAPP || SOC_NRF54L10_CPUAPP || SOC_NRF54LV10A_ENGA_CPUAPP || SOC_NRF54LM20A_ENGA_CPUAPP | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please line wrap.
subsys/bootloader/Kconfig
Outdated
| default 0x280 if SOC_NRF5340_CPUNET # Second instance stored in internal flash of NET | ||
| default FPROTECT_BLOCK_SIZE | ||
| prompt "Flash space reserved for PROVISION" if !(SOC_NRF9160 || SOC_NRF5340_CPUAPP || SOC_NRF54L15_CPUAPP || SOC_NRF54L05_CPUAPP || SOC_NRF54L10_CPUAPP || SOC_NRF54LV10A_ENGA_CPUAPP) | ||
| prompt "Flash space reserved for PROVISION" if !(SOC_NRF9160 || SOC_NRF5340_CPUAPP || SOC_NRF54L15_CPUAPP || SOC_NRF54L05_CPUAPP || SOC_NRF54L10_CPUAPP || SOC_NRF54LV10A_ENGA_CPUAPP || SOC_NRF54LM20A_ENGA_CPUAPP) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please line wrap.
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
| @@ -275,6 +275,10 @@ | |||
|
|
|||
| | :ref:`nRF54LM20 DK <ug_nrf54l>` | PCA10184 | :zephyr:board:`nrf54lm20dk <nrf54lm20dk>` | ``nrf54lm20dk/nrf54lm20a/cpuapp`` | | |||
|
|
|||
| .. nrf54lm20dk_nrf54lm20a_cpuapp_ns | |||
|
|
|||
| | nRF54LM20 DK | | nrf54lm20dk | ``nrf54lm20dk/nrf54lm20a/cpuapp/ns`` | | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| | nRF54LM20 DK | | nrf54lm20dk | ``nrf54lm20dk/nrf54lm20a/cpuapp/ns`` | | |
| | nRF54LM20 DK | PCA10184 | nrf54lm20dk | ``nrf54lm20dk/nrf54lm20a/cpuapp/ns`` | |
| # LM20 does not support multipart AES operations so can't use | ||
| # encrypted ITS until a workaround is implemented |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| # LM20 does not support multipart AES operations so can't use | |
| # encrypted ITS until a workaround is implemented | |
| # LM20 does not support multipart AES operations so it cannot use | |
| # encrypted ITS until a workaround is implemented |
cd365af to
e1edff1
Compare
3151467 to
d397801
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologize for adding yet another request for edits.
Please also update:
- https://docs.nordicsemi.com/bundle/ncs-latest/page/nrf/releases_and_maturity/software_maturity.html#trusted_firmware-m_support and change
--entries for LM20 to either Experimental or Supported. - https://github.com/nrfconnect/sdk-nrf/blob/main/doc/nrf/app_dev/board_names.rst?plain=1#L105 with the following entry before the
flprline:| | | | ``nrf54lm20dk/nrf54lm20a/cpuapp/ns`` (:ref:`TF-M <app_boards_spe_nspe>`) |
It seems that we are getting penalized for touching many files by design then, thats very unfortunate. I guess big PRs makes sense to be delayed as much as possible then to avoid extra unnecessary overhead. |
The error listed is incredible simple, it takes seconds to fix it with a find and replace, literally seconds, then CI is happy and you can stop arguing with a script (because that is actually what you are doing). |
9b59978 to
6b3deaa
Compare
|
@richabp Please take another look |
Hold your horses Jamie. You are expressing your frustration to me even though I actually have very little to do with all this apart from leaving a frustrating comment here. Anyway, Dag Erik fixed it already so its all good but I could not just ignore your comment. |
@Vge0rge What happened to the good old practice of leaving the code in a better shape when anyway touching the file ? |
|
@richabp Ping |
@tejlmand No-one said that slowly improving the code is a bad idea. What I tried to expressed here is that a change like this does penalize big PRs though, which is an undeniable truth. To mitigate that a more clear process need to be established before enforcing such changes globally. Then no-one has frustration, and tensions don't need to be handled in public forums. Anyway, this took more attention and time than needed for sure. |
6b3deaa to
e5620b1
Compare
e5620b1 to
1f2e647
Compare
to me, having to waste time on those discussions, regarding changes that takes less than a minute to fix, is an indication that people don't care for improving the code.
Those rules comes from upstream, and there is a clear process upstream, and if rules or checks are proposed and the community doesn't agree, then discussions can be brought up at the architecture WG or even TSC. So feel free to join all the discussion upstream regarding such rules being introduced. Update, an extra FYI, we inherit compliance check from upstream. |
6c40f89 to
1015433
Compare
Update configurations to support /ns targets for LM20 Signed-off-by: Dag Erik Gjørvad <[email protected]>
Add support for nRF54LM20A/ns tfm_hello_world and tfm_secure_peripheral. Also update incorrect pin masks on 54L devices. Signed-off-by: Dag Erik Gjørvad <[email protected]>
Add support for nRF54LM20A/ns to all samples that support lm20 Signed-off-by: Dag Erik Gjørvad <[email protected]>
This test is not supported for CRACEN devices. NCSDK-34723 Signed-off-by: Dag Erik Gjørvad <[email protected]>
1015433 to
cafd67a
Compare
See commits
test_crypto: PR-860