-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Nrfx 8369 align paths to bsp #24471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nrfx 8369 align paths to bsp #24471
Conversation
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 added project Note: This message is automatically posted and updated by the Manifest GitHub Action. |
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 6ddd688fb956ff7584b54ce5c85a4456d7cb3547 more detailssdk-nrf:
zephyr:
Github labels
List of changed files detected by CI (14)
Outputs:ToolchainVersion: 2b2cd9579a Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
|
||
# Set path to the latest version of nrfx | ||
set(NRFX_DIR ${CMAKE_CURRENT_LIST_DIR}/../../../nrfx/) | ||
set(NRFX_DIR ${NRFX_DIR} CACHE STRING "Path to nrfx") | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why ?
And also, never assume a given Zephyr module is placed relative to another, as a west manifest could define other location. Use the module name dir location.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tejlmand, this change is from #24454 PR, which this PR is based on. Generally, it is a temporary change and is needed only for the collab-nrfx-4.0
branch, to change the nrfx directory to the internal one, which is fetched with west. If you have any more notes regarding those changes, please report them in #24454 Changes from #24454 will be merged with this PR, so we can keep the conversation here.
ff46392
to
f18396f
Compare
58703a4
to
425fcd2
Compare
425fcd2
to
b81fe22
Compare
118a4f4
to
110d598
Compare
Add latest nrfx and change zephyr revision to the most recent commit on collab-nrfx-4.0. This is a temporary change until nrfx-4.0 is released, to be able to test NCS CI with in-development nrfx. Signed-off-by: Michał Bainczyk <[email protected]>
This is a temporary change until nrfx-4.0 is released, to be able to test NCS CI with in-development nrfx. Signed-off-by: Michał Bainczyk <[email protected]>
90b5610
to
9410ca9
Compare
9410ca9
to
c2e0c06
Compare
c2c14c7
to
17e1dbf
Compare
Update sdk-zephyr hash to make it aligned to BSP changes in nrfx. Signed-off-by: Magdalena Pastula <[email protected]>
Make MDK path dependent on BSP path, since it is now located there. Signed-off-by: Magdalena Pastula <[email protected]>
Update nrfx with fix for nrfx_config filename for nRF7120 and nRF54LS05 and with moving inclusion of nrfx.h from nrfx_coredep_defs.h to nrfx_coredep.h. Signed-off-by: Magdalena Pastula <[email protected]>
Remove selecting PRS BOX other than PRS_BOX_0, as it now causes compilation errors due to not checking if `NRFX_PRS_BOX_*_ADDR` is defined in nrfx driver. Signed-off-by: Magdalena Pastula <[email protected]>
NRF_POWER_RAMPOWER_S0POWER is deprecated and is to be removed soon. Signed-off-by: Michał Stasiak <[email protected]>
Add group filter for nrfx. Signed-off-by: Magdalena Pastula <[email protected]>
Will be fixed in NRFX-8421. Signed-off-by: Magdalena Pastula <[email protected]>
Add not passing thingy tests to quarantine due to exceeded flash size after upmerge. Signed-off-by: Magdalena Pastula <[email protected]>
Add to quarantine failing event_manager_proxy.icmsg.cpuflpr test on nRF54LV10. Signed-off-by: Magdalena Pastula <[email protected]>
17e1dbf
to
6ddd688
Compare
f79771d
into
nrfconnect:collab-nrfx-4.0
Based on: #24454 , only the last commit is a part of this PR.Included in this PR.Can be reviewed, CI fixed in terms of changes related to introducing BSP. The following errors are left:
undefined- cherry-picked a fix from lib: ram_pwrdn: replace deprecated NRF_POWER symbol #24602NRF_POWER_RAMPOWER_S0POWER
- related to missing alignment after removal of deprecated API from nrfxundefined- cherry-picked a fix from samples: nordic: nrfx_prs: remove deprecated UARTE API zephyrproject-rtos/zephyr#96153nrfx_uarte_rx
- same as aboveundefined- added to quarantinenrfx_egu_4_irq_handler
- will be handled in a separate PR, needs alignment after errata rework in nrfxAdding nrfx to group filter is needed to make Compliance Checks green. It is overridden in Jenkins. Locally you can do it by calling
west config manifest.group-filter +nrfx
, so that west would fetch the internal nrfx duringwest update