-
Notifications
You must be signed in to change notification settings - Fork 1.4k
sysbuild: Align 53bsim with 53 SoC #24742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sysbuild: Align 53bsim with 53 SoC #24742
Conversation
cab03ee
to
464ad69
Compare
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 43e798b3285a2ccf85d6b6e287f305dff0a498eb more detailssdk-nrf:
Github labels
List of changed files detected by CI (6)
Outputs:ToolchainVersion: a7529a11f4 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
Memory footprint analysis revealed the following potential issuesapplications.nrf_desktop.zdebug.uart[[email protected]/nrf54h20/cpuapp]: RAM size increased by 23661[B] in comparison to the main[5999ecf] branch. - link (cc: @nrfconnect/ncs-si-bluebagel) Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-24742/7) |
464ad69
to
04ff26c
Compare
04ff26c
to
5b23fff
Compare
sysbuild/Kconfig.netcore
Outdated
config SUPPORT_NETCORE | ||
bool | ||
default y if (SOC_NRF5340_CPUAPP || SOC_NRF54H20_CPUAPP) | ||
default y if (SOC_NRF5340_CPUAPP || SOC_NRF54H20_CPUAPP || BOARD_NRF5340BSIM) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aescolar should this be added here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the POV of what the PR is doing I do not see any issue right away.
From the point of view of the actual kconfig option used, as this is a sysbuild file, I guess we are limited to not using the COMPATIBLE options, but that maybe BOARD_NRF5340BSIM_NRF5340_CPUAPP
is a bit better.
sysbuild/Kconfig.netcore
Outdated
config SUPPORT_NETCORE | ||
bool | ||
default y if (SOC_NRF5340_CPUAPP || SOC_NRF54H20_CPUAPP) | ||
default y if (SOC_NRF5340_CPUAPP || SOC_NRF54H20_CPUAPP || BOARD_NRF5340BSIM) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the POV of what the PR is doing I do not see any issue right away.
From the point of view of the actual kconfig option used, as this is a sysbuild file, I guess we are limited to not using the COMPATIBLE options, but that maybe BOARD_NRF5340BSIM_NRF5340_CPUAPP
is a bit better.
2e60584
to
8c5bc5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
sysbuild/netcore.cmake
Outdated
|
||
set_property(GLOBAL PROPERTY PM_DOMAINS ${PM_DOMAINS}) | ||
|
||
if (SB_CONFIG_BOARD_NRF5340BSIM_NRF5340_CPUAPP) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (SB_CONFIG_BOARD_NRF5340BSIM_NRF5340_CPUAPP) | |
if(SB_CONFIG_BOARD_NRF5340BSIM_NRF5340_CPUAPP) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created zephyrproject-rtos/zephyr#96846 to address the underlying issue: Style checks not catching this
This commit sets defaults for the sysbuild configurations SUPPORT_NETCORE and NETCORE_REMOTE_BOARD_TARGET_CPUCLUSTER so that it behaves more similar to the actual 5340 soc. This allows us to remove explicit adding of network core images. Signed-off-by: Rubin Gerritsen <[email protected]>
Use NRF_DEFAULT_IPC_RADIO to enable building of the hci_ipc radio sample for the network core instead of adding it manually. Signed-off-by: Rubin Gerritsen <[email protected]>
8c5bc5a
to
43e798b
Compare
This PR unifies those boards which allows us to cleanup some tests.
See commit messages for additional details.