Skip to content

Conversation

SebastianBoe
Copy link
Contributor

Add a sample that demonstrates use of UICR.SECONDARY.TRIGGER

@SebastianBoe SebastianBoe requested review from a team as code owners October 13, 2025 13:43
@NordicBuilder NordicBuilder added doc-required PR must not be merged without tech writer approval. manifest labels Oct 13, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 13, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
zephyr nrfconnect/sdk-zephyr@dc45b2a nrfconnect/sdk-zephyr@5696f6b (main) nrfconnect/[email protected]

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 13, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 16

Inputs:

Sources:

sdk-nrf: PR head: 03d763090f71aef621b79bfd6d4364a6199026af
zephyr: PR head: 5696f6b423a54390721955d6e0e63c363e02cfff

more details

sdk-nrf:

PR head: 03d763090f71aef621b79bfd6d4364a6199026af
merge base: 77497ca2748d28049c439e0612d0eb642269867e
target head (main): f74c67f5fbff08b4017c7e90107faea1bf4ec8c2
Diff

zephyr:

PR head: 5696f6b423a54390721955d6e0e63c363e02cfff
merge base: dc45b2a09c7872f52b2ddb00c20bd02eb547a8ae
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (20)
doc
│  ├── nrf
│  │  ├── app_dev
│  │  │  ├── device_guides
│  │  │  │  ├── nrf54h
│  │  │  │  │  │ ug_nrf54h20_ironside.rst
samples
│  ├── ironside_se
│  │  ├── secondary_boot_gen_uicr
│  │  │  ├── README.rst
│  │  │  │ sample.yaml
│  │  ├── secondary_boot_trigger_lockup
│  │  │  ├── CMakeLists.txt
│  │  │  ├── README.rst
│  │  │  ├── prj.conf
│  │  │  ├── sample.yaml
│  │  │  ├── secondary
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── app.overlay
│  │  │  │  ├── prj.conf
│  │  │  │  ├── src
│  │  │  │  │  │ main.c
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  │  ├── sysbuild.cmake
│  │  │  ├── sysbuild
│  │  │  │  │ uicr.conf
scripts
│  ├── ci
│  │  │ tags.yaml
west.yml
zephyr
│  ├── scripts
│  │  ├── ci
│  │  │  │ check_compliance.py
│  ├── soc
│  │  ├── nordic
│  │  │  ├── common
│  │  │  │  ├── uicr
│  │  │  │  │  ├── gen_uicr.py
│  │  │  │  │  ├── gen_uicr
│  │  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  │  │ Kconfig

Outputs:

Toolchain

Version: 46667c6630
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:46667c6630_bba2ea5f2e

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 23
    • sdk-zephyr test count: 475
  • ✅ Integration tests
    • ✅ test-sdk-audio
    • ✅ test-fw-nrfconnect-chip
    • ✅ test-fw-nrfconnect-nfc
    • ✅ test-fw-nrfconnect-nrf-iot_cloud
    • ✅ test-fw-nrfconnect-rs
    • ✅ test-fw-nrfconnect-fem
    • ✅ test-fw-nrfconnect-thread-main
    • ✅ test-sdk-find-my
Disabled integration tests
    • test-fw-nrfconnect-nrf_lrcs_mosh
    • test-fw-nrfconnect-nrf_lrcs_positioning
    • desktop52_verification
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-tfm
    • test-low-level
    • test-sdk-dfu
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

Copy link

github-actions bot commented Oct 13, 2025

samples.secondary_boot.nrf54h20dk:
tags:
- sysbuild
- ci_samples_secondary_boot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add full path to tag name e.g ci_samples_ironside_se_secondary_boot or just ci_samples_ironside_se.
To actually work, this tag needs to be defined here: https://github.com/nrfconnect/sdk-nrf/blob/main/scripts/ci/tags.yaml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed the tag

samples.secondary_boot_trigger_lockup.nrf54h20dk:
tags:
- sysbuild
- ci_samples_secondary_boot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add full path to tag name e.g ci_samples_ironside_se_secondary_boot or just ci_samples_ironside_se.
To actually work, this tag needs to be defined here: https://github.com/nrfconnect/sdk-nrf/blob/main/scripts/ci/tags.yaml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed the tag

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it is actually needed (CI uses it to determine scope, without it, all PRs will build those samples which does not make sense)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I was not aware, thank you for explaining.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

These samples are closely integrated with some files in

~/ncs/zephyr/soc/nordic/common/uicr/

Is there any way to express with the tag system that when we patch these files that this tag should be run?

If not, could I add

~/ncs/nrf/west.yml

to the ci_samples_sdfw tag perhaps?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need simply add those paths into depencies for this tag - ci_samples_sdfw - ie in this list https://github.com/nrfconnect/sdk-nrf/blob/main/scripts/ci/tags.yaml#L1514
It supports whole ncs tree, so you can add directly path to zephyr.

Please also add valid path for those samples into dependencies!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow!

Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Please also add valid path for those samples into dependencies!"

Sorry, not sure if I understand you.

That's what I'm doing here right?

https://github.com/nrfconnect/sdk-nrf/pull/25002/files#diff-7776a0ef60151e7b35cfad5534717dd8b14ee36e295c1b86f93e62d7ab02ed6eR1519

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, exactly this, thanks.

@SebastianBoe
Copy link
Contributor Author

@cursor review

Copy link

cursor bot commented Oct 14, 2025

Skipping Bugbot: Bugbot is disabled for this repository

@SebastianBoe SebastianBoe requested review from a team as code owners October 14, 2025 06:43
@NordicBuilder NordicBuilder requested review from a team October 14, 2025 06:43
@SebastianBoe SebastianBoe force-pushed the gen_uicr_final branch 2 times, most recently from c5b1c16 to 1b80a2f Compare October 14, 2025 06:47
@NordicBuilder NordicBuilder added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 14, 2025
@SebastianBoe SebastianBoe requested review from a team, PerMac and katgiadla as code owners October 14, 2025 07:00
@NordicBuilder NordicBuilder requested review from a team October 15, 2025 13:05
@hakonfam hakonfam requested a review from nordicjm October 16, 2025 06:30
@NordicBuilder NordicBuilder requested a review from a team October 16, 2025 10:00
update zephyr

Signed-off-by: Sebastian Bøe <[email protected]>
run ci_samples_sdfw when nrf/samples/ironside_se is changed.

Also get rid of

nrf/samples/sdfw/

as it doesn't exist anymore.

Signed-off-by: Sebastian Bøe <[email protected]>
Add a sample that demonstrates use of UICR.SECONDARY.TRIGGER.

Signed-off-by: Sebastian Bøe <[email protected]>
@rlubos
Copy link
Contributor

rlubos commented Oct 16, 2025

@PerMac @katgiadla @nordic-piks @nrfconnect/ncs-co-build-system @nrfconnect/ncs-test-leads PTAL, apparently GH hides missing reviews in case there's a conflict in the PR 🤷

@NordicBuilder NordicBuilder removed the DNM label Oct 16, 2025
@SebastianBoe
Copy link
Contributor Author

@PerMac @katgiadla @nordic-piks @nrfconnect/ncs-co-build-system @nrfconnect/ncs-test-leads PTAL, apparently GH hides missing reviews in case there's a conflict in the PR 🤷

Ah, I thought I had the reviews I needed.

harness_config:
type: multi_line
regex:
- "=== Primary Image: Demonstrating APPLICATIONLOCKUP trigger ==="
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it needed specific order of the lines?

@rlubos rlubos merged commit 3a3325b into nrfconnect:main Oct 17, 2025
20 of 21 checks passed
@SebastianBoe SebastianBoe deleted the gen_uicr_final branch October 17, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. doc-required PR must not be merged without tech writer approval. manifest manifest-zephyr

Projects

None yet

Development

Successfully merging this pull request may close these issues.