scripts: Uplift scancode-toolkit v32.4.1 #25039

thst-nordic · 2025-10-15T06:36:23Z

Required for west ncs-sbom.

Requires PR: nrfconnect/sdk-zephyr#3282

#24571 was reverted for a test regression.
This is a redo.

scripts: Uplift scancode-toolkit v31.4.1
ci: Add west ncs-sbom smoke test
scripts: Adapt ncs-sbom to scancode-toolkit v32.4.1
ci: Extend west ncs-sbom smoke test
scripts: Fixed windows requirements for scancode

NordicBuilder · 2025-10-15T06:40:07Z

CI Information

^{To view the history of this post, clich the 'edited' button above}
Build number: 5

Inputs:

Sources:

sdk-nrf: PR head: dc1c19a688062c149007479ad1cd866542f0995f

more details

sdk-nrf:

PR head: dc1c19a688062c149007479ad1cd866542f0995f
merge base: 9945db06be3b2c3d983c0c30beda48cda35c7ca3
target head (main): 58433d815751aca939df307aed3c80d082f658c9
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (6)

.github
│  ├── workflows
│  │  │ west-commands.yml
scripts
│  ├── requirements-build.txt
│  ├── requirements-ci.txt
│  ├── requirements-fixed.txt
│  ├── requirements-west-ncs-sbom.txt
│  ├── west_commands
│  │  ├── sbom
│  │  │  │ scancode_toolkit_detector.py

Outputs:

Toolchain

Version:
Build docker image:

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

◻️ Toolchain
◻️ Build twister
◻️ Integration tests
- ◻️ test-fw-nrfconnect-ble_mesh

Disabled integration tests

- test-fw-nrfconnect-nrf_lrcs_mosh
- test-fw-nrfconnect-nrf_lrcs_positioning
- desktop52_verification
- test_ble_nrf_config
- test-fw-nrfconnect-apps
- test-fw-nrfconnect-ble_samples
- test-fw-nrfconnect-chip
- test-fw-nrfconnect-fem
- test-fw-nrfconnect-nfc
- test-fw-nrfconnect-nrf-iot_cloud
- test-fw-nrfconnect-nrf-iot_libmodem-nrf
- test-fw-nrfconnect-nrf-iot_lwm2m
- test-fw-nrfconnect-nrf-iot_samples
- test-fw-nrfconnect-nrf-iot_serial_lte_modem
- test-fw-nrfconnect-nrf-iot_thingy91
- test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
- test-fw-nrfconnect-nrf_crypto
- test-fw-nrfconnect-proprietary_esb
- test-fw-nrfconnect-ps-main
- test-fw-nrfconnect-rpc
- test-fw-nrfconnect-rs
- test-fw-nrfconnect-tfm
- test-fw-nrfconnect-thread-main
- test-low-level
- test-sdk-audio
- test-sdk-dfu
- test-sdk-find-my
- test-sdk-mcuboot
- test-sdk-pmic-samples
- test-sdk-wifi
- test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

tejlmand

Please checkup commit changes and ordering.
There are changes in one commit being overruled by following commit. Should those be squashed ?

Also commit cd3da98 message is:


scripts: Fixed windows requirements for scancode

Uppercase AMD64 instead of amd64.

But the commit does much more than this.

tejlmand · 2025-10-15T06:52:27Z

.github/workflows/west-commands.yml

        run: |
+          pip3 install -r nrf/scripts/requirements-fixed.txt
          pip3 install -r nrf/scripts/requirements-west-ncs-sbom.txt
          pip3 install -r nrf/scripts/requirements-extra.txt


I thought requirements-extra.txt was included when populated requirements-fixed.txt, so is this line still needed ?

@nicu1989 @jangalda-nsc

you are right, if a PR has requirements-fixed up to date(which it should) with changes in requirements-west-ncs-sbom and requirements-extra then those requirements are not required. I will remove both requirements-extra.txt and requirements-west-ncs-sbom.txt

tejlmand · 2025-10-15T06:52:33Z

.github/workflows/west-commands.yml

+          python -m pip install --upgrade pip
+          python -m pip install -r nrf/scripts/requirements-fixed.txt
+          python -m pip install -r nrf/scripts/requirements-west-ncs-sbom.txt
+          python -m pip install -r nrf/scripts/requirements-extra.txt


I thought requirements-extra.txt was included when populated requirements-fixed.txt, so is this line still needed ?

thst-nordic · 2025-10-15T12:33:48Z

Please checkup commit changes and ordering. There are changes in one commit being overruled by following commit. Should those be squashed ?

this PR was merged and then reverted.
https://github.com/nrfconnect/sdk-nrf/pull/24571/commits

I considered squashing but they aren't my commits.
the commits are in the right order.

nicu1989 · 2025-10-15T12:48:38Z

Please checkup commit changes and ordering. There are changes in one commit being overruled by following commit. Should those be squashed ?

this PR was merged and then reverted. https://github.com/nrfconnect/sdk-nrf/pull/24571/commits

I considered squashing but they aren't my commits.

the commits are in the right order.

I can try and redo the commits to have basically 3: workflow update, scancode uplift and scancode json adaptation.

Required for west ncs-sbom. Signed-off-by: Nicolae Dicu <[email protected]>

Scancode outputs json format 4.1.0 now. Sbom has been adapted. Signed-off-by: Nicolae Dicu <[email protected]>

Run west ncs-sbom command for supported OS: windows-latest ubuntu-24.04 on dummy file and verify scancode version. Signed-off-by: Nicolae Dicu <[email protected]>

Nordic version of x690 does not include `tests` folder. exhuma/x690#2 Signed-off-by: Jan Gałda <[email protected]>

thst-nordic · 2025-10-16T07:54:04Z

@nicu1989 This is ready to merge, just need a +1

thst-nordic · 2025-10-16T08:01:15Z

@carlescufi and @tejlmand both approved the previous PR.
#24571
so I will merge.

NordicBuilder added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 15, 2025

thst-nordic requested review from dawidprzybylo and nordic-piks October 15, 2025 06:36

thst-nordic marked this pull request as ready for review October 15, 2025 06:37

thst-nordic requested review from a team as code owners October 15, 2025 06:37

tejlmand reviewed Oct 15, 2025

View reviewed changes

nicu1989 added 3 commits October 15, 2025 16:35

scripts: Uplift scancode-toolkit v31.4.1

b299558

Required for west ncs-sbom. Signed-off-by: Nicolae Dicu <[email protected]>

scripts: Adapt ncs-sbom to scancode-toolkit v32.4.1

7b9bdfe

Scancode outputs json format 4.1.0 now. Sbom has been adapted. Signed-off-by: Nicolae Dicu <[email protected]>

ci: Add extended west ncs-sbom smoke test

a2dc370

Run west ncs-sbom command for supported OS: windows-latest ubuntu-24.04 on dummy file and verify scancode version. Signed-off-by: Nicolae Dicu <[email protected]>

nicu1989 force-pushed the update_scancodetoolkit branch from cd3da98 to a2dc370 Compare October 15, 2025 13:40

NordicBuilder requested a review from a team October 15, 2025 13:41

nicu1989 requested review from carlescufi and tejlmand October 15, 2025 13:57

tools: Use x690==1.0.0.post2+nordic

dc1c19a

Nordic version of x690 does not include `tests` folder. exhuma/x690#2 Signed-off-by: Jan Gałda <[email protected]>

jangalda-nsc force-pushed the update_scancodetoolkit branch from 019b94a to dc1c19a Compare October 16, 2025 07:13

jangalda-nsc approved these changes Oct 16, 2025

View reviewed changes

nicu1989 approved these changes Oct 16, 2025

View reviewed changes

thst-nordic merged commit 77a4a6c into nrfconnect:main Oct 16, 2025
23 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

scripts: Uplift scancode-toolkit v32.4.1 #25039

scripts: Uplift scancode-toolkit v32.4.1 #25039

Uh oh!

thst-nordic commented Oct 15, 2025

Uh oh!

NordicBuilder commented Oct 15, 2025 •

edited

Loading

Uh oh!

tejlmand left a comment •

edited

Loading

Uh oh!

tejlmand Oct 15, 2025

Uh oh!

carlescufi Oct 15, 2025

Uh oh!

nicu1989 Oct 15, 2025 •

edited

Loading

Uh oh!

tejlmand Oct 15, 2025

Uh oh!

thst-nordic commented Oct 15, 2025

Uh oh!

nicu1989 commented Oct 15, 2025

Uh oh!

thst-nordic commented Oct 16, 2025

Uh oh!

thst-nordic commented Oct 16, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

scripts: Uplift scancode-toolkit v32.4.1 #25039

scripts: Uplift scancode-toolkit v32.4.1 #25039

Uh oh!

Conversation

thst-nordic commented Oct 15, 2025

Uh oh!

NordicBuilder commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

Uh oh!

tejlmand left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tejlmand Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

carlescufi Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

nicu1989 Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tejlmand Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

thst-nordic commented Oct 15, 2025

Uh oh!

nicu1989 commented Oct 15, 2025

Uh oh!

thst-nordic commented Oct 16, 2025

Uh oh!

thst-nordic commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

NordicBuilder commented Oct 15, 2025 •

edited

Loading

tejlmand left a comment •

edited

Loading

nicu1989 Oct 15, 2025 •

edited

Loading

thst-nordic commented Oct 16, 2025 •

edited

Loading