Skip to content

Deprecate BT_FIXED_APPKEY #25414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Deprecate BT_FIXED_APPKEY #25414

wants to merge 3 commits into from
+62 −12

Conversation

@m-alperen-sener
Copy link
Contributor

@m-alperen-sener m-alperen-sener commented Nov 4, 2025

Deprecating BT_FIXED_PASSKEY and start using BT_APP_PASSKEY instead.

@m-alperen-sener
manifest: sdk-zephyr: deprecate fixed passkey
97c8465 
Manifest update to depracate and replace BT_FIXED_PADDKEY

Signed-off-by: alperen sener <[email protected]>
@m-alperen-sener
bluetooth: mesh: update le pair responder model with BT_APP_PASSKEY
7476d7c 
BT_FIXED_PASSKEY is depracated so wee need to aling the le pair
responder model with the new Kconfig BT_APP_PASSKEY usage.

Depracate bt_mesh_le_pair_resp_passkey_invalidate, it not needed
anymore.

Adding bt_mesh_le_pair_resp_passkey_get to be able to retreive
the passkey set randomly or by app.

Signed-off-by: alperen sener <[email protected]>
@m-alperen-sener
sample: bluetooth: mesh: start using BT_APP_PASSKEY
2999999 
BT_FIXED_PASSKEY is deprecated, thus we start using BT_APP_PASSKEY

Signed-off-by: alperen sener <[email protected]>
@m-alperen-sener m-alperen-sener requested review from a team as code owners November 4, 2025 16:10
@NordicBuilder NordicBuilder added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Nov 4, 2025
@m-alperen-sener m-alperen-sener mentioned this pull request Nov 4, 2025
Closed
@NordicBuilder NordicBuilder requested a review from a team November 4, 2025 16:10
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 4, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
zephyr nrfconnect/sdk-zephyr@cefb2ed (main) nrfconnect/sdk-zephyr#3466 nrfconnect/sdk-zephyr#3466/files

⛔ DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 4, 2025 •
edited
Loading

CI Information

To view the history of this post, click the 'edited' button above
Build number: 1

Inputs:

Sources:

sdk-nrf: PR head: 29999998db0b2b74ff7e9edef8030e1a19d18fa6
zephyr: PR head: e84fa1b4757a94c7a7595769049c9a4e492b8862

more details

sdk-nrf:

PR head: 29999998db0b2b74ff7e9edef8030e1a19d18fa6
merge base: c14c9f573b6cd87187f57c0d9f956011d0b42e0a
target head (main): c14c9f573b6cd87187f57c0d9f956011d0b42e0a
Diff

zephyr:

PR head: e84fa1b4757a94c7a7595769049c9a4e492b8862
merge base: a9bbd349efde16d5b89d65ce369c307a422327b9
target head (main): 25f7b905665e488a00e66ed1335f1b46d87b53ef
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (14) 
include
│  ├── bluetooth
│  │  ├── mesh
│  │  │  ├── vnd
│  │  │  │  │ le_pair_resp.h
samples
│  ├── bluetooth
│  │  ├── mesh
│  │  │  ├── common
│  │  │  │  │ smp_bt_auth.c
│  │  │  ├── dfu
│  │  │  │  ├── distributor
│  │  │  │  │  │ overlay-smp-bt-auth.conf
subsys
│  ├── bluetooth
│  │  ├── mesh
│  │  │  ├── vnd
│  │  │  │  ├── Kconfig
│  │  │  │  │ le_pair_resp.c
west.yml
zephyr
│  ├── doc
│  │  ├── releases
│  │  │  │ migration-guide-4.3.rst
│  ├── include
│  │  ├── zephyr
│  │  │  ├── bluetooth
│  │  │  │  │ conn.h
│  ├── subsys
│  │  ├── bluetooth
│  │  │  ├── host
│  │  │  │  ├── Kconfig
│  │  │  │  ├── shell
│  │  │  │  │  │ bt.c
│  │  │  │  │ smp.c
│  ├── tests
│  │  ├── bluetooth
│  │  │  ├── shell
│  │  │  │  ├── audio.conf
│  │  │  │  ├── log.conf
│  │  │  │  │ prj.conf

Outputs:

Toolchain

Version: cfa6b06338
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:cfa6b06338_e595b21c39

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ❌ Build twister
    • sdk-nrf test count: 1309
    • sdk-zephyr test count: 677
  • ❌ Integration tests
    • ❌ test-sdk-audio
    • ❌ desktop52_verification
    • ❌ test_ble_nrf_config
    • ❌ test-fw-nrfconnect-ble_mesh
    • ❌ test-fw-nrfconnect-ble_samples
    • ❌ test-fw-nrfconnect-chip
    • ❌ test-fw-nrfconnect-nfc
    • ❌ test-fw-nrfconnect-nrf-iot_thingy91
    • ❌ test-sdk-find-my
    • ❌ test-low-level
    • ❌ test-sdk-dfu
Disabled integration tests
    • test-fw-nrfconnect-nrf_lrcs_positioning
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread-main
    • test-sdk-mcuboot
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@github-actions
Copy link

github-actions bot commented Nov 4, 2025

You can find the documentation preview for this PR here.

nordicjm
nordicjm reviewed Nov 5, 2025
View reviewed changes
subsys/bluetooth/mesh/vnd/Kconfig
endif # BT_MESH_DM_SRV

config BT_MESH_LE_PAIR_RESP
bool "LE Pairing Responder model"
Copy link
Contributor

@nordicjm nordicjm Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
bool "LE Pairing Responder model"
bool "LE Pairing Responder model [EXPERIMENTAL]"

Copy link
Contributor

@omkar3141 omkar3141 Nov 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 'Experimental'? Using this model allows fixed passkey to be not used by virtue of the architecture. Specification does not say that one should remove API or change APIs, the specification gives guideline that fixed passkey is not allowed. This model along with the underlaying API creates a system that make fulfilling this requirement possible.

Copy link
Contributor

@nordicjm nordicjm Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because 2 lines down, you are selecting the EXPERIMENTAL Kconfig ?? https://github.com/nrfconnect/sdk-nrf/pull/25414/files#diff-6b6980f5c948cf835b4cfac2ecf56cb964fa0e31bd790325f3f17a351e23718dR90

Copy link
Contributor

@alxelax alxelax Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess, because it has experimental tag. Either we have to remove it or add what @nordicjm requested.

Copy link
Contributor

@carlescufi carlescufi Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, if you select EXPERIMENTAL then you should clearly mark it as experimental in the title, that is the convention

Copy link
Contributor Author

@m-alperen-sener m-alperen-sener Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do that 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlescufi carlescufi carlescufi left review comments

@omkar3141 omkar3141 omkar3141 left review comments

@nordicjm nordicjm nordicjm left review comments

@alxelax alxelax alxelax left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. DNM manifest manifest-zephyr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@m-alperen-sener @NordicBuilder @carlescufi @omkar3141 @nordicjm @alxelax