-
Notifications
You must be signed in to change notification settings - Fork 1.4k
bluetooth: host: Interval is deprecated, use interval_us #25678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bluetooth: host: Interval is deprecated, use interval_us #25678
Conversation
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
CI InformationTo view the history of this post, click the 'edited' button above Inputs:Sources:memfault-firmware-sdk: PR head: 050c1a5748f9c668cb1c152735438596e528ad9c more detailsmemfault-firmware-sdk:
sdk-nrf:
zephyr:
Github labels
List of changed files detected by CI (148)Outputs:ToolchainVersion: Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
32b0b0e to
b13edd7
Compare
|
You can find the documentation preview for this PR here. |
b13edd7 to
fd9a158
Compare
36cd20c to
7c1c678
Compare
7c1c678 to
478c723
Compare
9faff95 to
4aa5634
Compare
|
@nrfconnect/ncs-si-muffin Please review, Jenkins build will be fixed when nrfconnect/sdk-zephyr/pull/3523 is merged. |
4aa5634 to
e6142bc
Compare
7d5c7b6 to
5072efc
Compare
With the introduction of Shorter Connection Intervals, Zephyr has deprecated bt_conn_le_info.interval in favour of bt_conn_le_info.interval_us. Changing the unit from 1.25 milliseconds to microseconds. Signed-off-by: Timothy Keys <[email protected]>
Manifest PR for nrfconnect/sdk-zephyr#3513 Manifest PR for https://github.com/memfault/memfault-firmware-sdk/releases/tag/1.31.0 Signed-off-by: Timothy Keys <[email protected]>
5072efc to
b08a22b
Compare
|
@bama-nordic @muraliThokala @nrfconnect/ncs-si-bluebagel Please review |
| #define CONN_INTERVAL_BLE_REG 0x0008 /* 10 ms */ | ||
| #define CONN_INTERVAL_BLE_US 10000 | ||
| #else | ||
| #define CONN_INTERVAL_BLE_REG 0x0006 /* 7.5 ms */ | ||
| #define CONN_INTERVAL_BLE_US 7500 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use BT_GAP_US_TO_CONN_INTERVAL macro instead of defining CONN_INTERVAL_BLE_REG macro? That would simplify implementation and got rid of redundant definitions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can i do that in a follow up pr? I would prefer not to delay this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, no problem
bluetooth: host: Interval is deprecated, use interval_us
With the introduction of Shorter Connection Intervals, Zephyr has
deprecated bt_conn_le_info.interval in favour of
bt_conn_le_info.interval_us. Changing the unit from 1.25 milliseconds to
microseconds.
manifest: Update sdk-zephyr and memfault-firmware-sdk
Manifest PR for bluetooth: host: Add Shorter Connection Intervals support sdk-zephyr#3513
Manifest PR for https://github.com/memfault/memfault-firmware-sdk/releases/tag/1.31.0