Skip to content

Conversation

@tomchy
Copy link
Contributor

@tomchy tomchy commented Nov 26, 2025

Enable HW rollback protection in the A/B split slot sample.

Copilot AI review requested due to automatic review settings November 26, 2025 19:14
@tomchy tomchy requested review from a team as code owners November 26, 2025 19:14
@NordicBuilder NordicBuilder added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Nov 26, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables hardware-based rollback protection in the A/B split slot DFU sample by integrating the IronSide counter service with MCUboot. The changes update dependency revisions and add necessary configuration options.

  • Updates Zephyr and MCUboot dependencies to pull request branches that support IronSide counters
  • Enables IronSide counter service in MCUboot configuration
  • Activates hardware-based downgrade prevention in the sysbuild configuration

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
west.yml Updates Zephyr and MCUboot revisions to pull request branches
samples/dfu/ab_split/sysbuild/mcuboot/prj.conf Enables IronSide counter service and MCUboot IronSide counter implementation
samples/dfu/ab_split/sysbuild.conf Enables hardware-based downgrade prevention configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 26, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 26, 2025

CI Information

To view the history of this post, click the 'edited' button above
Build number: 3

Inputs:

Sources:

more details

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (0)

Outputs:

Toolchain

Version:
Build docker image:

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ❌ Toolchain
  • ❌ Build twister
  • ❌ Integration tests

Note: This message is automatically posted and updated by the CI

@tomchy tomchy added this to the 3.2.0 milestone Nov 26, 2025
@github-actions
Copy link

You can find the documentation preview for this PR here.

@shanthanordic
Copy link

PR not ready moving it out of 3.2.0 scope

@shanthanordic shanthanordic removed this from the 3.2.0 milestone Nov 27, 2025
@tomchy tomchy force-pushed the bugfix/ironside/NCSDK-36359_Align_counter branch from 73e0585 to 5e0239c Compare November 27, 2025 13:14
@shanthanordic shanthanordic added this to the 3.2.0 milestone Nov 28, 2025
Enable HW-based downgrade protection inside the A/B sample with split
slots.

Ref: NCSDK-36359

Signed-off-by: Tomasz Chyrowicz <[email protected]>
Copilot AI review requested due to automatic review settings November 28, 2025 16:44
@rlubos rlubos force-pushed the bugfix/ironside/NCSDK-36359_Align_counter branch from 5e0239c to 2ecf43d Compare November 28, 2025 16:44
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@rlubos rlubos merged commit 62a0759 into nrfconnect:main Nov 28, 2025
14 of 21 checks passed
@tomchy tomchy deleted the bugfix/ironside/NCSDK-36359_Align_counter branch December 1, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants