-
Notifications
You must be signed in to change notification settings - Fork 1.4k
manifest: sdk-zephyr: Host cherry pick tx processor thread #26096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
manifest: sdk-zephyr: Host cherry pick tx processor thread #26096
Conversation
|
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
CI InformationTo view the history of this post, click the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 329ebcb0056de95530b739269da39088bb0ecfde more detailssdk-nrf:
zephyr:
Github labels
List of changed files detected by CI (12)Outputs:ToolchainVersion: 43683a87ea Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
|
You can find the documentation preview for this PR here. |
943dbb8 to
adc925a
Compare
adc925a to
64f1aab
Compare
ac8d644 to
eadb225
Compare
eadb225 to
d67fcda
Compare
d67fcda to
7e043bd
Compare
applications/nrf_desktop/Kconfig
Outdated
|
|
||
| # RAM for this application for these boards is too few to | ||
| # use the BT TX processor thread. | ||
| configdefault BT_TX_PROCESSOR_THREAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we assign it explicitly in configurations (for consistency with other applied memory optimizations)? I can add the commit with change if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The config is unprompted, see https://github.com/nrfconnect/sdk-zephyr/pull/3606/files#diff-3abe882adb2271b5b37793fb9cd859d2ac5cbaa4450c9556668a6a6d696341b0R136, so we cannot just set it to "n" in prj.conf files. But maybe I misunderstand you? (I shifted the placement of this into the proper menu now btw (so a few lines down) don't know why I placed it weirdly yesterday, still within the file so your concern is still valid, I guess)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are welcome to add a commit, if that is faster than commenting back and forth. I might squash them in one though in the end.
7e043bd to
c37ee8c
Compare
7a00749 to
0ca283d
Compare
Automatically created by action-manifest-pr GH action from PR: nrfconnect/sdk-zephyr#3606 Signed-off-by: Nordic Builder <[email protected]>
0ca283d to
f09cfd9
Compare
Values were derived from Thread Analyzer results. Applying SoC-specific defaults here to avoid touching upstream Zephyr files. Applications can still override via prj.conf. BT_TX_PROCESSOR_STACK_SIZE config was disabled for the samples/applications that don't have enough RAM to support it. Signed-off-by: Kyra Lengfeld <[email protected]>
f09cfd9 to
329ebcb
Compare
Memory footprint analysis revealed the following potential issuesapplications.nrf_desktop.zrelease[nrf52kbd/nrf52832]: RAM size increased by 888[B] in comparison to the main[6a7b8f9] branch. - link (cc: @nrfconnect/ncs-si-bluebagel) Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-26096/20) |
Automatically created by action-manifest-pr GH action from PR:
nrfconnect/sdk-zephyr#3606