Skip to content

Conversation

NordicBuilder
Copy link
Contributor

CHANGELOG.rst contains the list of changes.

Signed-off-by: Ivan Iushkov <[email protected]>
CHANGELOG.rst contains the list of changes.

Signed-off-by: Ivan Iushkov <[email protected]>
@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label Oct 6, 2025
Copy link

sonarqubecloud bot commented Oct 6, 2025

#include <stdint.h>
#include <stdbool.h>
#include "nrf.h"
#include "nrfx.h"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cant see any use of the nrf.h header in this file. Can we just remove the include instead?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I think LUMOS_XXAA is defined in nrf.h (line 39). But I think maybe I can remove nrf.h include from sdc.h, probably it is not used there. I will find some cleaner solution later, this PR was created only for testing of new nrfx revision by LL team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants