west: add west.yml #687
Merged
west: add west.yml #687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertGalatNordic
force-pushed
the
add_west_yml
branch
from
59e316d to
95eaeef
Compare
.config diff |
RobertGalatNordic
force-pushed
the
add_west_yml
branch
20 times, most recently
from
1f12dd6 to
b713146
Compare
ktaborowski
approved these changes
Mar 12, 2025
Contributor
ktaborowski
left a comment
ktaborowski
left a comment
There was a problem hiding this comment.
looks good. minor comments
RobertGalatNordic
force-pushed
the
add_west_yml
branch
4 times, most recently
from
68446e8 to
b59b1df
Compare
RobertGalatNordic
force-pushed
the
add_west_yml
branch
3 times, most recently
from
fca9a0d to
15d637a
Compare
add west.yml to sidewalk project update github actions improve build and test in GHA, by dynamically selecting number of runners nrfconnect/sdk-nrf#20901 update template for PRs Signed-off-by: Robert Gałat <[email protected]>
RobertGalatNordic
force-pushed
the
add_west_yml
branch
from
15d637a to
1b913b4
Compare
update nrf version in west.yml Signed-off-by: Robert Gałat <[email protected]>
github-actions
bot
added
the
doc-required
…0070] - Update index.rst to reflect Sidewalk's move to standalone west.yml - Add migration_guide.rst to the main documentation toctree - Update include_building_and_running.txt to reference new setup process - Revise setting_up_sdk.rst with new setup process and migration steps - Add toolchain and Python package installation instructions - Update NCS documentation about Sidewalk configuration The changes reflect that Sidewalk is no longer part of the NCS manifest and now uses its own west.yml configuration, providing clearer setup instructions for both new users and those migrating from NCS. Signed-off-by: Robert Gałat <[email protected]>
RobertGalatNordic
force-pushed
the
add_west_yml
branch
from
4541067 to
5ed8ecc
Compare
Contributor
Contributor
|
According to documentation - I would move |
use nrf revision that no longer mentions sidewalk Signed-off-by: Robert Gałat <[email protected]>
This is a point of discussion how to trigger the nrf update. for now we can manually update the nrf revision via PR and automatic solution need to be tested fist Signed-off-by: Robert Gałat <[email protected]>
ktaborowski
reviewed
Mar 20, 2025
Contributor
There was a problem hiding this comment.
rename migration_guide_addon_v010
Collaborator
Author
There was a problem hiding this comment.
I didn't notice your comment, I renamed it migration_guide_standalone.rst,
I think it also describes the change good enough for our need
Contributor
There was a problem hiding this comment.
Another migration guides are named from ncs versions so I would recommend to keep this convetion, see https://github.com/nrfconnect/sdk-sidewalk/tree/main/doc/releases_and_migration
Collaborator
Author
There was a problem hiding this comment.
ok I will fix it
ktaborowski
reviewed
Mar 20, 2025
| @@ -0,0 +1,161 @@ | |||
| .. _migration_guide: | |||
|
|
|||
| Migration Guide: Moving from NCS Manifest to Standalone west.yml | |||
Contributor
There was a problem hiding this comment.
Migration Guide for moving to Sidewalk Add-on ?
update documentation Signed-off-by: Robert Gałat <[email protected]>
Collaborator
Author
documentation moved: |
ktaborowski
reviewed
Mar 20, 2025
|
|
||
| .. code-block:: console | ||
| # Remove the .west directory to clean the west configuration |
Contributor
There was a problem hiding this comment.
I would suggest moving comments to the text section instead placing in in the cosnole snippets
Collaborator
Author
There was a problem hiding this comment.
I think that those comments in place are actually good, they does not matter if you copy/paste whole block, and they explain line by line why the command is needed
ktaborowski
reviewed
Mar 20, 2025
| |___ nrfxlib | ||
| |___ zephyr | ||
| |___ ... | ||
| git clone https://github.com/nordicsemiconductor/sidewalk.git sidewalk |
Contributor
There was a problem hiding this comment.
I think you can initlize west form sidewalk repostoriy directly, no need to clone it with git and init west locally.
Collaborator
Author
There was a problem hiding this comment.
hmm true, you can do i both ways, I will try to add it to the doc
ktaborowski
reviewed
Mar 20, 2025
| git clone https://github.com/nordicsemiconductor/sidewalk.git sidewalk | ||
| #. Enable the Sidewalk group filter for west. | ||
| 2. If you are migrating from an existing NCS setup with Sidewalk, clean the west configuration: |
Contributor
There was a problem hiding this comment.
I suggest moving it to the Note section or sht with a link to migration guide instead of keeping in in setting up instructions
Contributor
|
@annwoj please review commit |
add self section to west.yml Signed-off-by: Robert Gałat <[email protected]>
Contributor
|
Link to the latest documentation: https://jenkins-ncs.nordicsemi.no/job/KRKNG/job/Sidewalk/job/test-sdk-sidewalk/job/add-on/25/artifact/html_doc/index.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add west.yml to sidewalk project
CI parameters
TODO:
Description
JIRA ticket: KRKNWK-20045
KRKNWK-20066
nrfconnect/sdk-nrf#20901
Self review