Open
Conversation
krish2718
requested changes
Feb 25, 2024
Collaborator
|
Please don't use empty commit log body |
D-Triveni
force-pushed
the
qt_fixes_v2.5.1
branch
from
f32527f to
f2479e7
Compare
krish2718
reviewed
Feb 26, 2024
D-Triveni
force-pushed
the
qt_fixes_v2.5.1
branch
from
6137d30 to
7583c22
Compare
krish2718
reviewed
Feb 26, 2024
D-Triveni
force-pushed
the
qt_fixes_v2.5.1
branch
from
7583c22 to
489eeb5
Compare
krish2718
force-pushed
the
qt_fixes_v2.5.1
branch
from
a01fbf4 to
389d831
Compare
D-Triveni
force-pushed
the
qt_fixes_v2.5.1
branch
from
389d831 to
7bdeeea
Compare
Replaced sprintf with snprintf to enhance string length handling. Signed-off-by: Triveni Danda <triveni.danda@nordicsemi.no>
…changes Control socket is opened by supplicant, so sending request on the control is enough. Signed-off-by: Triveni Danda <triveni.danda@nordicsemi.no>
…e destination buffer length This to ensure that the copying operation does not exceed the size of the destination buffer. Signed-off-by: Triveni Danda <triveni.danda@nordicsemi.no>
Use strncpy to prevent buffer overflow vulnerabilities. Signed-off-by: Triveni Danda <triveni.danda@nordicsemi.no>
Implement imperative check for supplicant readiness prior to QT thread initiation. Signed-off-by: Triveni Danda <triveni.danda@nordicsemi.no>
STA disconnect doesn't any reboot. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
krish2718
force-pushed
the
qt_fixes_v2.5.1
branch
from
7bdeeea to
f097c43
Compare
krish2718
reviewed
Feb 27, 2024
Collaborator
krish2718
left a comment
krish2718
left a comment
There was a problem hiding this comment.
- Also, make the delay after
sentofor reboot configurable - one snprintf remaining in utils.c that isn't converted to macro
- My changes for get_mac_address from the patch
- My changes for run_qt_command
|
|
||
| #define CHECK_SNPRINTF(dest, dest_size, ...) \ | ||
| do { \ | ||
| int result = snprintf(dest, dest_size, __VA_ARGS__); \ |
Collaborator
There was a problem hiding this comment.
don't declare variables in macros, let functions declare them and we just use it here
| } \ | ||
| } while(0) | ||
|
|
||
| #define RUN_QT_COMMAND(request, ret) \ |
Collaborator
There was a problem hiding this comment.
Don't need to pass ret here, this is a macro not a function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.