Skip to content

Upmerge 02.06.2025 #10623

Upmerge 02.06.2025

Upmerge 02.06.2025 #10623

Triggered via pull request June 16, 2025 09:02
Status Failure
Total duration 57m 11s
Artifacts 1

compliance.yml

on: pull_request
Run compliance checks on patch series (PR)
57m 5s
Run compliance checks on patch series (PR)
Fit to window
Zoom out
Zoom in

Annotations

14 errors, 11 warnings, and 10 notices
Run compliance checks on patch series (PR)
Process completed with exit code 1.
Run compliance checks on patch series (PR): Ruff.txt#L0
Check python files with ruff. Python format error:Run 'ruff format tests/bluetooth/classic/gap_s/pytest/test_gap_s.py' File:tests/bluetooth/classic/gap_s/pytest/test_gap_s.py
Run compliance checks on patch series (PR): Pylint.txt#L0
See https://www.pylint.org/ for more details R0801:Similar lines in 2 files ==test_gap_c:[15:90] ==test_gap_s:[15:89] logger = logging.getLogger(__name__) async def device_power_on(device) -> None: while True: try: await device.power_on() break except Exception: continue # wait for shell response async def _wait_for_shell_response(dut, response, max_wait_sec=20): """ _wait_for_shell_response() is used to wait for shell response. It will return after finding a specific 'response' or waiting long enough. :param dut: :param response: shell response that you want to monitor. :param max_wait_sec: maximum waiting time :return: found: whether the 'response' is found; lines: DUT shell response """ found = False lines = [] try: for _ in range(0, max_wait_sec): read_lines = dut.readlines() for line in read_lines: if response in line: found = True break lines = lines + read_lines await asyncio.sleep(1) logger.info(f'{str(lines)}') except Exception as e: logger.error(f'{e}!', exc_info=True) raise e return found, lines # interact between script and DUT async def send_cmd_to_iut( shell, dut, cmd, response=None, expect_to_find_resp=True, max_wait_sec=20 ): """ send_cmd_to_iut() is used to send shell cmd to DUT and monitor the response. It can choose whether to monitor the shell response of DUT. Use 'expect_to_find_resp' to set whether to expect the response to contain certain 'response'. 'max_wait_sec' indicates the maximum waiting time. For 'expect_to_find_resp=False', this is useful because we need to wait long enough to get enough response to more accurately judge that the response does not contain specific characters. :param shell: :param dut: :param cmd: shell cmd sent to DUT :param response: shell response that you want to monitor. 'None' means not to monitor any response. :param expect_to_find_resp: set whether to expect the response to contain certain 'response' :param max_wait_sec: maximum monitoring time :return: DUT shell response """ shell.exec_command(cmd) if response is not None: found, lines = await _wait_for_shell_response(dut, response, max_wait_sec) else: found = True lines = '' assert found is expect_to_find_resp return lines # dongle limited discovery async def start_limited_discovery(device): (duplicate-code) File:tests/net/socket/tls_configurations/pytest/test_app_vs_openssl.py Line:1 Column:0 R0801:Similar lines in 2 files ==conftest:[10:55] ==conftest:[10:55] logger = logging.getLogger(__name__) def pytest_addoption(parser) -> None: """Add local parser options to pytest.""" parser.addoption('--hci-transport', default=None, help='Configuration HCI transport for bumble') @pytest.fixture(name='initialize', scope='session') def fixture_initialize(request, shell: Shell, dut: DeviceAdapter): """Session initializtion""" # Get HCI transport for bumble hci = request.config.getoption('--hci-transport') if hci is None: for fixture in dut.device_config.fixtures: if fixture.startswith('usb_hci:'): hci = fixture.split(sep=':', maxsplit=1)[1] break assert hci is not None lines = shell.exec_command("bt init") lines = dut.readlines_until("Bluetooth initialized") regex = r'Identity: (?P<bd_addr>(.*?):(.*?):(.*?):(.*?):(.*?):(.*?) *\((.*?)\))' bd_addr = None for line in lines: logger.info(f"Shell log {line}") m = re.search(regex, line) if m: bd_addr = m.group('bd_addr') if bd_addr is None: logger.error('Fail to get IUT BD address') raise AssertionError logger.info('initialized') return hci, bd_addr @pytest.fixture def device_under_test(initialize): logger.info('Start runnin
Run compliance checks on patch series (PR): Identity.txt#L0
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines for more details a5846f92ba1747518d33e0bf058349d8cb51a039: author email (49699333+dependabot[bot]@users.noreply.github.com) must be a real email and cannot end in @users.noreply.github.com a5846f92ba1747518d33e0bf058349d8cb51a039: Signed-off-by line (Signed-off-by: dependabot[bot] <[email protected]>) does not follow the syntax: First Last <email>.
Run compliance checks on patch series (PR): Checkpatch.txt#L0
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#coding-style for more details. LINE_SPACING: Missing a blank line after declarations File:drivers/sdhc/xlnx_sdhc.c Line:554 SPACING: need consistent spacing around '*' (ctx:WxV) File:include/zephyr/sys/list_gen.h Line:59 SPACING: need consistent spacing around '*' (ctx:WxV) File:include/zephyr/sys/list_gen.h Line:66 SPACING: need consistent spacing around '*' (ctx:WxV) File:include/zephyr/sys/list_gen.h Line:73 SPACING: need consistent spacing around '*' (ctx:WxV) File:include/zephyr/sys/list_gen.h Line:239 SPACING: need consistent spacing around '*' (ctx:WxV) File:include/zephyr/sys/list_gen.h Line:239 SPACING: need consistent spacing around '*' (ctx:WxO) File:include/zephyr/sys/list_gen.h Line:240 STORAGE_CLASS: storage class 'static' should be located before type 'volatile' File:tests/drivers/uart/uart_async_api/src/test_uart_async.c Line:1021 STORAGE_CLASS: storage class 'static' should be located before type 'volatile' File:tests/drivers/uart/uart_async_api/src/test_uart_async.c Line:1023 STORAGE_CLASS: storage class 'static' should be located before type 'volatile' File:tests/drivers/uart/uart_async_api/src/test_uart_async.c Line:1026 STORAGE_CLASS: storage class 'static' should be located before type 'volatile' File:tests/drivers/uart/uart_async_api/src/test_uart_async.c Line:1028 STORAGE_CLASS: storage class 'static' should be located before type 'volatile' File:tests/drivers/uart/uart_async_api/src/test_uart_async.c Line:1031 STORAGE_CLASS: storage class 'static' should be located before type 'volatile' File:tests/drivers/uart/uart_async_api/src/test_uart_async.c Line:1032 STORAGE_CLASS: storage class 'static' should be located before type 'volatile' File:tests/drivers/uart/uart_async_api/src/test_uart_async.c Line:1033
Run compliance checks on patch series (PR): BinaryFiles.txt#L0
No binary files allowed. Binary file not allowed: samples/net/sockets/coap_server/src/certs/ca.der Binary file not allowed: samples/net/sockets/coap_server/src/certs/coaps-server-cert.der Binary file not allowed: samples/net/sockets/coap_server/src/certs/coaps-server-key.der Binary file not allowed: samples/net/sockets/coap_server/src/certs/server.der Binary file not allowed: samples/net/sockets/coap_server/src/certs/server_privkey.der
Run compliance checks on patch series (PR)
Process completed with exit code 6.
SPACING: include/zephyr/sys/list_gen.h#L240
include/zephyr/sys/list_gen.h:240 need consistent spacing around '*' (ctx:WxO)
SPACING: include/zephyr/sys/list_gen.h#L239
include/zephyr/sys/list_gen.h:239 need consistent spacing around '*' (ctx:WxV)
SPACING: include/zephyr/sys/list_gen.h#L239
include/zephyr/sys/list_gen.h:239 need consistent spacing around '*' (ctx:WxV)
SPACING: include/zephyr/sys/list_gen.h#L73
include/zephyr/sys/list_gen.h:73 need consistent spacing around '*' (ctx:WxV)
SPACING: include/zephyr/sys/list_gen.h#L66
include/zephyr/sys/list_gen.h:66 need consistent spacing around '*' (ctx:WxV)
SPACING: include/zephyr/sys/list_gen.h#L59
include/zephyr/sys/list_gen.h:59 need consistent spacing around '*' (ctx:WxV)
Python format error: tests/bluetooth/classic/gap_s/pytest/test_gap_s.py#L0
tests/bluetooth/classic/gap_s/pytest/test_gap_s.py Run 'ruff format tests/bluetooth/classic/gap_s/pytest/test_gap_s.py'
Run compliance checks on patch series (PR): ClangFormat.txt#L0
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details. You may want to run clang-format on this change: -#define DWT_LSR_Present_Msk \ - IF_ENABLED(CONFIG_ZEPHYR_CMSIS_MODULE, (ITM_LSR_Present_Msk)) \ +#define DWT_LSR_Present_Msk \ + IF_ENABLED(CONFIG_ZEPHYR_CMSIS_MODULE, (ITM_LSR_Present_Msk)) \ IF_DISABLED(CONFIG_ZEPHYR_CMSIS_MODULE, (ITM_LSR_PRESENT_Msk)) #endif #if !defined DWT_LSR_Access_Msk -#define DWT_LSR_Access_Msk \ - IF_ENABLED(CONFIG_ZEPHYR_CMSIS_MODULE, (ITM_LSR_Access_Msk)) \ +#define DWT_LSR_Access_Msk \ + IF_ENABLED(CONFIG_ZEPHYR_CMSIS_MODULE, (ITM_LSR_Access_Msk)) \ File:arch/arm/include/cortex_m/dwt.h Line:46 You may want to run clang-format on this change: -#define SWINT1_IRQ_LINE 27 -#define SWINT1_PRIO 14 +#define SWINT1_IRQ_LINE 27 +#define SWINT1_PRIO 14 /* Address of the software interrupt trigger register for SWINT1 */ #define SWINT_REGISTER_ADDRESS 0x872E0 -#define SWINTR_SWINT *(uint8_t *)(SWINT_REGISTER_ADDRESS) +#define SWINTR_SWINT *(uint8_t *)(SWINT_REGISTER_ADDRESS) File:arch/rx/core/irq_offload.c Line:25 You may want to run clang-format on this change: - k_thread_entry_t entry, void *arg1, void *arg2, void *arg3) + k_thread_entry_t entry, void *arg1, void *arg2, void *arg3) File:arch/rx/core/thread.c Line:23 You may want to run clang-format on this change: -#define R_X86_64_64 1 -#define R_X86_64_PC32 2 -#define R_X86_64_PLT32 4 -#define R_X86_64_32 10 -#define R_X86_64_32S 11 +#define R_X86_64_64 1 +#define R_X86_64_PC32 2 +#define R_X86_64_PLT32 4 +#define R_X86_64_32 10 +#define R_X86_64_32S 11 File:arch/x86/core/elf.c Line:21 You may want to run clang-format on this change: - const elf_shdr_t *shdr) + const elf_shdr_t *shdr) File:arch/x86/core/elf.c Line:35 You may want to run clang-format on this change: -#define R_386_32 1 -#define R_286_PC32 2 +#define R_386_32 1 +#define R_286_PC32 2 File:arch/x86/core/elf.c Line:83 You may want to run clang-format on this change: - const elf_shdr_t *shdr) + const elf_shdr_t *shdr) File:arch/x86/core/elf.c Line:97 You may want to run clang-format on this change: - *got_entry < - ext->sect_hdrs[sh_ndx].sh_addr + ext->sect_hdrs[sh_ndx].sh_size) { + *got_entry < ext->sect_hdrs[sh_ndx].sh_addr + + ext->sect_hdrs[sh_ndx].sh_size) { File:arch/xtensa/core/elf.c Line:56 You may want to run clang-format on this change: - struct arch_mem_domain *domain = - &(incoming->mem_domain_info.mem_domain->arch); + struct arch_mem_domain *domain = &(incoming->mem_domain_info.mem_domain->arch); File:arch/xtensa/core/ptables.c Line:1134 You may want to run clang-format on this change: - { - .option = "disconnect_on_exit", - .type = 'b', - .name = "term", - .dest = (void *)&bsim_disconnect_on_exit, - .descript = "If set to 1, on exit only disconnect this device from the Phy and let " - "the simulation continue. Otherwise (default) on exit terminate the " - "whole simulation." - }, - ARG_TABLE_ENDMARKER - }; + {.option = "disconnect_on_exit", + .type = 'b', + .name = "term", + .dest = (void *)&bsim_disconnect_on_exit, + .descript = + "If set to 1, on exit only disconnect this device from the Phy and let " + "the simulation continue. Otherwise (default) on exit terminate the " + "whole simulation."}, + ARG_TABLE_ENDMARKER}; File:boards/native/nrf_bsim/common/runner_hooks.c Line:82 You may want to run clang-format on this change: - File:boards/nxp/frdm_mcxa166/board.c Line:162 You may want to run clang-format on this change: - File:boards/nxp/frdm_mcxa276/board.c Line:162 You may want to run clang-format on this chan
STORAGE_CLASS: tests/drivers/uart/uart_async_api/src/test_uart_async.c#L1033
tests/drivers/uart/uart_async_api/src/test_uart_async.c:1033 storage class 'static' should be located before type 'volatile'
STORAGE_CLASS: tests/drivers/uart/uart_async_api/src/test_uart_async.c#L1032
tests/drivers/uart/uart_async_api/src/test_uart_async.c:1032 storage class 'static' should be located before type 'volatile'
STORAGE_CLASS: tests/drivers/uart/uart_async_api/src/test_uart_async.c#L1031
tests/drivers/uart/uart_async_api/src/test_uart_async.c:1031 storage class 'static' should be located before type 'volatile'
STORAGE_CLASS: tests/drivers/uart/uart_async_api/src/test_uart_async.c#L1028
tests/drivers/uart/uart_async_api/src/test_uart_async.c:1028 storage class 'static' should be located before type 'volatile'
STORAGE_CLASS: tests/drivers/uart/uart_async_api/src/test_uart_async.c#L1026
tests/drivers/uart/uart_async_api/src/test_uart_async.c:1026 storage class 'static' should be located before type 'volatile'
STORAGE_CLASS: tests/drivers/uart/uart_async_api/src/test_uart_async.c#L1023
tests/drivers/uart/uart_async_api/src/test_uart_async.c:1023 storage class 'static' should be located before type 'volatile'
STORAGE_CLASS: tests/drivers/uart/uart_async_api/src/test_uart_async.c#L1021
tests/drivers/uart/uart_async_api/src/test_uart_async.c:1021 storage class 'static' should be located before type 'volatile'
LINE_SPACING: drivers/sdhc/xlnx_sdhc.c#L554
drivers/sdhc/xlnx_sdhc.c:554 Missing a blank line after declarations
R0801: tests/net/socket/tls_configurations/pytest/test_app_vs_openssl.py#L1
tests/net/socket/tls_configurations/pytest/test_app_vs_openssl.py:1 Similar lines in 2 files ==conftest:[10:55] ==conftest:[10:55] logger = logging.getLogger(__name__) def pytest_addoption(parser) -> None: """Add local parser options to pytest.""" parser.addoption('--hci-transport', default=None, help='Configuration HCI transport for bumble') @pytest.fixture(name='initialize', scope='session') def fixture_initialize(request, shell: Shell, dut: DeviceAdapter): """Session initializtion""" # Get HCI transport for bumble hci = request.config.getoption('--hci-transport') if hci is None: for fixture in dut.device_config.fixtures: if fixture.startswith('usb_hci:'): hci = fixture.split(sep=':', maxsplit=1)[1] break assert hci is not None lines = shell.exec_command("bt init") lines = dut.readlines_until("Bluetooth initialized") regex = r'Identity: (?P<bd_addr>(.*?):(.*?):(.*?):(.*?):(.*?):(.*?) *\((.*?)\))' bd_addr = None for line in lines: logger.info(f"Shell log {line}") m = re.search(regex, line) if m: bd_addr = m.group('bd_addr') if bd_addr is None: logger.error('Fail to get IUT BD address') raise AssertionError logger.info('initialized') return hci, bd_addr @pytest.fixture def device_under_test(initialize): logger.info('Start running testcase') yield initialize logger.info('Done') (duplicate-code)
R0801: tests/net/socket/tls_configurations/pytest/test_app_vs_openssl.py#L1
tests/net/socket/tls_configurations/pytest/test_app_vs_openssl.py:1 Similar lines in 2 files ==test_gap_c:[15:90] ==test_gap_s:[15:89] logger = logging.getLogger(__name__) async def device_power_on(device) -> None: while True: try: await device.power_on() break except Exception: continue # wait for shell response async def _wait_for_shell_response(dut, response, max_wait_sec=20): """ _wait_for_shell_response() is used to wait for shell response. It will return after finding a specific 'response' or waiting long enough. :param dut: :param response: shell response that you want to monitor. :param max_wait_sec: maximum waiting time :return: found: whether the 'response' is found; lines: DUT shell response """ found = False lines = [] try: for _ in range(0, max_wait_sec): read_lines = dut.readlines() for line in read_lines: if response in line: found = True break lines = lines + read_lines await asyncio.sleep(1) logger.info(f'{str(lines)}') except Exception as e: logger.error(f'{e}!', exc_info=True) raise e return found, lines # interact between script and DUT async def send_cmd_to_iut( shell, dut, cmd, response=None, expect_to_find_resp=True, max_wait_sec=20 ): """ send_cmd_to_iut() is used to send shell cmd to DUT and monitor the response. It can choose whether to monitor the shell response of DUT. Use 'expect_to_find_resp' to set whether to expect the response to contain certain 'response'. 'max_wait_sec' indicates the maximum waiting time. For 'expect_to_find_resp=False', this is useful because we need to wait long enough to get enough response to more accurately judge that the response does not contain specific characters. :param shell: :param dut: :param cmd: shell cmd sent to DUT :param response: shell response that you want to monitor. 'None' means not to monitor any response. :param expect_to_find_resp: set whether to expect the response to contain certain 'response' :param max_wait_sec: maximum monitoring time :return: DUT shell response """ shell.exec_command(cmd) if response is not None: found, lines = await _wait_for_shell_response(dut, response, max_wait_sec) else: found = True lines = '' assert found is expect_to_find_resp return lines # dongle limited discovery async def start_limited_discovery(device): (duplicate-code)
You may want to run clang-format on this change: boards/native/nrf_bsim/common/runner_hooks.c#L82
boards/native/nrf_bsim/common/runner_hooks.c:82 - { - .option = "disconnect_on_exit", - .type = 'b', - .name = "term", - .dest = (void *)&bsim_disconnect_on_exit, - .descript = "If set to 1, on exit only disconnect this device from the Phy and let " - "the simulation continue. Otherwise (default) on exit terminate the " - "whole simulation." - }, - ARG_TABLE_ENDMARKER - }; + {.option = "disconnect_on_exit", + .type = 'b', + .name = "term", + .dest = (void *)&bsim_disconnect_on_exit, + .descript = + "If set to 1, on exit only disconnect this device from the Phy and let " + "the simulation continue. Otherwise (default) on exit terminate the " + "whole simulation."}, + ARG_TABLE_ENDMARKER};
You may want to run clang-format on this change: arch/xtensa/core/ptables.c#L1134
arch/xtensa/core/ptables.c:1134 - struct arch_mem_domain *domain = - &(incoming->mem_domain_info.mem_domain->arch); + struct arch_mem_domain *domain = &(incoming->mem_domain_info.mem_domain->arch);
You may want to run clang-format on this change: arch/xtensa/core/elf.c#L56
arch/xtensa/core/elf.c:56 - *got_entry < - ext->sect_hdrs[sh_ndx].sh_addr + ext->sect_hdrs[sh_ndx].sh_size) { + *got_entry < ext->sect_hdrs[sh_ndx].sh_addr + + ext->sect_hdrs[sh_ndx].sh_size) {
You may want to run clang-format on this change: arch/x86/core/elf.c#L97
arch/x86/core/elf.c:97 - const elf_shdr_t *shdr) + const elf_shdr_t *shdr)
You may want to run clang-format on this change: arch/x86/core/elf.c#L83
arch/x86/core/elf.c:83 -#define R_386_32 1 -#define R_286_PC32 2 +#define R_386_32 1 +#define R_286_PC32 2
You may want to run clang-format on this change: arch/x86/core/elf.c#L35
arch/x86/core/elf.c:35 - const elf_shdr_t *shdr) + const elf_shdr_t *shdr)
You may want to run clang-format on this change: arch/x86/core/elf.c#L21
arch/x86/core/elf.c:21 -#define R_X86_64_64 1 -#define R_X86_64_PC32 2 -#define R_X86_64_PLT32 4 -#define R_X86_64_32 10 -#define R_X86_64_32S 11 +#define R_X86_64_64 1 +#define R_X86_64_PC32 2 +#define R_X86_64_PLT32 4 +#define R_X86_64_32 10 +#define R_X86_64_32S 11
You may want to run clang-format on this change: arch/rx/core/thread.c#L23
arch/rx/core/thread.c:23 - k_thread_entry_t entry, void *arg1, void *arg2, void *arg3) + k_thread_entry_t entry, void *arg1, void *arg2, void *arg3)
You may want to run clang-format on this change: arch/rx/core/irq_offload.c#L25
arch/rx/core/irq_offload.c:25 -#define SWINT1_IRQ_LINE 27 -#define SWINT1_PRIO 14 +#define SWINT1_IRQ_LINE 27 +#define SWINT1_PRIO 14 /* Address of the software interrupt trigger register for SWINT1 */ #define SWINT_REGISTER_ADDRESS 0x872E0 -#define SWINTR_SWINT *(uint8_t *)(SWINT_REGISTER_ADDRESS) +#define SWINTR_SWINT *(uint8_t *)(SWINT_REGISTER_ADDRESS)
You may want to run clang-format on this change: arch/arm/include/cortex_m/dwt.h#L46
arch/arm/include/cortex_m/dwt.h:46 -#define DWT_LSR_Present_Msk \ - IF_ENABLED(CONFIG_ZEPHYR_CMSIS_MODULE, (ITM_LSR_Present_Msk)) \ +#define DWT_LSR_Present_Msk \ + IF_ENABLED(CONFIG_ZEPHYR_CMSIS_MODULE, (ITM_LSR_Present_Msk)) \ IF_DISABLED(CONFIG_ZEPHYR_CMSIS_MODULE, (ITM_LSR_PRESENT_Msk)) #endif #if !defined DWT_LSR_Access_Msk -#define DWT_LSR_Access_Msk \ - IF_ENABLED(CONFIG_ZEPHYR_CMSIS_MODULE, (ITM_LSR_Access_Msk)) \ +#define DWT_LSR_Access_Msk \ + IF_ENABLED(CONFIG_ZEPHYR_CMSIS_MODULE, (ITM_LSR_Access_Msk)) \

Artifacts

Produced during runtime
Name Size Digest
compliance.xml Expired
240 KB
sha256:9312b0bf720510204053c893e2ed2eab6ece36aadb0755261de2b6576c53b69b