Skip to content

Xo separation

Xo separation #12394

Triggered via pull request October 8, 2025 13:12
Status Failure
Total duration 3m 4s
Artifacts 1

compliance.yml

on: pull_request
Run compliance checks on patch series (PR)
2m 59s
Run compliance checks on patch series (PR)
Fit to window
Zoom out
Zoom in

Annotations

14 errors, 11 warnings, and 2 notices
Run compliance checks on patch series (PR)
Process completed with exit code 1.
Run compliance checks on patch series (PR): Nits.txt#L0
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#coding-style for more details. Missing newline at end of 'drivers/clock_control/clock_control_nrf_common.h'. Check your text editor settings. Missing newline at end of 'drivers/clock_control/clock_control_nrf_hfclk.c'. Check your text editor settings.
Run compliance checks on patch series (PR): GitDiffCheck.txt#L0
Git conflict markers and whitespace errors are not allowed in added changes 58dd19f42dd66e9160935839cd2fceaaa8c6ff52: drivers/clock_control/clock_control_nrf_xo.c:512: trailing whitespace. 58dd19f42dd66e9160935839cd2fceaaa8c6ff52: drivers/clock_control/clock_control_nrf_xo.c:538: space before tab in indent. 39c9341c4a294780a102bf09f748cd5165ac30af: drivers/clock_control/clock_control_nrf.c:774: trailing whitespace. 39c9341c4a294780a102bf09f748cd5165ac30af: drivers/clock_control/clock_control_nrf_hfclk.c:90: trailing whitespace. 39c9341c4a294780a102bf09f748cd5165ac30af: drivers/clock_control/clock_control_nrf_hfclk.c:231: trailing whitespace. 39c9341c4a294780a102bf09f748cd5165ac30af: drivers/clock_control/clock_control_nrf_hfclk.c:420: space before tab in indent. 39c9341c4a294780a102bf09f748cd5165ac30af: tests/drivers/clock_control/clock_control_api/src/nrf_device_subsys.h:40: trailing whitespace.
Run compliance checks on patch series (PR): Checkpatch.txt#L0
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#coding-style for more details. LEADING_SPACE: please, no spaces at the start of a line File:drivers/clock_control/Kconfig.nrf Line:332 LEADING_SPACE: please, no spaces at the start of a line File:drivers/clock_control/Kconfig.nrf Line:338 TRAILING_WHITESPACE: trailing whitespace File:drivers/clock_control/clock_control_nrf.c Line:774 LEADING_SPACE: please, no spaces at the start of a line File:drivers/clock_control/clock_control_nrf.c Line:774 INITIALISED_STATIC: do not initialise statics to false File:drivers/clock_control/clock_control_nrf_common.c Line:11 LEADING_SPACE: please, no spaces at the start of a line File:drivers/clock_control/clock_control_nrf_common.c Line:24 SPACING: space prohibited after that open parenthesis '(' File:drivers/clock_control/clock_control_nrf_common.c Line:27 SPACING: space prohibited before that close parenthesis ')' File:drivers/clock_control/clock_control_nrf_common.c Line:27 SPACING: space prohibited after that open parenthesis '(' File:drivers/clock_control/clock_control_nrf_common.h Line:15 SPACING: space prohibited before that close parenthesis ')' File:drivers/clock_control/clock_control_nrf_common.h Line:15 MISSING_EOF_NEWLINE: adding a line without newline at end of file File:drivers/clock_control/clock_control_nrf_common.h Line:17 C99_COMMENTS: do not use C99 // comments File:drivers/clock_control/clock_control_nrf_common.h Line:17 CODE_INDENT: code indent should use tabs where possible File:drivers/clock_control/clock_control_nrf_hfclk.c Line:35 LEADING_SPACE: please, no spaces at the start of a line File:drivers/clock_control/clock_control_nrf_hfclk.c Line:35 TRAILING_WHITESPACE: trailing whitespace File:drivers/clock_control/clock_control_nrf_hfclk.c Line:90 POINTER_LOCATION: "(foo*)" should be "(foo *)" File:drivers/clock_control/clock_control_nrf_hfclk.c Line:92 POINTER_LOCATION: "(foo*)" should be "(foo *)" File:drivers/clock_control/clock_control_nrf_hfclk.c Line:97 POINTER_LOCATION: "(foo*)" should be "(foo *)" File:drivers/clock_control/clock_control_nrf_hfclk.c Line:98 POINTER_LOCATION: "(foo*)" should be "(foo *)" File:drivers/clock_control/clock_control_nrf_hfclk.c Line:100 POINTER_LOCATION: "(foo*)" should be "(foo *)" File:drivers/clock_control/clock_control_nrf_hfclk.c Line:144 POINTER_LOCATION: "(foo*)" should be "(foo *)" File:drivers/clock_control/clock_control_nrf_hfclk.c Line:149 LEADING_SPACE: please, no spaces at the start of a line File:drivers/clock_control/clock_control_nrf_hfclk.c Line:158 LINE_SPACING: Missing a blank line after declarations File:drivers/clock_control/clock_control_nrf_hfclk.c Line:161 POINTER_LOCATION: "(foo*)" should be "(foo *)" File:drivers/clock_control/clock_control_nrf_hfclk.c Line:161 POINTER_LOCATION: "(foo*)" should be "(foo *)" File:drivers/clock_control/clock_control_nrf_hfclk.c Line:194 POINTER_LOCATION: "(foo*)" should be "(foo *)" File:drivers/clock_control/clock_control_nrf_hfclk.c Line:196 POINTER_LOCATION: "(foo*)" should be "(foo *)" File:drivers/clock_control/clock_control_nrf_hfclk.c Line:197 POINTER_LOCATION: "(foo*)" should be "(foo *)" File:drivers/clock_control/clock_control_nrf_hfclk.c Line:201 FUNCTION_WITHOUT_ARGS: Bad function definition - void clock_event_handler() should probably be void clock_event_handler(void) File:drivers/clock_control/clock_control_nrf_hfclk.c Line:205 BLOCK_COMMENT_STYLE: Block comments should align the * on each line File:drivers/clock_control/clock_control_nrf_hfclk.c Line:210 POINTER_LOCATION: "(foo*)" should be "(foo *)" File:drivers/clock_control/clock_control_nrf_hfclk.c Line:212 TRAILING_WHITESPACE: trailing whitespace File:drivers/clock_control/clock_control_nrf_hfclk.c Line:231 CODE_INDENT: code indent should use tabs where possible File:drivers/clock_control/clock_control_nrf_hfclk.c Line:231 LEADING_SPACE: please, no spaces at the start of a line File:drivers/clock_control/clock_control_nrf_hfclk.c Line:231 POINTER_LOCATION: "(foo*)" should be "(foo *)" File:drivers/c
POINTER_LOCATION: drivers/clock_control/clock_control_nrf_hfclk.c#L92
drivers/clock_control/clock_control_nrf_hfclk.c:92 "(foo*)" should be "(foo *)"
TRAILING_WHITESPACE: drivers/clock_control/clock_control_nrf_hfclk.c#L90
drivers/clock_control/clock_control_nrf_hfclk.c:90 trailing whitespace
CODE_INDENT: drivers/clock_control/clock_control_nrf_hfclk.c#L35
drivers/clock_control/clock_control_nrf_hfclk.c:35 code indent should use tabs where possible
C99_COMMENTS: drivers/clock_control/clock_control_nrf_common.h#L17
drivers/clock_control/clock_control_nrf_common.h:17 do not use C99 // comments
SPACING: drivers/clock_control/clock_control_nrf_common.h#L15
drivers/clock_control/clock_control_nrf_common.h:15 space prohibited before that close parenthesis ')'
SPACING: drivers/clock_control/clock_control_nrf_common.h#L15
drivers/clock_control/clock_control_nrf_common.h:15 space prohibited after that open parenthesis '('
SPACING: drivers/clock_control/clock_control_nrf_common.c#L27
drivers/clock_control/clock_control_nrf_common.c:27 space prohibited before that close parenthesis ')'
SPACING: drivers/clock_control/clock_control_nrf_common.c#L27
drivers/clock_control/clock_control_nrf_common.c:27 space prohibited after that open parenthesis '('
INITIALISED_STATIC: drivers/clock_control/clock_control_nrf_common.c#L11
drivers/clock_control/clock_control_nrf_common.c:11 do not initialise statics to false
TRAILING_WHITESPACE: drivers/clock_control/clock_control_nrf.c#L774
drivers/clock_control/clock_control_nrf.c:774 trailing whitespace
Run compliance checks on patch series (PR): ClangFormat.txt#L0
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details. You may want to run clang-format on this change: - + File:drivers/clock_control/clock_control_nrf.c Line:775 You may want to run clang-format on this change: - /* temporary fix, it will be removed when all the clocks are moved to their files */ - nrfx_clock_irq_handler(); + /* temporary fix, it will be removed when all the clocks are moved to their files */ + nrfx_clock_irq_handler(); } -void clock_control_nrf_common_connect_irq( void ) +void clock_control_nrf_common_connect_irq(void) { if (irq_connected) { return; } irq_connected = true; - IRQ_CONNECT(DT_INST_IRQN(0), DT_INST_IRQ(0, priority), - nrfx_isr, clock_irq_handler, 0); + IRQ_CONNECT(DT_INST_IRQN(0), DT_INST_IRQ(0, priority), nrfx_isr, clock_irq_handler, 0); File:drivers/clock_control/clock_control_nrf_common.c Line:36 An exception occurred in ClangFormat: Traceback (most recent call last): File "/home/runner/work/sdk-zephyr/sdk-zephyr/./scripts/ci/check_compliance.py", line 393, in run subprocess.run((exe, '-p1'), File "/opt/hostedtoolcache/Python/3.12.11/x64/lib/python3.12/subprocess.py", line 571, in run raise CalledProcessError(retcode, process.args, subprocess.CalledProcessError: Command '('clang-format-diff.py', '-p1')' returned non-zero exit status 1. During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/home/runner/work/sdk-zephyr/sdk-zephyr/./scripts/ci/check_compliance.py", line 2345, in _main test.run() File "/home/runner/work/sdk-zephyr/sdk-zephyr/./scripts/ci/check_compliance.py", line 401, in run patchset = unidiff.PatchSet.from_string(ex.output, encoding="utf-8") ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/hostedtoolcache/Python/3.12.11/x64/lib/python3.12/site-packages/unidiff/patch.py", line 616, in from_string return cls(cls._convert_string(data, encoding, errors)) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/hostedtoolcache/Python/3.12.11/x64/lib/python3.12/site-packages/unidiff/patch.py", line 462, in __init__ self._parse(data, encoding=encoding, metadata_only=metadata_only) File "/opt/hostedtoolcache/Python/3.12.11/x64/lib/python3.12/site-packages/unidiff/patch.py", line 552, in _parse current_file._parse_hunk(line, diff, encoding, metadata_only) File "/opt/hostedtoolcache/Python/3.12.11/x64/lib/python3.12/site-packages/unidiff/patch.py", line 361, in _parse_hunk raise UnidiffParseError('Hunk is shorter than expected') unidiff.errors.UnidiffParseError: Hunk is shorter than expected
LEADING_SPACE: drivers/clock_control/clock_control_nrf_hfclk.c#L231
drivers/clock_control/clock_control_nrf_hfclk.c:231 please, no spaces at the start of a line
BLOCK_COMMENT_STYLE: drivers/clock_control/clock_control_nrf_hfclk.c#L210
drivers/clock_control/clock_control_nrf_hfclk.c:210 Block comments should align the * on each line
LINE_SPACING: drivers/clock_control/clock_control_nrf_hfclk.c#L161
drivers/clock_control/clock_control_nrf_hfclk.c:161 Missing a blank line after declarations
LEADING_SPACE: drivers/clock_control/clock_control_nrf_hfclk.c#L158
drivers/clock_control/clock_control_nrf_hfclk.c:158 please, no spaces at the start of a line
LEADING_SPACE: drivers/clock_control/clock_control_nrf_hfclk.c#L35
drivers/clock_control/clock_control_nrf_hfclk.c:35 please, no spaces at the start of a line
MISSING_EOF_NEWLINE: drivers/clock_control/clock_control_nrf_common.h#L17
drivers/clock_control/clock_control_nrf_common.h:17 adding a line without newline at end of file
LEADING_SPACE: drivers/clock_control/clock_control_nrf_common.c#L24
drivers/clock_control/clock_control_nrf_common.c:24 please, no spaces at the start of a line
LEADING_SPACE: drivers/clock_control/clock_control_nrf.c#L774
drivers/clock_control/clock_control_nrf.c:774 please, no spaces at the start of a line
LEADING_SPACE: drivers/clock_control/Kconfig.nrf#L338
drivers/clock_control/Kconfig.nrf:338 please, no spaces at the start of a line
LEADING_SPACE: drivers/clock_control/Kconfig.nrf#L332
drivers/clock_control/Kconfig.nrf:332 please, no spaces at the start of a line
You may want to run clang-format on this change: drivers/clock_control/clock_control_nrf_common.c#L36
drivers/clock_control/clock_control_nrf_common.c:36 - /* temporary fix, it will be removed when all the clocks are moved to their files */ - nrfx_clock_irq_handler(); + /* temporary fix, it will be removed when all the clocks are moved to their files */ + nrfx_clock_irq_handler(); } -void clock_control_nrf_common_connect_irq( void ) +void clock_control_nrf_common_connect_irq(void) { if (irq_connected) { return; } irq_connected = true; - IRQ_CONNECT(DT_INST_IRQN(0), DT_INST_IRQ(0, priority), - nrfx_isr, clock_irq_handler, 0); + IRQ_CONNECT(DT_INST_IRQN(0), DT_INST_IRQ(0, priority), nrfx_isr, clock_irq_handler, 0);
You may want to run clang-format on this change: drivers/clock_control/clock_control_nrf.c#L775
drivers/clock_control/clock_control_nrf.c:775 - +

Artifacts

Produced during runtime
Name Size Digest
compliance.xml
2.89 KB
sha256:d489d0496195ced4b09b8f1b92b1540e3f9d2d5fc8de063a76b992cb55510475