[nrf fromlist] ipc: icmsg: increase stack size of RX work queue thread #2082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrkoziar
force-pushed
the
fromlist_icmsg_wq_stack_size
branch
from
1a47712 to
efb125a
Compare
piotrkoziar
changed the title
piotrkoziar
force-pushed
the
fromlist_icmsg_wq_stack_size
branch
from
efb125a to
e106846
Compare
dawidprzybylo
approved these changes
Oct 11, 2024
piotrkoziar
force-pushed
the
fromlist_icmsg_wq_stack_size
branch
from
e106846 to
74d0663
Compare
Increases default size of stack used by work queue RX thread from 1024 to 1280 to avoid memory issues. After adding the buffer with the default size of 128 that is allocated on the thread's stack (see #77552), there is too little stack left during heavy stress. Upstream PR: zephyrproject-rtos/zephyr#79557 Signed-off-by: Piotr Koziar <[email protected]>
piotrkoziar
force-pushed
the
fromlist_icmsg_wq_stack_size
branch
from
74d0663 to
8c2813c
Compare
|
The commit was integrated outside of this PR. Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increases default size of stack used by work queue RX thread from 1024 to
20481280 to avoid memory issues.After adding the buffer with the default size of 128 that is allocated on the thread's stack (see #77552), there is too little stack left during heavy stress.
I observed the issues on nRF54H. I was stressing the device (doing different 802.15.4 operations in a loop).
I was consistently seeing weird parameter addresses (ending in
z_arm_usage_fault) inicmsg_stack ().Changing the stack size to >1280 solves the issue. I believe that this should be set as default as this scenario applies to a wide range of users who are stressing the device enough.
Edit: The increase to 2048 is problematic due to memory constraints. Let's increase to 1280, which is just enough.
Upstream PR: zephyrproject-rtos/zephyr#79557