[nrf fromtree] Bluetooth: Host: Fix issue where uninitialized value w… #2109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as used This change makes sure that when a call to `bt_id_set_scan_own_addr` is sucessful, i.e., the return value is 0, the `own_addr_type` will be set by the `bt_id_set_scan_own_addr`. Not setting the `own_addr_type` in a successful call to `bt_id_set_scan_own_addr` causes, for example, the `start_le_scan_ext` method in `scan.c` to use an uninitialized `own_addr_type`. Eventually this results in an unexpected failure further down in `start_le_scan_ext`, when sending HCI command to controller with an uninitialized `own_addr_type`. Signed-off-by: Erik Sandgren <[email protected]> (cherry picked from commit 5f59b35)
NordicBuilder
requested review from
Thalley,
alwa-nordic,
hermabe and
theob-pro
hermabe
approved these changes
Oct 15, 2024
ivaniushkov
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…as used
This change makes sure that when a call to
bt_id_set_scan_own_addris sucessful, i.e., the return value is 0, theown_addr_typewill be set by thebt_id_set_scan_own_addr.Not setting the
own_addr_typein a successful call tobt_id_set_scan_own_addrcauses, for example,the
start_le_scan_extmethod inscan.cto use an uninitializedown_addr_type.Eventually this results in an unexpected failure further down in
start_le_scan_ext, when sending HCI command to controller with an uninitializedown_addr_type.Signed-off-by: Erik Sandgren [email protected]
(cherry picked from commit 5f59b35)