[nrf fromtree] soc: nordic: nrf53: SOC_NRF53_CPUNET_ENABLE should not… #2116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NordicBuilder
requested review from
anangl,
jaz1-nordic,
kl-cruz,
magp-nordic,
masz-nordic and
nika-nordic
anangl
approved these changes
Oct 21, 2024
masz-nordic
approved these changes
Oct 22, 2024
kl-cruz
approved these changes
Oct 22, 2024
sean-madigan
force-pushed
the
remove_not_bt_from_53_kconfigs
branch
from
9797db0 to
b879be2
Compare
anangl
approved these changes
Oct 23, 2024
sean-madigan
force-pushed
the
remove_not_bt_from_53_kconfigs
branch
2 times, most recently
from
d4058a7 to
cd55491
Compare
rlubos
requested review from
a team,
carlescufi,
de-nordic and
nordic-krch
as code owners
sean-madigan
force-pushed
the
remove_not_bt_from_53_kconfigs
branch
from
cd55491 to
ab05141
Compare
|
@de-nordic @nordic-krch @carlescufi what is the conclusion for this actual fromtree PR (upstream merged)? It staled for 2 weeks from the last action. |
sean-madigan
force-pushed
the
remove_not_bt_from_53_kconfigs
branch
from
ab05141 to
bdc11b7
Compare
laxiLang
changed the title
… depend on !BT The previous changes in zephyrproject-rtos/zephyr#74304 assumed that because this is also handled in `bt_hci_transport_setup` that it shouldn't be done on initialisation too. However, if someone wants to develop their own app which uses BT and also wants to enable the CPUNET by default this KConfig should be available to them. Signed-off-by: Sean Madigan <[email protected]> (cherry picked from commit e4fa386)
sean-madigan
force-pushed
the
remove_not_bt_from_53_kconfigs
branch
from
bdc11b7 to
94b6e40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… depend on !BT
This causes issues as we still want the net core to be set up on initialisation if CONFIG_BT is enabled in many cases.
The previous changes in
zephyrproject-rtos/zephyr#74304 assumed that because this is also handled in
bt_hci_transport_setupthat it shouldn't be done on initialisation too.Also, I think that
bt_hci_transport_setupshould not be even controlling the network core state like it is currently and should be looked at being changed in a future PR.Upstream PR: zephyrproject-rtos/zephyr#79875