[nrf noup]: Revert "[nrf fromtree] cmake: use the warnings_as_errors ... #2160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejlmand
force-pushed
the
revert_cplusplus_warning_as_errors
branch
2 times, most recently
from
175fa74 to
f765e6d
Compare
|
@tejlmand Revert should have no |
… files" Some nRF Connect SDK samples are generating warnings for C++ code. nRF Connect SDK CI treats warnings as errors for code, but this was previous not active for C++ source code. Therfore revert the upstream warning-as-errors flag for C++ code. Revert this commit when nRF Connect SDK C++ source code is clear from warnings. This reverts commit f3e3ced. Signed-off-by: Torsten Rasmussen <[email protected]>
tejlmand
force-pushed
the
revert_cplusplus_warning_as_errors
branch
from
f765e6d to
e89c8e5
Compare
fixed. |
rlubos
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flag for cpp files"
Some nRF Connect SDK samples are generating warnings for C++ code. nRF Connect SDK CI treats warnings as errors for code, but this was previous not active for C++ source code.
Therfore revert the upstream warning-as-errors flag for C++ code. Revert this commit when nRF Connect SDK C++ source code is clear from warnings.
This reverts commit f3e3ced.