[nrf noup] drivers: spi: dw: disable pin retention after enabling #2255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required so that device stays functional while enabled. Signed-off-by: Gerard Marull-Paretas <[email protected]>
ahasztag
requested changes
Nov 12, 2024
Contributor
ahasztag
left a comment
ahasztag
left a comment
There was a problem hiding this comment.
This does not seem to be enough to fix the issue;
It seems that commenting out f443d32#diff-77c81f9bdc8e780abae508eb5aaf73b663975f3f9e98943decc8f0e4f1aee121R240
helps - If I'm not wrong the pinctrl API does not use this.
It seems that the only thing which uses the gpio_nrfx_pin_configure in the spi_dw driver is the CS pin -
sdk-zephyr/drivers/spi/spi_dw.c
Line 573 in a70d6bd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required so that device stays functional while enabled.