[nrf noup] drivers: spi: dw: turn on FAST_ACTIVE1 domain #2261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
gmarull
requested review from
ahasztag,
hubertmis,
karstenkoenig and
maciejpietras
FAST_ACTIVE1 domain needs to be kept ON while the peripheral is active (always in this driver). Signed-off-by: Gerard Marull-Paretas <[email protected]>
Contributor
|
What happened to clearing retain for dq0, dq1 and clock pins? Is that not needed as well or is this elsewhere? |
ahasztag
approved these changes
Nov 13, 2024
Contributor
|
Our tests pass on this PR |
robertstypa
approved these changes
Nov 13, 2024
karstenkoenig
approved these changes
Nov 13, 2024
Contributor
solved in the chat, retain never gets set. somewhat unintentionally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FAST_ACTIVE1 domain needs to be kept ON while the peripheral is active (always in this driver).