[nrf fromtree] Bluetooth: Host: Log when connecting while scanning ma… #2305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y give bad params The API documentation already states that the controller may require the scan interval and window used for scanning and connection establishment to be equal to obtain the best performance. This commit prints out a warning when this is not the case. The code size is unchanged when `CONFIG_BT_SCAN_AND_INITIATE_IN_PARALLEL=n`. This makes application developers aware that using the parameters `BT_LE_SCAN_ACTIVE_CONTINUOUS` with `BT_CONN_LE_CREATE_CONN` may not give the best performance. Signed-off-by: Rubin Gerritsen <[email protected]> (cherry picked from commit 56a22cb)
Tschet1
approved these changes
Nov 28, 2024
hermabe
approved these changes
Nov 28, 2024
alwa-nordic
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…y give bad params
The API documentation already states that the controller may require the scan interval and window used for scanning and connection establishment to be equal to obtain the best performance.
This commit prints out a warning when this is not the case. The code size is unchanged when
CONFIG_BT_SCAN_AND_INITIATE_IN_PARALLEL=n.This makes application developers aware that using the parameters
BT_LE_SCAN_ACTIVE_CONTINUOUSwithBT_CONN_LE_CREATE_CONNmay not give the best performance.Signed-off-by: Rubin Gerritsen [email protected]
(cherry picked from commit 56a22cb)