[nrf fromtree] runners: jlink: Fix NoneType object error #2375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordic-piks
approved these changes
Dec 13, 2024
nordic-krch
force-pushed
the
ncs/jlink_fix
branch
2 times, most recently
from
bd55237 to
602f9c0
Compare
The commit 221199e presents a bug that makes west flash failed with error. AttributeError: 'NoneType' object has no attribute 'startswith' In function is_tunnel(), tunnel may contain None and has no attribute "startswith". Fix it. Signed-off-by: Krzysztof Chruściński <[email protected]> Signed-off-by: Phi Bang Nguyen <[email protected]> (cherry picked from commit 829c03b)
spi-max-frequency was missing in overlay Now it's set to 8 MHz as per datasheet Signed-off-by: Jerzy Kasenberg <[email protected]> (cherry picked from commit 1d4b1ad)
|
Not critical for 2.9.0 so removing milestone |
nordicjm
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit 221199e presents a bug that makes west flash failed with error.
AttributeError: 'NoneType' object has no attribute 'startswith'
In function is_tunnel(), tunnel may contain None and has no attribute "startswith". Fix it.
Signed-off-by: Krzysztof Chruściński [email protected]
Signed-off-by: Phi Bang Nguyen [email protected]
(cherry picked from commit 829c03b)