Skip to content

Conversation

@piotrkoziar
Copy link
Contributor

…request/release

Makes 802.15.4 use the API under CONFIG_CLOCK_CONTROL_NRF2 in nrf_clock_control.h to request/release HFCLK.

Previous HFCLK requesting/releasing on nRF54H20 was more of a workaround and could produce issues when
comes to sharing the resources.

Signed-off-by: Piotr Koziar [email protected]
(cherry picked from commit b6ca9db)

@piotrkoziar
Copy link
Contributor Author

FYI @ankuns

@ankuns
Copy link
Contributor

ankuns commented Jan 22, 2025

Some fix is missing, see CI:

zephyr/modules/hal_nordic/nrf_802154/sl_opensource/platform/nrf_802154_clock_zephyr.c:36:13: warning: 'hfclk_on_callback' defined but not used [-Wunused-function]

zephyr/modules/hal_nordic/nrf_802154/sl_opensource/platform/nrf_802154_clock_zephyr.c:34:28: warning: 'hfclk_cli' defined but not used

The upstream commit is not enough. Please make it build in our CI here, then put necessary fix in upstream, then replace the fix commit with the cherrypick.

Copy link
Contributor

@ankuns ankuns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix required

@piotrkoziar
Copy link
Contributor Author

Decided to go with zephyrproject-rtos/zephyr#84343 that will enable the CLOCK_CONTROL required to use the zephyr's changes.
This should make the CI green, instead of enabling CLOCK_CONTROL in every sample that uses nRF 802.15.4 Radio Driver

…request/release

Makes 802.15.4 use the API under CONFIG_CLOCK_CONTROL_NRF2
in nrf_clock_control.h to request/release HFCLK.

Previous HFCLK requesting/releasing on nRF54H20 was more
of a workaround and could produce issues when
comes to sharing the resources.

Signed-off-by: Piotr Koziar <[email protected]>
(cherry picked from commit b6ca9db)
@piotrkoziar piotrkoziar force-pushed the nrf_802154_clock_control_2_hfclk branch from b325095 to 321e06e Compare January 23, 2025 10:18
@piotrkoziar
Copy link
Contributor Author

Checks with enabled CLOCK_CONTROL passed

@piotrkoziar piotrkoziar requested a review from ankuns January 23, 2025 12:45
…4 RD

Selects CLOCK_CONTROL config whenever nRF 802.15.4 Radio Driver
is enabled.

The driver requires HFCLK api available under the config switch.

Signed-off-by: Piotr Koziar <[email protected]>
(cherry picked from commit f6892a4)
@piotrkoziar piotrkoziar force-pushed the nrf_802154_clock_control_2_hfclk branch from 321e06e to d1c53ca Compare January 24, 2025 09:54
@nordicjm nordicjm merged commit 954583a into nrfconnect:main Jan 24, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants