[Backport v3.7.99-ncs2-branch][nrf fromtree] cmake: linker: ld: fix duplicate LINK_FLAGS #2443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original implementation of `toolchain_linker_finalize` duplicates the `LINK_FLAGS` in the link command. This can cause some problems like duplicate definitions when using link options like `--whole-archive`. This commit fixes it by removing the duplicate `LINK_FLAGS`. Fixes #82281 Signed-off-by: Axel Le Bourhis <[email protected]> (cherry picked from commit 8413113) Signed-off-by: Adrian Gielniewski <[email protected]>
|
@tejlmand Could you please take a look? |
|
@nrfconnect/ncs-code-owners please review. |
tejlmand
approved these changes
Feb 5, 2025
bjarki-andreasen
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original implementation of
toolchain_linker_finalizeduplicates theLINK_FLAGSin the link command. This can cause some problems like duplicate definitions when using link options like--whole-archive.This commit fixes it by removing the duplicate
LINK_FLAGS.Fixes #82281
(cherry picked from commit 8413113)