[nrf noup] tests: drivers: mspi: api: nRF54L15 fix device frequency #2484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 12, 2025
masz-nordic
approved these changes
Feb 13, 2025
magp-nordic
force-pushed
the
NRFX-6703-max-freq-fix
branch
from
c12d884 to
4b90557
Compare
jaz1-nordic
approved these changes
Feb 17, 2025
nordicjm
requested changes
Feb 18, 2025
| mspi0 = &sdp_mspi; | ||
| }; | ||
| }; | ||
|
|
There was a problem hiding this comment.
add to commit message:
nrf-squash! [nrf noup] tests: drivers: mspi: api: Add nRF54L15 overlay file
4b90557 to
cd3fb80
Compare
|
Discussed with @masz-nordic and @jaz1-nordic offline and we came to the conclusion, that the definition of device should be left in test overlay. However, the frequency needs to be fixed, so I modified this PR. |
magp-nordic
changed the title
magp-nordic
force-pushed
the
NRFX-6703-max-freq-fix
branch
from
cd3fb80 to
76742b7
Compare
masz-nordic
reviewed
Feb 19, 2025
tests/drivers/mspi/api/boards/nrf54l15dk_nrf54l15_cpuapp.overlay
Outdated
Show resolved
Hide resolved
magp-nordic
force-pushed
the
NRFX-6703-max-freq-fix
branch
3 times, most recently
from
6bfb143 to
0e66d07
Compare
masz-nordic
approved these changes
Feb 20, 2025
magp-nordic
force-pushed
the
NRFX-6703-max-freq-fix
branch
from
0e66d07 to
5cef15a
Compare
|
@nordicjm , please, review again |
nordicjm
approved these changes
Feb 21, 2025
magp-nordic
force-pushed
the
NRFX-6703-max-freq-fix
branch
from
5cef15a to
5edf477
Compare
nrf-squash! [nrf noup] tests: drivers: mspi: api: Add nRF54L15 overlay file Fix device frequency for nRF54L15. SDP MSPI allows only a predefined set of device frequencies. Signed-off-by: Magdalena Pastula <[email protected]>
magp-nordic
force-pushed
the
NRFX-6703-max-freq-fix
branch
from
5edf477 to
f69daea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove definition of dummy device since there is already external flash defined in SDP MSPI snippets.Changed to fix device frequency. Due to changes from nrfconnect/sdk-nrf#20209 the device frequency now needs to be one of the specified.